From fbcfa943cde6c55a41feda34d01741dd70e2b5e5 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Mon, 4 Mar 2024 10:00:05 +0100 Subject: [PATCH] resolvectl: output nice error message if we can't JSONify RR Some RR types we don't have a mapping to JSON for. Handle this reasonably. --- src/resolve/resolvectl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/resolve/resolvectl.c b/src/resolve/resolvectl.c index 580913b94e..405e8ec215 100644 --- a/src/resolve/resolvectl.c +++ b/src/resolve/resolvectl.c @@ -454,6 +454,9 @@ static int output_rr_packet(const void *d, size_t l, int ifindex) { if (r < 0) return log_error_errno(r, "Failed to convert RR to JSON: %m"); + if (!j) + return log_error_errno(SYNTHETIC_ERRNO(EOPNOTSUPP), "JSON formatting for records of type %s (%u) not available.", dns_type_to_string(rr->key->type), rr->key->type); + r = json_variant_dump(j, arg_json_format_flags, NULL, NULL); if (r < 0) return r; -- 2.25.1