From e5e6b7c225987551ebda14d2d7feadb66a64fb3c Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Tue, 26 Jul 2022 23:15:01 +0900 Subject: [PATCH] Revert "core/mount: fail early if directory cannot be created" This reverts commit e4de58c8231e47509ffeb3aa47620ca42f22d7f6. If mkdir() fails and the path does exist, then the later mount command fails anyway. Hence, it is not necessary to fail here. Fixes #24120. --- src/core/mount.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/core/mount.c b/src/core/mount.c index 836ba132cb..015a77221a 100644 --- a/src/core/mount.c +++ b/src/core/mount.c @@ -1054,10 +1054,8 @@ static void mount_enter_mounting(Mount *m) { r = mkdir_p_label(p->what, m->directory_mode); /* mkdir_p_label() can return -EEXIST if the target path exists and is not a directory - which is * totally OK, in case the user wants us to overmount a non-directory inode. */ - if (r < 0 && r != -EEXIST) { + if (r < 0 && r != -EEXIST) log_unit_error_errno(UNIT(m), r, "Failed to make bind mount source '%s': %m", p->what); - goto fail; - } } if (p) { -- 2.25.1