From e55fc5b09448e3e9bc8422da42585e9eeee8254c Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Tue, 19 Jun 2018 21:01:36 +0900 Subject: [PATCH] resolve: do not log about negative cache for mdns packets Fixes #9335. --- src/resolve/resolved-dns-cache.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/resolve/resolved-dns-cache.c b/src/resolve/resolved-dns-cache.c index a44872b93d..23cd662fb8 100644 --- a/src/resolve/resolved-dns-cache.c +++ b/src/resolve/resolved-dns-cache.c @@ -649,12 +649,13 @@ int dns_cache_put( * short time.) */ if (IN_SET(rcode, DNS_RCODE_SUCCESS, DNS_RCODE_NXDOMAIN)) { - if (dns_answer_size(answer) <= 0) { - char key_str[DNS_RESOURCE_KEY_STRING_MAX]; + if (key) { + char key_str[DNS_RESOURCE_KEY_STRING_MAX]; - log_debug("Not caching negative entry without a SOA record: %s", - dns_resource_key_to_string(key, key_str, sizeof key_str)); + log_debug("Not caching negative entry without a SOA record: %s", + dns_resource_key_to_string(key, key_str, sizeof key_str)); + } return 0; } -- 2.25.1