From e40b4caa1f913702ac94d7a810a767400d347db5 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Sun, 15 Dec 2019 15:50:43 +0100 Subject: [PATCH] basic/tmpfile: avoid maybe-uninitialized warning in mkostemp_safe() MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The variable is always initialized, but the compiler might not notice that. With gcc-9.2.1-1.fc31: $ CFLAGS='-Werror=maybe-uninitialized -Og' meson build $ ninja -C build [...] ../src/basic/tmpfile-util.c: In function ‘mkostemp_safe’: ../src/basic/tmpfile-util.c:76:12: error: ‘fd’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 76 | if (fd < 0) | ^ --- src/basic/tmpfile-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/basic/tmpfile-util.c b/src/basic/tmpfile-util.c index 2d201e1a57..decdafb9c9 100644 --- a/src/basic/tmpfile-util.c +++ b/src/basic/tmpfile-util.c @@ -67,7 +67,7 @@ int fopen_temporary(const char *path, FILE **ret_f, char **ret_temp_path) { /* This is much like mkostemp() but is subject to umask(). */ int mkostemp_safe(char *pattern) { - int fd; + int fd = -1; /* avoid false maybe-uninitialized warning */ assert(pattern); -- 2.25.1