From cc4f736ae37909570535c71d1f237f21328adaa5 Mon Sep 17 00:00:00 2001 From: Mike Yuan Date: Wed, 4 Sep 2024 18:16:51 +0200 Subject: [PATCH] core/namespace: add comment to explain the non-obvious assumption on /run/systemd/journal/ Follow-up for 119820f8abf587f96a11fb1f28ef854e84bc3122 Addresses https://github.com/systemd/systemd/pull/32487#discussion_r1743493196 --- src/core/namespace.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/core/namespace.c b/src/core/namespace.c index 026018438c..a38bad1474 100644 --- a/src/core/namespace.c +++ b/src/core/namespace.c @@ -1148,6 +1148,8 @@ static int mount_private_dev(const MountEntry *m, const NamespaceParameters *p) FOREACH_STRING(d, "/dev/mqueue", "/dev/hugepages") (void) bind_mount_device_dir(temporary_mount, d); + /* We assume /run/systemd/journal/ is available if not changing root, which isn't entirely accurate + * but shouldn't matter, as either way the user would get ENOENT when accessing /dev/log */ if ((!p->root_image && !p->root_directory) || p->bind_journal_sockets) { const char *devlog = strjoina(temporary_mount, "/dev/log"); if (symlink("/run/systemd/journal/dev-log", devlog) < 0) -- 2.25.1