From cb4aae634152a4f25e3da1778c70ca09fa750043 Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Fri, 29 Oct 2021 16:27:50 +0900 Subject: [PATCH] home: fix use of uninitialized value Fixes CID#1465077. --- src/home/homework-luks.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/home/homework-luks.c b/src/home/homework-luks.c index d1208e4678..7aee82a980 100644 --- a/src/home/homework-luks.c +++ b/src/home/homework-luks.c @@ -1278,6 +1278,7 @@ int home_setup_luks( return log_error_errno(errno, "Failed to open home directory: %m"); } else { _cleanup_free_ char *fstype = NULL, *subdir = NULL; + bool has_stat = false; const char *ip; struct stat st; @@ -1292,6 +1293,8 @@ int home_setup_luks( setup->image_fd = open_image_file(h, force_image_path, &st); if (setup->image_fd < 0) return setup->image_fd; + + has_stat = true; } r = luks_validate(setup->image_fd, user_record_user_name_and_realm(h), h->partition_uuid, &found_partition_uuid, &offset, &size); @@ -1304,7 +1307,7 @@ int home_setup_luks( setup->do_mark_clean = true; if (!user_record_luks_discard(h)) { - r = run_fallocate(setup->image_fd, &st); + r = run_fallocate(setup->image_fd, has_stat ? &st : NULL); if (r < 0) return r; } -- 2.25.1