From c8f054361b653d7cd8bf8f01ce29b8ba11e5939e Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Tue, 24 Apr 2018 18:16:44 +0200 Subject: [PATCH] machined: minor code cleanups, such as voidifying calls --- src/machine/machine.c | 1 - src/machine/machined.c | 13 +++++++++---- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/machine/machine.c b/src/machine/machine.c index 06dda19c43..008bbbc3f4 100644 --- a/src/machine/machine.c +++ b/src/machine/machine.c @@ -236,7 +236,6 @@ static void machine_unlink(Machine *m) { assert(m); if (m->unit) { - char *sl; sl = strjoina("/run/systemd/machines/unit:", m->unit); diff --git a/src/machine/machined.c b/src/machine/machined.c index 3577c809a4..41b4cdad6d 100644 --- a/src/machine/machined.c +++ b/src/machine/machined.c @@ -67,7 +67,8 @@ static int manager_new(Manager **ret) { static Manager* manager_unref(Manager *m) { Machine *machine; - assert(m); + if (!m) + return NULL; while (m->operations) operation_free(m->operations); @@ -387,14 +388,18 @@ int main(int argc, char *argv[]) { log_debug("systemd-machined running as pid "PID_FMT, getpid_cached()); - sd_notify(false, - "READY=1\n" - "STATUS=Processing requests..."); + (void) sd_notify(false, + "READY=1\n" + "STATUS=Processing requests..."); r = manager_run(m); log_debug("systemd-machined stopped as pid "PID_FMT, getpid_cached()); + (void) sd_notify(false, + "STOPPING=1\n" + "STATUS=Shutting down..."); + finish: return r < 0 ? EXIT_FAILURE : EXIT_SUCCESS; } -- 2.25.1