From c6127c39965aa7f13ee8b311e3f89f6f3c54a730 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Mon, 22 Jul 2019 10:24:50 +0200 Subject: [PATCH] random-seed: drop falling back to O_WRONLY if O_RDWR on /dev/urandom doesn't work There's no reason why writing should work if reading and writing doesn't. Let's simplify this hence. /dev/urandom is generally an r/w device, and everything else would be a serious system misconfiguration. --- src/random-seed/random-seed.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/random-seed/random-seed.c b/src/random-seed/random-seed.c index 1a1ce8caa4..dc148ebc86 100644 --- a/src/random-seed/random-seed.c +++ b/src/random-seed/random-seed.c @@ -67,13 +67,8 @@ static int run(int argc, char *argv[]) { write_seed_file = true; random_fd = open("/dev/urandom", O_RDWR|O_CLOEXEC|O_NOCTTY, 0600); - if (random_fd < 0) { - write_seed_file = false; - - random_fd = open("/dev/urandom", O_WRONLY|O_CLOEXEC|O_NOCTTY, 0600); - if (random_fd < 0) - return log_error_errno(errno, "Failed to open /dev/urandom: %m"); - } + if (random_fd < 0) + return log_error_errno(errno, "Failed to open /dev/urandom: %m"); read_seed_file = true; -- 2.25.1