From c0ef415862b43a30590877c9f4dd16fced88fd83 Mon Sep 17 00:00:00 2001
From: Luca Boccassi <luca.boccassi@microsoft.com>
Date: Thu, 25 Mar 2021 10:49:06 +0000
Subject: [PATCH] test-firewall-util: add more asserts on allocated variables

Makes things nicer for readers, and hopefully gives static analyzers
a hint on the origin/cleanup of the ctx pointer.
Coverity CID #1451399
---
 src/test/test-firewall-util.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/test/test-firewall-util.c b/src/test/test-firewall-util.c
index abc28d500d..dfde01a678 100644
--- a/src/test/test-firewall-util.c
+++ b/src/test/test-firewall-util.c
@@ -14,6 +14,8 @@ static void test_v6(FirewallContext *ctx) {
         uint8_t prefixlen;
         int r;
 
+        assert_se(ctx);
+
         log_info("/* %s(backend=%s) */", __func__, firewall_backend_to_string(ctx->backend));
 
         if (!socket_ipv6_is_supported())
@@ -46,6 +48,7 @@ static void test_v6(FirewallContext *ctx) {
 
 static union in_addr_union *parse_addr(const char *str, union in_addr_union *u) {
         assert(str);
+        assert(u);
         assert_se(in_addr_from_string(AF_INET, str, u) >= 0);
         return u;
 }
@@ -54,6 +57,8 @@ static bool test_v4(FirewallContext *ctx) {
         union in_addr_union u, v;
         int r;
 
+        assert_se(ctx);
+
         log_info("/* %s(backend=%s) */", __func__, firewall_backend_to_string(ctx->backend));
 
         assert_se(fw_add_masquerade(&ctx, true, AF_INET, NULL, 0) == -EINVAL);
@@ -92,6 +97,7 @@ int main(int argc, char *argv[]) {
                 return log_tests_skipped("not root");
 
         assert_se(fw_ctx_new(&ctx) >= 0);
+        assert_se(ctx);
 
         if (ctx->backend == FW_BACKEND_NONE)
                 return EXIT_TEST_SKIP;
-- 
2.25.1