From c03ef420fa7157b8d4881636fe72596a06e08bb6 Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Wed, 1 Jul 2020 16:05:32 +0900 Subject: [PATCH] network: tc: rename several settings which take size in bytes --- man/systemd.network.xml | 37 +++++---- src/network/networkd-network-gperf.gperf | 30 ++++--- src/network/tc/cake.c | 8 +- src/network/tc/drr.c | 2 +- src/network/tc/fifo.c | 2 +- src/network/tc/fq-codel.c | 7 +- src/network/tc/fq.c | 6 +- src/network/tc/qfq.c | 2 +- src/network/tc/tbf.c | 82 ++++++++++++++++--- src/network/tc/tbf.h | 1 + .../fuzz-network-parser/directives.network | 14 +++- test/test-network/conf/25-qdisc-cake.network | 2 +- .../conf/25-qdisc-clsact-and-htb.network | 14 ++-- test/test-network/conf/25-qdisc-drr.network | 2 +- test/test-network/conf/25-qdisc-qfq.network | 4 +- 15 files changed, 142 insertions(+), 71 deletions(-) diff --git a/man/systemd.network.xml b/man/systemd.network.xml index c48955da33..ed08826389 100644 --- a/man/systemd.network.xml +++ b/man/systemd.network.xml @@ -2724,20 +2724,20 @@ - LimitSize= + LimitBytes= Takes the number of bytes that can be queued waiting for tokens to become available. When the size is suffixed with K, M, or G, it is parsed as Kilobytes, Megabytes, or Gigabytes, - respectively, to the base of 1000. Defaults to unset. + respectively, to the base of 1024. Defaults to unset. - Burst= + BurstBytes= Specifies the size of the bucket. This is the maximum amount of bytes that tokens can be available for instantaneous transfer. When the size is suffixed with K, M, or G, it is - parsed as Kilobytes, Megabytes, or Gigabytes, respectively, to the base of 1000. Defaults to + parsed as Kilobytes, Megabytes, or Gigabytes, respectively, to the base of 1024. Defaults to unset. @@ -2756,7 +2756,7 @@ The Minimum Packet Unit (MPU) determines the minimal token usage (specified in bytes) for a packet. When suffixed with K, M, or G, the specified size is parsed as Kilobytes, - Megabytes, or Gigabytes, respectively, to the base of 1000. Defaults to zero. + Megabytes, or Gigabytes, respectively, to the base of 1024. Defaults to zero. @@ -2773,7 +2773,7 @@ MTUBytes= Specifies the size of the peakrate bucket. When suffixed with K, M, or G, the specified - size is parsed as Kilobytes, Megabytes, or Gigabytes, respectively, to the base of 1000. + size is parsed as Kilobytes, Megabytes, or Gigabytes, respectively, to the base of 1024. Defaults to unset. @@ -2846,7 +2846,7 @@ - LimitSize= + LimitBytes= Specifies the hard limit on the FIFO size in bytes. The size limit (a buffer size) to prevent it from overflowing in case it is unable to dequeue packets as quickly as it receives them. When this limit @@ -2915,7 +2915,7 @@ - Overhead= + OverheadBytes= Specifies that bytes to be addeded to the size of each packet. Bytes may be negative. Takes an integer ranges -64 to 256. Defaults to unset and kernel's default is used. @@ -3005,11 +3005,12 @@ - Quantum= + QuantumBytes= - Specifies the amount of bytes a flow is allowed to dequeue before the - scheduler moves to the next class. An unsigned integer ranges 1 to 4294967294. - Defaults to the MTU of the interface. + Specifies the amount of bytes a flow is allowed to dequeue before the scheduler moves + to the next class. When suffixed with K, M, or G, the specified size is parsed as Kilobytes, + Megabytes, or Gigabytes, respectively, to the base of 1024. Defaults to the MTU of the + interface. @@ -3120,7 +3121,7 @@ - MemoryLimit= + MemoryLimitBytes= Specifies the limit on the total number of bytes that can be queued in this FQ-CoDel instance. When suffixed with K, M, or G, the specified size is parsed as Kilobytes, Megabytes, or Gigabytes, @@ -3153,7 +3154,7 @@ - Quantum= + QuantumBytes= Specifies the number of bytes used as 'deficit' in the fair queuing algorithmtimespan. When suffixed with K, M, or G, the specified size is parsed as Kilobytes, Megabytes, or Gigabytes, @@ -3205,7 +3206,7 @@ - Quantum= + QuantumBytes= Specifies the credit per dequeue RR round, i.e. the amount of bytes a flow is allowed to dequeue at once. When suffixed with K, M, or G, the specified size is parsed as Kilobytes, @@ -3215,7 +3216,7 @@ - InitialQuantum= + InitialQuantumBytes= Specifies the initial sending rate credit, i.e. the amount of bytes a new flow is allowed to dequeue initially. When suffixed with K, M, or G, the specified size is parsed as @@ -3446,10 +3447,10 @@ - MaxPacketSize= + MaxPacketBytes= Specifies the maximum packet size in bytes for the class. When suffixed with K, M, or G, the specified - size is parsed as Kilobytes, Megabytes, or Gigabytes, respectively, to the base of 1000. When unset, + size is parsed as Kilobytes, Megabytes, or Gigabytes, respectively, to the base of 1024. When unset, the kernel default is used. diff --git a/src/network/networkd-network-gperf.gperf b/src/network/networkd-network-gperf.gperf index 43935e07b6..087358da11 100644 --- a/src/network/networkd-network-gperf.gperf +++ b/src/network/networkd-network-gperf.gperf @@ -304,11 +304,11 @@ QDisc.Parent, config_parse_qdisc_parent, QDisc.Handle, config_parse_qdisc_handle, _QDISC_KIND_INVALID, 0 BFIFO.Parent, config_parse_qdisc_parent, QDISC_KIND_BFIFO, 0 BFIFO.Handle, config_parse_qdisc_handle, QDISC_KIND_BFIFO, 0 -BFIFO.LimitSize, config_parse_bfifo_size, QDISC_KIND_BFIFO, 0 +BFIFO.LimitBytes, config_parse_bfifo_size, QDISC_KIND_BFIFO, 0 CAKE.Parent, config_parse_qdisc_parent, QDISC_KIND_CAKE, 0 CAKE.Handle, config_parse_qdisc_handle, QDISC_KIND_CAKE, 0 CAKE.Bandwidth, config_parse_cake_bandwidth, QDISC_KIND_CAKE, 0 -CAKE.Overhead, config_parse_cake_overhead, QDISC_KIND_CAKE, 0 +CAKE.OverheadBytes, config_parse_cake_overhead, QDISC_KIND_CAKE, 0 ControlledDelay.Parent, config_parse_qdisc_parent, QDISC_KIND_CODEL, 0 ControlledDelay.Handle, config_parse_qdisc_handle, QDISC_KIND_CODEL, 0 ControlledDelay.PacketLimit, config_parse_controlled_delay_u32, QDISC_KIND_CODEL, 0 @@ -320,7 +320,7 @@ DeficitRoundRobinScheduler.Parent, config_parse_qdisc_parent, DeficitRoundRobinScheduler.Handle, config_parse_qdisc_handle, QDISC_KIND_DRR, 0 DeficitRoundRobinSchedulerClass.Parent, config_parse_tclass_parent, TCLASS_KIND_DRR, 0 DeficitRoundRobinSchedulerClass.ClassId, config_parse_tclass_classid, TCLASS_KIND_DRR, 0 -DeficitRoundRobinSchedulerClass.Quantum, config_parse_drr_size, TCLASS_KIND_DRR, 0 +DeficitRoundRobinSchedulerClass.QuantumBytes, config_parse_drr_size, TCLASS_KIND_DRR, 0 EnhancedTransmissionSelection.Parent, config_parse_qdisc_parent, QDISC_KIND_ETS, 0 EnhancedTransmissionSelection.Handle, config_parse_qdisc_handle, QDISC_KIND_ETS, 0 EnhancedTransmissionSelection.Bands, config_parse_ets_u8, QDISC_KIND_ETS, 0 @@ -340,13 +340,13 @@ QuickFairQueueing.Handle, config_parse_qdisc_handle, QuickFairQueueingClass.Parent, config_parse_tclass_parent, TCLASS_KIND_QFQ, 0 QuickFairQueueingClass.ClassId, config_parse_tclass_classid, TCLASS_KIND_QFQ, 0 QuickFairQueueingClass.Weight, config_parse_quick_fair_queueing_weight, TCLASS_KIND_QFQ, 0 -QuickFairQueueingClass.MaxPacketSize, config_parse_quick_fair_queueing_max_packet, TCLASS_KIND_QFQ, 0 +QuickFairQueueingClass.MaxPacketBytes, config_parse_quick_fair_queueing_max_packet, TCLASS_KIND_QFQ, 0 FairQueueing.Parent, config_parse_qdisc_parent, QDISC_KIND_FQ, 0 FairQueueing.Handle, config_parse_qdisc_handle, QDISC_KIND_FQ, 0 FairQueueing.PacketLimit, config_parse_fair_queueing_u32, QDISC_KIND_FQ, 0 FairQueueing.FlowLimit, config_parse_fair_queueing_u32, QDISC_KIND_FQ, 0 -FairQueueing.Quantum, config_parse_fair_queueing_size, QDISC_KIND_FQ, 0 -FairQueueing.InitialQuantum, config_parse_fair_queueing_size, QDISC_KIND_FQ, 0 +FairQueueing.QuantumBytes, config_parse_fair_queueing_size, QDISC_KIND_FQ, 0 +FairQueueing.InitialQuantumBytes, config_parse_fair_queueing_size, QDISC_KIND_FQ, 0 FairQueueing.MaximumRate, config_parse_fair_queueing_max_rate, QDISC_KIND_FQ, 0 FairQueueing.Buckets, config_parse_fair_queueing_u32, QDISC_KIND_FQ, 0 FairQueueing.OrphanMask, config_parse_fair_queueing_u32, QDISC_KIND_FQ, 0 @@ -355,9 +355,9 @@ FairQueueing.CEThresholdSec, config_parse_fair_queueing_usec, FairQueueingControlledDelay.Parent, config_parse_qdisc_parent, QDISC_KIND_FQ_CODEL, 0 FairQueueingControlledDelay.Handle, config_parse_qdisc_handle, QDISC_KIND_FQ_CODEL, 0 FairQueueingControlledDelay.PacketLimit, config_parse_fair_queueing_controlled_delay_u32, QDISC_KIND_FQ_CODEL, 0 -FairQueueingControlledDelay.MemoryLimit, config_parse_fair_queueing_controlled_delay_size, QDISC_KIND_FQ_CODEL, 0 +FairQueueingControlledDelay.MemoryLimitBytes, config_parse_fair_queueing_controlled_delay_size, QDISC_KIND_FQ_CODEL, 0 FairQueueingControlledDelay.Flows, config_parse_fair_queueing_controlled_delay_u32, QDISC_KIND_FQ_CODEL, 0 -FairQueueingControlledDelay.Quantum, config_parse_fair_queueing_controlled_delay_size, QDISC_KIND_FQ_CODEL, 0 +FairQueueingControlledDelay.QuantumBytes, config_parse_fair_queueing_controlled_delay_size, QDISC_KIND_FQ_CODEL, 0 FairQueueingControlledDelay.TargetSec, config_parse_fair_queueing_controlled_delay_usec, QDISC_KIND_FQ_CODEL, 0 FairQueueingControlledDelay.IntervalSec, config_parse_fair_queueing_controlled_delay_usec, QDISC_KIND_FQ_CODEL, 0 FairQueueingControlledDelay.CEThresholdSec, config_parse_fair_queueing_controlled_delay_usec, QDISC_KIND_FQ_CODEL, 0 @@ -402,12 +402,12 @@ StochasticFairnessQueueing.Handle, config_parse_qdisc_handle, StochasticFairnessQueueing.PerturbPeriodSec, config_parse_stochastic_fairness_queueing_perturb_period, QDISC_KIND_SFQ, 0 TokenBucketFilter.Parent, config_parse_qdisc_parent, QDISC_KIND_TBF, 0 TokenBucketFilter.Handle, config_parse_qdisc_handle, QDISC_KIND_TBF, 0 -TokenBucketFilter.Rate, config_parse_token_bucket_filter_size, QDISC_KIND_TBF, 0 -TokenBucketFilter.Burst, config_parse_token_bucket_filter_size, QDISC_KIND_TBF, 0 -TokenBucketFilter.LimitSize, config_parse_token_bucket_filter_size, QDISC_KIND_TBF, 0 +TokenBucketFilter.Rate, config_parse_token_bucket_filter_rate, QDISC_KIND_TBF, 0 +TokenBucketFilter.BurstBytes, config_parse_token_bucket_filter_size, QDISC_KIND_TBF, 0 +TokenBucketFilter.LimitBytes, config_parse_token_bucket_filter_size, QDISC_KIND_TBF, 0 TokenBucketFilter.MTUBytes, config_parse_token_bucket_filter_size, QDISC_KIND_TBF, 0 TokenBucketFilter.MPUBytes, config_parse_token_bucket_filter_size, QDISC_KIND_TBF, 0 -TokenBucketFilter.PeakRate, config_parse_token_bucket_filter_size, QDISC_KIND_TBF, 0 +TokenBucketFilter.PeakRate, config_parse_token_bucket_filter_rate, QDISC_KIND_TBF, 0 TokenBucketFilter.LatencySec, config_parse_token_bucket_filter_latency, QDISC_KIND_TBF, 0 TrivialLinkEqualizer.Parent, config_parse_qdisc_parent, QDISC_KIND_TEQL, 0 TrivialLinkEqualizer.Handle, config_parse_qdisc_handle, QDISC_KIND_TEQL, 0 @@ -446,3 +446,9 @@ TrafficControlQueueingDiscipline.NetworkEmulatorDelayJitterSec, config_parse_net TrafficControlQueueingDiscipline.NetworkEmulatorLossRate, config_parse_network_emulator_rate, 0, 0 TrafficControlQueueingDiscipline.NetworkEmulatorDuplicateRate, config_parse_network_emulator_rate, 0, 0 TrafficControlQueueingDiscipline.NetworkEmulatorPacketLimit, config_parse_network_emulator_packet_limit, 0, 0 +FairQueueing.Quantum, config_parse_fair_queueing_size, QDISC_KIND_FQ, 0 +FairQueueing.InitialQuantum, config_parse_fair_queueing_size, QDISC_KIND_FQ, 0 +FairQueueingControlledDelay.MemoryLimit, config_parse_fair_queueing_controlled_delay_size, QDISC_KIND_FQ_CODEL, 0 +FairQueueingControlledDelay.Quantum, config_parse_fair_queueing_controlled_delay_size, QDISC_KIND_FQ_CODEL, 0 +TokenBucketFilter.Burst, config_parse_token_bucket_filter_size, QDISC_KIND_TBF, 0 +TokenBucketFilter.LimitSize, config_parse_token_bucket_filter_size, QDISC_KIND_TBF, 0 diff --git a/src/network/tc/cake.c b/src/network/tc/cake.c index b499661bd3..286c7e172f 100644 --- a/src/network/tc/cake.c +++ b/src/network/tc/cake.c @@ -136,14 +136,14 @@ int config_parse_cake_overhead( r = safe_atoi32(rvalue, &v); if (r < 0) { log_syntax(unit, LOG_ERR, filename, line, r, - "Failed to parse 'Overhead=', ignoring assignment: %s", - rvalue); + "Failed to parse '%s=', ignoring assignment: %s", + lvalue, rvalue); return 0; } if (v < -64 || v > 256) { log_syntax(unit, LOG_ERR, filename, line, 0, - "Invalid 'Overhead=', ignoring assignment: %s", - rvalue); + "Invalid '%s=', ignoring assignment: %s", + lvalue, rvalue); return 0; } diff --git a/src/network/tc/drr.c b/src/network/tc/drr.c index ac64eb8b03..a671f32d99 100644 --- a/src/network/tc/drr.c +++ b/src/network/tc/drr.c @@ -79,7 +79,7 @@ int config_parse_drr_size( return 0; } - r = parse_size(rvalue, 1000, &u); + r = parse_size(rvalue, 1024, &u); if (r < 0) { log_syntax(unit, LOG_ERR, filename, line, r, "Failed to parse '%s=', ignoring assignment: %s", diff --git a/src/network/tc/fifo.c b/src/network/tc/fifo.c index 8ef6e513bb..1a608dd7c0 100644 --- a/src/network/tc/fifo.c +++ b/src/network/tc/fifo.c @@ -140,7 +140,7 @@ int config_parse_bfifo_size( return 0; } - r = parse_size(rvalue, 1000, &u); + r = parse_size(rvalue, 1024, &u); if (r < 0) { log_syntax(unit, LOG_ERR, filename, line, r, "Failed to parse '%s=', ignoring assignment: %s", diff --git a/src/network/tc/fq-codel.c b/src/network/tc/fq-codel.c index 6c7932c70f..721112d317 100644 --- a/src/network/tc/fq-codel.c +++ b/src/network/tc/fq-codel.c @@ -9,6 +9,7 @@ #include "parse-util.h" #include "qdisc.h" #include "string-util.h" +#include "strv.h" static int fair_queueing_controlled_delay_init(QDisc *qdisc) { FairQueueingControlledDelay *fqcd; @@ -301,15 +302,15 @@ int config_parse_fair_queueing_controlled_delay_size( fqcd = FQ_CODEL(qdisc); - if (streq(lvalue, "MemoryLimit")) + if (STR_IN_SET(lvalue, "MemoryLimitBytes", "MemoryLimit")) p = &fqcd->memory_limit; - else if (streq(lvalue, "Quantum")) + else if (STR_IN_SET(lvalue, "QuantumBytes", "Quantum")) p = &fqcd->quantum; else assert_not_reached("Invalid lvalue."); if (isempty(rvalue)) { - if (streq(lvalue, "MemoryLimit")) + if (STR_IN_SET(lvalue, "MemoryLimitBytes", "MemoryLimit")) *p = UINT32_MAX; else *p = 0; diff --git a/src/network/tc/fq.c b/src/network/tc/fq.c index c7eeec2307..f717dc790c 100644 --- a/src/network/tc/fq.c +++ b/src/network/tc/fq.c @@ -9,7 +9,7 @@ #include "netlink-util.h" #include "parse-util.h" #include "string-util.h" -#include "util.h" +#include "strv.h" static int fair_queueing_init(QDisc *qdisc) { FairQueueing *fq; @@ -198,9 +198,9 @@ int config_parse_fair_queueing_size( fq = FQ(qdisc); - if (streq(lvalue, "Quantum")) + if (STR_IN_SET(lvalue, "QuantumBytes", "Quantum")) p = &fq->quantum; - else if (streq(lvalue, "InitialQuantum")) + else if (STR_IN_SET(lvalue, "InitialQuantumBytes", "InitialQuantum")) p = &fq->initial_quantum; else assert_not_reached("Invalid lvalue"); diff --git a/src/network/tc/qfq.c b/src/network/tc/qfq.c index 71d5b15e81..52c17625bf 100644 --- a/src/network/tc/qfq.c +++ b/src/network/tc/qfq.c @@ -142,7 +142,7 @@ int config_parse_quick_fair_queueing_max_packet( return 0; } - r = parse_size(rvalue, 1000, &v); + r = parse_size(rvalue, 1024, &v); if (r < 0) { log_syntax(unit, LOG_ERR, filename, line, r, "Failed to parse '%s=', ignoring assignment: %s", diff --git a/src/network/tc/tbf.c b/src/network/tc/tbf.c index 0682ab4cc6..2c730352d2 100644 --- a/src/network/tc/tbf.c +++ b/src/network/tc/tbf.c @@ -12,8 +12,8 @@ #include "parse-util.h" #include "qdisc.h" #include "string-util.h" +#include "strv.h" #include "tc-util.h" -#include "util.h" static int token_bucket_filter_fill_message(Link *link, QDisc *qdisc, sd_netlink_message *req) { uint32_t rtab[256], ptab[256]; @@ -143,24 +143,22 @@ int config_parse_token_bucket_filter_size( tbf = TBF(qdisc); if (isempty(rvalue)) { - if (streq(lvalue, "Rate")) - tbf->rate = 0; - else if (streq(lvalue, "Burst")) + if (STR_IN_SET(lvalue, "BurstBytes", "Burst")) tbf->burst = 0; - else if (streq(lvalue, "LimitSize")) + else if (STR_IN_SET(lvalue, "LimitBytes", "LimitSize")) tbf->limit = 0; else if (streq(lvalue, "MTUBytes")) tbf->mtu = 0; else if (streq(lvalue, "MPUBytes")) tbf->mpu = 0; - else if (streq(lvalue, "PeakRate")) - tbf->peak_rate = 0; + else + assert_not_reached("unknown lvalue"); qdisc = NULL; return 0; } - r = parse_size(rvalue, 1000, &k); + r = parse_size(rvalue, 1024, &k); if (r < 0) { log_syntax(unit, LOG_ERR, filename, line, r, "Failed to parse '%s=', ignoring assignment: %s", @@ -168,18 +166,76 @@ int config_parse_token_bucket_filter_size( return 0; } - if (streq(lvalue, "Rate")) - tbf->rate = k / 8; - else if (streq(lvalue, "Burst")) + if (STR_IN_SET(lvalue, "BurstBytes", "Burst")) tbf->burst = k; - else if (streq(lvalue, "LimitSize")) + else if (STR_IN_SET(lvalue, "LimitBytes", "LimitSize")) tbf->limit = k; else if (streq(lvalue, "MPUBytes")) tbf->mpu = k; else if (streq(lvalue, "MTUBytes")) tbf->mtu = k; + else + assert_not_reached("unknown lvalue"); + + qdisc = NULL; + + return 0; +} + +int config_parse_token_bucket_filter_rate( + const char *unit, + const char *filename, + unsigned line, + const char *section, + unsigned section_line, + const char *lvalue, + int ltype, + const char *rvalue, + void *data, + void *userdata) { + + _cleanup_(qdisc_free_or_set_invalidp) QDisc *qdisc = NULL; + Network *network = data; + TokenBucketFilter *tbf; + uint64_t k, *p; + int r; + + assert(filename); + assert(lvalue); + assert(rvalue); + assert(data); + + r = qdisc_new_static(QDISC_KIND_TBF, network, filename, section_line, &qdisc); + if (r == -ENOMEM) + return log_oom(); + if (r < 0) + return log_syntax(unit, LOG_ERR, filename, line, r, + "More than one kind of queueing discipline, ignoring assignment: %m"); + + tbf = TBF(qdisc); + if (streq(lvalue, "Rate")) + p = &tbf->rate; else if (streq(lvalue, "PeakRate")) - tbf->peak_rate = k / 8; + p = &tbf->peak_rate; + else + assert_not_reached("unknown lvalue"); + + if (isempty(rvalue)) { + *p = 0; + + qdisc = NULL; + return 0; + } + + r = parse_size(rvalue, 1000, &k); + if (r < 0) { + log_syntax(unit, LOG_ERR, filename, line, r, + "Failed to parse '%s=', ignoring assignment: %s", + lvalue, rvalue); + return 0; + } + + *p = k / 8; qdisc = NULL; diff --git a/src/network/tc/tbf.h b/src/network/tc/tbf.h index b66aef206c..a785be25e0 100644 --- a/src/network/tc/tbf.h +++ b/src/network/tc/tbf.h @@ -23,3 +23,4 @@ extern const QDiscVTable tbf_vtable; CONFIG_PARSER_PROTOTYPE(config_parse_token_bucket_filter_latency); CONFIG_PARSER_PROTOTYPE(config_parse_token_bucket_filter_size); +CONFIG_PARSER_PROTOTYPE(config_parse_token_bucket_filter_rate); diff --git a/test/fuzz/fuzz-network-parser/directives.network b/test/fuzz/fuzz-network-parser/directives.network index da4a9647ab..1754a1cd82 100644 --- a/test/fuzz/fuzz-network-parser/directives.network +++ b/test/fuzz/fuzz-network-parser/directives.network @@ -332,7 +332,9 @@ PacketLimit= Parent= Handle= Rate= +BurstBytes= Burst= +LimitBytes= LimitSize= MTUBytes= MPUBytes= @@ -346,8 +348,10 @@ PerturbPeriodSec= Parent= Handle= PacketLimit= +MemoryLimitBytes= MemoryLimit= Flows= +QuantumBytes= Quantum= TargetSec= IntervalSec= @@ -358,7 +362,9 @@ Parent= Handle= PacketLimit= FlowLimit= +QuantumBytes= Quantum= +InitialQuantumBytes= InitialQuantum= MaximumRate= Buckets= @@ -377,7 +383,7 @@ ECN= Parent= Handle= Bandwidth= -Overhead= +OverheadBytes= [TrafficControlQueueingDiscipline] Parent= NetworkEmulatorDelaySec= @@ -408,7 +414,7 @@ CeilBufferBytes= [BFIFO] Parent= Handle= -LimitSize= +LimitBytes= [PFIFO] Parent= Handle= @@ -441,14 +447,14 @@ Handle= Parent= ClassId= Weight= -MaxPacketSize= +MaxPacketBytes= [DeficitRoundRobinScheduler] Parent= Handle= [DeficitRoundRobinSchedulerClass] Parent= ClassId= -Quantum= +QuantumBytes= [EnhancedTransmissionSelection] Parent= Handle= diff --git a/test/test-network/conf/25-qdisc-cake.network b/test/test-network/conf/25-qdisc-cake.network index b713245dbc..a1b00f258f 100644 --- a/test/test-network/conf/25-qdisc-cake.network +++ b/test/test-network/conf/25-qdisc-cake.network @@ -8,5 +8,5 @@ Address=10.1.2.3/16 [CAKE] Parent=root Handle=3a -Overhead=128 +OverheadBytes=128 Bandwidth=500M diff --git a/test/test-network/conf/25-qdisc-clsact-and-htb.network b/test/test-network/conf/25-qdisc-clsact-and-htb.network index f18e2f76d9..fd2520db50 100644 --- a/test/test-network/conf/25-qdisc-clsact-and-htb.network +++ b/test/test-network/conf/25-qdisc-clsact-and-htb.network @@ -58,8 +58,8 @@ Parent=2:32 Handle=0032 PacketLimit=1000 FlowLimit=200 -Quantum=1500 -InitialQuantum=13000 +QuantumBytes=1500 +InitialQuantumBytes=13000 MaximumRate=1M Buckets=512 OrphanMask=511 @@ -93,11 +93,11 @@ CeilRate=0.5M Parent=2:34 Handle=0034 PacketLimit=20480 -MemoryLimit=64M +MemoryLimitBytes=64M Flows=2048 TargetSec=10ms IntervalSec=200ms -Quantum=1400 +QuantumBytes=1400 ECN=yes CEThresholdSec=100ms @@ -112,10 +112,10 @@ CeilRate=0.5M Parent=2:35 Handle=0035 Rate=1G -Burst=5K +BurstBytes=5000 LatencySec=70msec PeakRate=100G -MTUBytes=1M +MTUBytes=1000000 [HierarchyTokenBucketClass] Parent=root @@ -177,7 +177,7 @@ CeilRate=0.5M [BFIFO] Parent=2:3a Handle=003a -LimitSize=1M +LimitBytes=1000000 [HierarchyTokenBucketClass] Parent=root diff --git a/test/test-network/conf/25-qdisc-drr.network b/test/test-network/conf/25-qdisc-drr.network index 4632740061..dff8b0978d 100644 --- a/test/test-network/conf/25-qdisc-drr.network +++ b/test/test-network/conf/25-qdisc-drr.network @@ -12,4 +12,4 @@ Handle=0002 [DeficitRoundRobinSchedulerClass] Parent=root ClassId=0002:0030 -Quantum=2000 +QuantumBytes=2000 diff --git a/test/test-network/conf/25-qdisc-qfq.network b/test/test-network/conf/25-qdisc-qfq.network index c94fc9e4cb..3a24415c12 100644 --- a/test/test-network/conf/25-qdisc-qfq.network +++ b/test/test-network/conf/25-qdisc-qfq.network @@ -13,10 +13,10 @@ Handle=0002 Parent=root ClassId=0002:0030 Weight=2 -MaxPacketSize=16000 +MaxPacketBytes=16000 [QuickFairQueueingClass] Parent=root ClassId=0002:0031 Weight=10 -MaxPacketSize=8000 +MaxPacketBytes=8000 -- 2.25.1