From bd2cc9557287fa4e91c8f6736a114eb5950415a6 Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Fri, 31 Dec 2021 06:59:42 +0900 Subject: [PATCH] nss-systemd: fix alignment of gr_mem Follow-up for 1e65eb8f9b7d567462030b2e625998d77677e636. Fixes #21935. (cherry picked from commit 420a35c1fadfb4d67be6316436233d98b5688de5) (cherry picked from commit 9c8bc0451ab2393f3b9b689e46e1b05e9f6dad35) (cherry picked from commit 649e83bb995eb067cce3e70f50e5d3ab54c9d47d) --- src/nss-systemd/nss-systemd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/nss-systemd/nss-systemd.c b/src/nss-systemd/nss-systemd.c index 8ccdeb258e..54de12e92e 100644 --- a/src/nss-systemd/nss-systemd.c +++ b/src/nss-systemd/nss-systemd.c @@ -159,7 +159,7 @@ static enum nss_status copy_synthesized_group( required += strlen(src->gr_passwd) + 1; required += sizeof(char*); /* ...but that NULL still needs to be stored into the buffer! */ - if (buflen < required) { + if (buflen < ALIGN(required)) { *errnop = ERANGE; return NSS_STATUS_TRYAGAIN; } @@ -171,7 +171,7 @@ static enum nss_status copy_synthesized_group( /* String fields point into the user-provided buffer */ dest->gr_name = buffer; dest->gr_passwd = stpcpy(dest->gr_name, src->gr_name) + 1; - dest->gr_mem = (char **) stpcpy(dest->gr_passwd, src->gr_passwd) + 1; + dest->gr_mem = ALIGN_PTR(stpcpy(dest->gr_passwd, src->gr_passwd) + 1); *dest->gr_mem = NULL; return NSS_STATUS_SUCCESS; -- 2.25.1