From 8facac5fdd227ff59827c8c7f65bd01fd402b465 Mon Sep 17 00:00:00 2001 From: "Dmitry V. Levin" Date: Tue, 17 Jan 2023 08:00:00 +0000 Subject: [PATCH] coredump: use fstatvfs to check the available space Given that we already have the file descriptor opened for writing, it would make sense to call fstatvfs with that file descriptor rather than statvfs with the directory path that was used to open that descriptor. --- src/coredump/coredump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coredump/coredump.c b/src/coredump/coredump.c index 192dc4c654..013ebb4c28 100644 --- a/src/coredump/coredump.c +++ b/src/coredump/coredump.c @@ -597,7 +597,7 @@ static int save_external_coredump( /* tmpfs might get full quickly, so check the available space too. * But don't worry about errors here, failing to access the storage * location will be better logged when writing to it. */ - if (statvfs("/var/lib/systemd/coredump/", &sv) >= 0) + if (fstatvfs(fd, &sv) >= 0) max_size = MIN((uint64_t)sv.f_frsize * (uint64_t)sv.f_bfree, max_size); log_debug("Limiting core file size to %" PRIu64 " bytes due to cgroup memory limits.", max_size); -- 2.25.1