From 79d2ecaf63ac4b3b9e35f29b070412152633ca24 Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Wed, 19 Jul 2023 03:16:38 +0900 Subject: [PATCH] udev: drop mostly unused Manager.pid It is only used by the assertion in event_queue_insert(). We have similar check e.g. in sd-bus or sd-event, but udevd.c is not a library code, hence such check is not necessary. --- src/udev/udevd.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/udev/udevd.c b/src/udev/udevd.c index c93dc6905e..214fc17861 100644 --- a/src/udev/udevd.c +++ b/src/udev/udevd.c @@ -97,7 +97,6 @@ typedef struct Manager { Hashmap *workers; LIST_HEAD(Event, events); char *cgroup; - pid_t pid; /* the process that originally allocated the manager object */ int log_level; UdevRules *rules; @@ -776,9 +775,6 @@ static int event_queue_insert(Manager *manager, sd_device *dev) { assert(manager); assert(dev); - /* only one process can add events to the queue */ - assert(manager->pid == getpid_cached()); - /* We only accepts devices received by device monitor. */ r = sd_device_get_seqnum(dev, &seqnum); if (r < 0) @@ -1532,8 +1528,6 @@ static int manager_new(Manager **ret, int fd_ctrl, int fd_uevent) { static int main_loop(Manager *manager) { int fd_worker, r; - manager->pid = getpid_cached(); - /* unnamed socket from workers to the main daemon */ r = socketpair(AF_UNIX, SOCK_DGRAM|SOCK_CLOEXEC, 0, manager->worker_watch); if (r < 0) -- 2.25.1