From 7036dd8b27b1ccca1f76723814145f17283d2656 Mon Sep 17 00:00:00 2001 From: Mike Yuan Date: Fri, 9 Aug 2024 17:33:39 +0200 Subject: [PATCH] terminal-util: do not query kernel cmdline for pty size This is pointless and noisy even for debug level. --- src/basic/terminal-util.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/basic/terminal-util.c b/src/basic/terminal-util.c index 1f5204cca5..6088320186 100644 --- a/src/basic/terminal-util.c +++ b/src/basic/terminal-util.c @@ -980,8 +980,11 @@ int proc_cmdline_tty_size(const char *tty, unsigned *ret_rows, unsigned *ret_col return 0; tty = skip_dev_prefix(tty); + if (path_startswith(tty, "pts/")) + return -EMEDIUMTYPE; if (!in_charset(tty, ALPHANUMERICAL)) - return log_debug_errno(SYNTHETIC_ERRNO(EINVAL), "%s contains non-alphanumeric characters", tty); + return log_debug_errno(SYNTHETIC_ERRNO(EINVAL), + "TTY name '%s' contains non-alphanumeric characters, not searching kernel cmdline for size.", tty); rowskey = strjoin("systemd.tty.rows.", tty); if (!rowskey) -- 2.25.1