From 6e7323137ae52da36896ecd238a8de87961cc3a3 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Tue, 2 Nov 2021 10:45:20 +0100 Subject: [PATCH] resolved: do not use BN_dup() unnecessarilly Suggested in https://github.com/systemd/systemd/pull/21170#discussion_r738696794 --- src/resolve/resolved-dns-dnssec.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/resolve/resolved-dns-dnssec.c b/src/resolve/resolved-dns-dnssec.c index 3b645ad3f6..b1fe9d1314 100644 --- a/src/resolve/resolved-dns-dnssec.c +++ b/src/resolve/resolved-dns-dnssec.c @@ -110,8 +110,9 @@ static int dnssec_rsa_verify_raw( if (!rpubkey) return -ENOMEM; - if (RSA_set0_key(rpubkey, BN_dup(m), BN_dup(e), NULL) <= 0) + if (RSA_set0_key(rpubkey, m, e, NULL) <= 0) return -EIO; + e = m = NULL; assert((size_t) RSA_size(rpubkey) == signature_size); @@ -344,8 +345,9 @@ static int dnssec_ecdsa_verify_raw( if (!sig) return -ENOMEM; - if (ECDSA_SIG_set0(sig, BN_dup(r), BN_dup(s)) <= 0) + if (ECDSA_SIG_set0(sig, r, s) <= 0) return -EIO; + r = s = NULL; k = ECDSA_do_verify(data, data_size, sig, eckey); if (k < 0) -- 2.25.1