From 65df0ce39a1990e64eb74087270ac823ba0bd665 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Tue, 24 May 2022 10:20:23 +0200 Subject: [PATCH] Minor wording fixes MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Some NEWS entries are tweaked a bit to address complaints about readability from users. "udev" is pronounced as /ˈjuːdɛv/, like in "user", hence "a" not "an". --- NEWS | 35 +++++++++++++++---------------- src/login/logind-session-device.c | 2 +- 2 files changed, 18 insertions(+), 19 deletions(-) diff --git a/NEWS b/NEWS index 8ca049e548..9ff9292311 100644 --- a/NEWS +++ b/NEWS @@ -29,19 +29,19 @@ CHANGES WITH 251: and backward compatibility broken instead on the assumption that nobody can be affected given the current state of this interface. - * All kernels supported by systemd mix RDRAND (or similar) into the - entropy pool at early boot. This means that on those systems, even if - /dev/urandom is not yet initialized, it still returns bytes that - are at least as high quality as RDRAND. For that reason, we no longer - have reason to invoke RDRAND from systemd itself, which has - historically been a source of bugs. Furthermore, kernels ≥5.6 provide - the getrandom(GRND_INSECURE) interface for returning random bytes - before the entropy pool is initialized without warning into kmsg, - which is what we attempt to use if available. systemd's direct usage - of RDRAND has been removed. x86 systems ≥Broadwell that are running - an older kernel may experience kmsg warnings that were not seen with - 250. For newer kernels, non-x86 systems, or older x86 systems, there - should be no visible changes. + * All kernels supported by systemd mix bytes returned by RDRAND (or + similar) into the entropy pool at early boot. This means that on + those systems, even if /dev/urandom is not yet initialized, it still + returns bytes that are of at least RDRAND quality. For that reason, + we no longer have reason to invoke RDRAND from systemd itself, which + has historically been a source of bugs. Furthermore, kernels ≥5.6 + provide the getrandom(GRND_INSECURE) interface for returning random + bytes before the entropy pool is initialized without warning into + kmsg, which is what we attempt to use if available. systemd's direct + usage of RDRAND has been removed. x86 systems ≥Broadwell that are + running an older kernel may experience kmsg warnings that were not + seen with 250. For newer kernels, non-x86 systems, or older x86 + systems, there should be no visible changes. * sd-boot will now measure the kernel command line into TPM PCR 12 rather than PCR 8. This improves usefulness of the measurements on @@ -59,11 +59,10 @@ CHANGES WITH 251: * busctl capture now writes output in the newer pcapng format instead of pcap. - * A udev rule that imported hwdb matches for USB devices with - lowercase hexadecimal vendor/product ID digits was added in systemd - 250. This has been reverted, since uppercase hexadecimal digits are - supposed to be used, and we already had a rule for that with the - appropriate match. + * A udev rule that imported hwdb matches for USB devices with lowercase + hexadecimal vendor/product ID digits was added in systemd 250. This + has been reverted, since uppercase hexadecimal digits are supposed to + be used, and we already had a rule with the appropriate match. Users might need to adjust their local hwdb entries. diff --git a/src/login/logind-session-device.c b/src/login/logind-session-device.c index 19e00b996e..003dbc0a95 100644 --- a/src/login/logind-session-device.c +++ b/src/login/logind-session-device.c @@ -120,7 +120,7 @@ static int session_device_open(SessionDevice *sd, bool active) { assert(sd->type != DEVICE_TYPE_UNKNOWN); assert(sd->node); - /* open device and try to get an udev_device from it */ + /* open device and try to get a udev_device from it */ fd = open(sd->node, O_RDWR|O_CLOEXEC|O_NOCTTY|O_NONBLOCK); if (fd < 0) return -errno; -- 2.25.1