From 2bb1d3c1083f8562b00e297dae4268a38de3d99c Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Fri, 2 Feb 2024 11:20:25 +0900 Subject: [PATCH] test-network: add test case for issue #31165 --- src/network/networkd-setlink.c | 2 ++ test/test-network/systemd-networkd-tests.py | 6 ++++++ 2 files changed, 8 insertions(+) diff --git a/src/network/networkd-setlink.c b/src/network/networkd-setlink.c index 4c4e0d1cd9..eb65429a78 100644 --- a/src/network/networkd-setlink.c +++ b/src/network/networkd-setlink.c @@ -1046,6 +1046,8 @@ static int link_up_or_down(Link *link, bool up, Request *req) { assert(link->manager->rtnl); assert(req); + /* The log message is checked in the test. Please also update test_bond_active_slave() in + * test/test-network/systemd-networkd-tests.py. when the log message below is modified. */ log_link_debug(link, "Bringing link %s", up_or_down(up)); r = sd_rtnl_message_new_link(link->manager->rtnl, &m, RTM_SETLINK, link->ifindex); diff --git a/test/test-network/systemd-networkd-tests.py b/test/test-network/systemd-networkd-tests.py index 1700732e34..11c3839bdb 100755 --- a/test/test-network/systemd-networkd-tests.py +++ b/test/test-network/systemd-networkd-tests.py @@ -4597,6 +4597,12 @@ class NetworkdBondTests(unittest.TestCase, Utilities): print(output) self.assertIn('active_slave dummy98', output) + # test case for issue #31165. + since = datetime.datetime.now() + networkctl_reconfigure('dummy98') + self.wait_online(['dummy98:enslaved', 'bond199:degraded']) + self.assertNotIn('dummy98: Bringing link down', read_networkd_log(since=since)) + def test_bond_primary_slave(self): copy_network_unit('23-primary-slave.network', '23-bond199.network', '25-bond-active-backup-slave.netdev', '12-dummy.netdev') start_networkd() -- 2.25.1