From 108bb8d065eaae907d33d41b6a502f38e2f127ba Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Mon, 15 Aug 2022 11:41:07 +0200 Subject: [PATCH] creds-tool: don't declare variable in switch body The lifetime of variables decalred in the main switch/case body is just weird. Let's not rely on it, but just open a new {} block, like everywhere else in similar cases. --- src/creds/creds.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/creds/creds.c b/src/creds/creds.c index 59bb072115..e9c7c96fc5 100644 --- a/src/creds/creds.c +++ b/src/creds/creds.c @@ -832,13 +832,14 @@ static int parse_argv(int argc, char *argv[]) { arg_tpm2_device = streq(optarg, "auto") ? NULL : optarg; break; - case ARG_TPM2_PCRS: + case ARG_TPM2_PCRS: { + uint32_t mask; + if (isempty(optarg)) { arg_tpm2_pcr_mask = 0; break; } - uint32_t mask; r = tpm2_parse_pcrs(optarg, &mask); if (r < 0) return r; @@ -849,6 +850,7 @@ static int parse_argv(int argc, char *argv[]) { arg_tpm2_pcr_mask |= mask; break; + } case ARG_NAME: if (isempty(optarg)) { -- 2.25.1