From 0ad536c16a940b4557322f3f811db73c4b374898 Mon Sep 17 00:00:00 2001
From: Luca Boccassi <luca.boccassi@microsoft.com>
Date: Wed, 20 Oct 2021 22:10:56 +0100
Subject: [PATCH] CI: disable code coverage in GH Action

It is now ran on the nightly CentOS build, so that it can cover
integration tests too, and not just unit tests. It's nightly as
it considerably increases the integration test runtime, so it's
not appropriate for all PRs.
---
 .github/workflows/unit_tests.sh  | 9 ---------
 .github/workflows/unit_tests.yml | 6 ------
 2 files changed, 15 deletions(-)

diff --git a/.github/workflows/unit_tests.sh b/.github/workflows/unit_tests.sh
index e1f7a4be1e..7e7e3016e8 100755
--- a/.github/workflows/unit_tests.sh
+++ b/.github/workflows/unit_tests.sh
@@ -9,7 +9,6 @@ ADDITIONAL_DEPS=(
     expect
     fdisk
     jekyll
-    lcov
     libfdisk-dev
     libfido2-dev
     libp11-kit-dev
@@ -48,17 +47,9 @@ for phase in "${PHASES[@]}"; do
                 # The docs build is slow and is not affected by compiler/flags, so do it just once
                 MESON_ARGS+=(-Dman=true)
             fi
-            if [[ "$phase" = "RUN_GCC" ]]; then
-                MESON_ARGS+=(-Db_coverage=true)
-                # See FIXME below
-                (set +x; while :; do echo -ne "\n[WATCHDOG] $(date)\n"; sleep 30; done) &
-            fi
             meson --werror -Dtests=unsafe -Dslow-tests=true -Dfuzz-tests=true "${MESON_ARGS[@]}" build
             ninja -C build -v
             meson test -C build --print-errorlogs
-            if [[ "$phase" = "RUN_GCC" ]]; then
-                ninja -C build coverage
-            fi
             ;;
         RUN_ASAN_UBSAN|RUN_GCC_ASAN_UBSAN|RUN_CLANG_ASAN_UBSAN)
             MESON_ARGS=(--optimization=1)
diff --git a/.github/workflows/unit_tests.yml b/.github/workflows/unit_tests.yml
index e697e6485d..0b8c1782ea 100644
--- a/.github/workflows/unit_tests.yml
+++ b/.github/workflows/unit_tests.yml
@@ -29,9 +29,3 @@ jobs:
       - name: Build & test (${{ matrix.run_phase }})
         run: sudo -E .github/workflows/unit_tests.sh RUN_${{ matrix.run_phase }}
         if: github.event_name == 'pull_request' || matrix.run_phase == 'GCC'
-      - name: Coveralls
-        if: matrix.run_phase == 'GCC' && github.repository == 'systemd/systemd'
-        uses: coverallsapp/github-action@master
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          path-to-lcov: ./build/meson-logs/coverage.info
-- 
2.25.1