core/namespace: allow using ProtectSubset=pid and ProtectHostname=true together
authorChristian Brauner <brauner@kernel.org>
Fri, 21 Jan 2022 12:08:19 +0000 (13:08 +0100)
committerLuca Boccassi <bluca@debian.org>
Mon, 14 Feb 2022 21:56:48 +0000 (21:56 +0000)
commita727941affa7821592d503c8a5033c92d615f64c
treeeddb938d5fd3ae3de3ccb6d65fb2d069b0ca339d
parenta060a16c706f2dd2bf48b325082b9181500e253d
core/namespace: allow using ProtectSubset=pid and ProtectHostname=true together

If a service requests both ProtectSubset=pid and ProtectHostname=true
then it will currently fail to start. The ProcSubset=pid option
instructs systemd to mount procfs for the service with subset=pid which
hides all entries other than /proc/<pid>. Consequently trying to
interact with the two files /proc/sys/kernel/{hostname,domainname}
covered by ProtectHostname=true will fail.

Fix this by only performing this check when ProtectSubset=pid is not
requested. Essentially ProtectSubset=pid implies/provides
ProtectHostname=true.

(cherry picked from commit 1361f015773e3b4d74e382edf1565f3315a3396b)
src/core/namespace.c