Yu Watanabe [Thu, 6 Feb 2020 10:13:11 +0000 (19:13 +0900)]
sysctl: fix segfault
Fixes #14801.
Zbigniew Jędrzejewski-Szmek [Thu, 6 Feb 2020 09:46:21 +0000 (10:46 +0100)]
Merge pull request #14156 from fbuihuu/deal-with-aliases-when-disabling
Consider aliases in /usr when disabling units
Christian Göttsche [Tue, 4 Feb 2020 17:07:07 +0000 (18:07 +0100)]
core: do not prepare a SELinux context for dummy files for devicenode bind-mounting
Let systemd create the dummy file where a device node will be mounted on with the default label for the parent directory (e.g. /tmp/namespace-dev-yTMwAe/dev/).
Fixes: #13762
Will Fleming [Thu, 6 Feb 2020 01:48:44 +0000 (20:48 -0500)]
man: fix typo in systemd.unit man page
This commit fixes a minor typo: "setttings" -> "settings".
Mike Gilbert [Wed, 5 Feb 2020 16:04:50 +0000 (11:04 -0500)]
network: remove unnecessary link->ifname from debug log statements
Since
98b0299479a68ffd414888368907fc776a46b82a, we log the interface
name automatically via log_link_debug().
Fixes: https://github.com/systemd/systemd/issues/14782
Michal Sekletár [Tue, 4 Feb 2020 13:23:14 +0000 (14:23 +0100)]
sd-journal: close journal files that were deleted by journald before we've setup inotify watch
Fixes #14695
Zbigniew Jędrzejewski-Szmek [Wed, 5 Feb 2020 12:11:01 +0000 (13:11 +0100)]
units: drop OnFailure= from .target units
See
c80a9a33d04fb4381327a69ce929c94a9f1d0e6c, target units can't fail.
I guess we need to figure out some replacement functionality, but at least
let's avoid the warning from systemd for now.
Chris Down [Wed, 5 Feb 2020 12:12:52 +0000 (12:12 +0000)]
cgroup: systemctl: Don't display NULL if protection was set to max
Inside format_bytes, we return NULL if the value is UINT64_MAX. This
makes some kind of sense where this has some other semantic meaning than
being a value, but in this case the value is both a.) not the default
(so we definitely want to display it), and b.) means "infinity" (or
"max" in cgroup terminology).
This patch adds a small wrapper around format_bytes that can be used for
these cases, to avoid the following situation:
[root@tangsanjiao ~]# cat /sys/fs/cgroup/workload.slice/memory.low
max
[root@tangsanjiao ~]# systemctl show workload.slice -p MemoryLow
MemoryLow=infinity
[root@tangsanjiao ~]# systemctl status workload.slice | grep low:
Memory: 14.9G (low: (null))
After the patch:
[root@tangsanjiao ~]# systemctl status workload.slice | grep low:
Memory: 15.1G (low: infinity)
Michal Koutný [Wed, 5 Feb 2020 16:21:32 +0000 (17:21 +0100)]
docs: Correct resource weight range
Zbigniew Jędrzejewski-Szmek [Wed, 5 Feb 2020 16:05:33 +0000 (17:05 +0100)]
Merge pull request #14415 from ssahani/prefixstable-rfc-7217-new
network: Allow to specify multiple IPv6Token for SLAAC
Yu Watanabe [Wed, 5 Feb 2020 10:40:23 +0000 (19:40 +0900)]
polkit: remove unused variable
Follow-up for
637486261528e8aa3da9f26a4487dc254f4b7abb.
Zbigniew Jędrzejewski-Szmek [Wed, 5 Feb 2020 12:26:27 +0000 (13:26 +0100)]
github: remove direct paypal link
Fixes #14786. I think it is enough if we provide the link to
SPI which sports a prominent paypal link too.
Zbigniew Jędrzejewski-Szmek [Wed, 5 Feb 2020 08:51:59 +0000 (09:51 +0100)]
meson: bump version numbers for v245
Zbigniew Jędrzejewski-Szmek [Wed, 5 Feb 2020 08:49:46 +0000 (09:49 +0100)]
NEWS: add contributors for v245
Zbigniew Jędrzejewski-Szmek [Wed, 5 Feb 2020 09:20:40 +0000 (10:20 +0100)]
NEWS: mention the operational state changes
Zbigniew Jędrzejewski-Szmek [Wed, 5 Feb 2020 08:37:07 +0000 (09:37 +0100)]
Merge branch 'polkit-ref-count'
Zbigniew Jędrzejewski-Szmek [Wed, 5 Feb 2020 09:16:29 +0000 (10:16 +0100)]
Merge pull request #14536 from DaanDeMeyer/wait-online-max-operstate
wait-online: add maximum operational state option
Yu Watanabe [Wed, 5 Feb 2020 09:04:58 +0000 (18:04 +0900)]
NEWS: mention SuppressPrefixLength=
Frantisek Sumsal [Tue, 4 Feb 2020 12:49:01 +0000 (13:49 +0100)]
test: adapt to the new capsh format
Since libcap v2.29 the format of cap_to_text() has been changed which
makes certain `test-execute` subtest fail. Let's remove the offending
part of the output (dropped capabilities) to make it compatible with
both the old and the new libcap.
Yu Watanabe [Sun, 26 Jan 2020 12:18:45 +0000 (21:18 +0900)]
test-network: add tests for IPv6Token=
Susant Sahani [Thu, 9 Jan 2020 12:19:53 +0000 (13:19 +0100)]
network: Allow to specify multiple IPv6Token for SLAAC
Provide names to choose between different auto-generation types:
2.1 "eui64" for EUI-64 of RFC 4291
2.2 "prefixstable" for RFC 7217
```
[Match]
Name=veth99
[Network]
DHCP=no
IPv6AcceptRA=yes
IPv6Token=prefixstable:2001:888:0db8:1::
```
Zbigniew Jędrzejewski-Szmek [Wed, 5 Feb 2020 08:35:58 +0000 (09:35 +0100)]
Merge pull request #14779 from keszybz/news-v245
Zbigniew Jędrzejewski-Szmek [Tue, 4 Feb 2020 16:07:47 +0000 (17:07 +0100)]
NEWS: mention the TrafficControlQueueingDiscipline rename
Zbigniew Jędrzejewski-Szmek [Tue, 4 Feb 2020 14:29:39 +0000 (15:29 +0100)]
NEWS: mention empty .link and .network files
Zbigniew Jędrzejewski-Szmek [Tue, 4 Feb 2020 14:19:37 +0000 (15:19 +0100)]
NEWS: reword and shorten a bunch of stuff
Yu Watanabe [Tue, 4 Feb 2020 14:51:58 +0000 (23:51 +0900)]
test-network: use udevd in build directory
Fixes #14764.
Yu Watanabe [Wed, 5 Feb 2020 06:20:50 +0000 (15:20 +0900)]
Merge pull request #14778 from cgzones/split_selinux_logging
Improve SELinux logging in permissive mode
Zbigniew Jędrzejewski-Szmek [Tue, 4 Feb 2020 17:29:03 +0000 (18:29 +0100)]
hwdb: update for v245-rc1
As before, the changes to .hwdb files are mostly additions and company renames.
Zbigniew Jędrzejewski-Szmek [Wed, 5 Feb 2020 04:41:30 +0000 (05:41 +0100)]
network: change "Gateway=dhcp" to "Gateway=_dhcp" (#14774)
This way we avoid confusion with a DNS name. Fixes #14773.
Yu Watanabe [Wed, 5 Feb 2020 04:35:25 +0000 (13:35 +0900)]
Merge pull request #14767 from yuwata/network-split-qdisc-section
network: split TrafficControlQueueingDiscipline section into small pieces
Christian Göttsche [Tue, 28 Jan 2020 20:25:25 +0000 (21:25 +0100)]
core: move bus-util include out of selinux-access header
Zbigniew Jędrzejewski-Szmek [Tue, 4 Feb 2020 17:39:04 +0000 (18:39 +0100)]
Fix typo in function name
Lennart Poettering [Wed, 22 Jan 2020 16:44:33 +0000 (17:44 +0100)]
man: document the new sd_bus_enqueue_for_read() API call
Lennart Poettering [Wed, 22 Jan 2020 16:07:47 +0000 (17:07 +0100)]
polkit: when authorizing via PK let's re-resolve callback/userdata instead of caching it
Previously, when doing an async PK query we'd store the original
callback/userdata pair and call it again after the PK request is
complete. This is problematic, since PK queries might be slow and in the
meantime the userdata might be released and re-acquired. Let's avoid
this by always traversing through the message handlers so that we always
re-resolve the callback and userdata pair and thus can be sure it's
up-to-date and properly valid.
Lennart Poettering [Wed, 22 Jan 2020 16:05:17 +0000 (17:05 +0100)]
sd-bus: introduce API for re-enqueuing incoming messages
When authorizing via PolicyKit we want to process incoming method calls
twice: once to process and figure out that we need PK authentication,
and a second time after we aquired PK authentication to actually execute
the operation. With this new call sd_bus_enqueue_for_read() we have a
way to put an incoming message back into the read queue for this
purpose.
This might have other uses too, for example debugging.
Lennart Poettering [Wed, 22 Jan 2020 15:53:59 +0000 (16:53 +0100)]
polkit: use structured initialization
Lennart Poettering [Wed, 22 Jan 2020 15:52:10 +0000 (16:52 +0100)]
polkit: on async pk requests, re-validate action/details
When we do an async pk request, let's store which action/details we used
for the original request, and when we are called for the second time,
let's compare. If the action/details changed, let's not allow the access
to go through.
Lennart Poettering [Wed, 22 Jan 2020 15:44:43 +0000 (16:44 +0100)]
polkit: reuse some common bus message appending code
Lennart Poettering [Wed, 22 Jan 2020 13:29:43 +0000 (14:29 +0100)]
bus-polkit: rename return error parameter to ret_error
Christian Göttsche [Mon, 23 Dec 2019 22:06:38 +0000 (23:06 +0100)]
core: unit_label_path(): take const unit
Zbigniew Jędrzejewski-Szmek [Mon, 27 Jan 2020 08:37:27 +0000 (09:37 +0100)]
man: add "quick-help" to sysusers.d synopsis
We have that in tmpfiles.d and it is makes looking up the syntax
very easy.
While at it, add an example for "r" and use the underscrore as prefix
as described in the text.
Christian Göttsche [Wed, 18 Dec 2019 13:57:00 +0000 (14:57 +0100)]
selinux-access: log warning on context acquisition failure
Relevant when testing in permissive mode, where the function does not return a failure to the client.
This helps to configure a system in permissive mode, without getting surprising failures when switching to enforced mode.
Christian Göttsche [Wed, 18 Dec 2019 13:56:54 +0000 (14:56 +0100)]
selinux-util: increase log severity
`log_enforcing()` and `log_enforcing_errno()` are only used for important messages, which describe failures in enforced mode.
They are guarded either by `!mac_selinux_use()` or `!label_hnd` checks, where the latter is itself guarded by the former.
Only SELinux enabled systems print these logs.
This helps to configure a system in permissive mode, without getting surprising failures when switching to enforced mode.
Zbigniew Jędrzejewski-Szmek [Tue, 4 Feb 2020 16:47:17 +0000 (17:47 +0100)]
Merge pull request #14717 from yuwata/network-radv-dns-link-local
network: make DNS= in [IPv6PrefixDelegation] section take special value '_link_local'
Zbigniew Jędrzejewski-Szmek [Tue, 4 Feb 2020 16:35:12 +0000 (17:35 +0100)]
network: FairQueueTrafficPolicing→FairQueueing
This never made into a release, so we can change the name with impunity.
Suggested by Davide Pesavento.
I opted to add the "ing" ending. "Fair queuing" is the name of the general
concept and algorithm, and "Fair queue" is mostly used for the implementation
name.
Zbigniew Jędrzejewski-Szmek [Tue, 4 Feb 2020 16:22:41 +0000 (17:22 +0100)]
network: TokenBufferFilter→TokenBucketFilter
This never made into a release, so we can change the name with impunity.
Noticed by Davide Pesavento.
Zbigniew Jędrzejewski-Szmek [Tue, 4 Feb 2020 15:40:52 +0000 (16:40 +0100)]
man: tweak description of blockdev@.target
In particular, let's just say "is" and "must" instead of "may be" and
"should". The weaker forms are obviously correct, but the text is easier to
understand if non-conditional forms are used.
Zbigniew Jędrzejewski-Szmek [Tue, 4 Feb 2020 14:36:17 +0000 (15:36 +0100)]
Merge pull request #14398 from poettering/mount-prep
Ansgar Burchardt [Tue, 4 Feb 2020 14:47:24 +0000 (15:47 +0100)]
NEWS: correct indenting for two entries
Zbigniew Jędrzejewski-Szmek [Mon, 3 Feb 2020 19:38:54 +0000 (20:38 +0100)]
meson: update efi path detection to gnu-efi-3.0.11
Fixes systemd build in Fedora rawhide.
The old ldsdir option is not useful, because both the directory and the
file name changed. Let's remove the option and try to autodetect the file
name. If this turns out to be not enough, a new option to simply specify
the full path to the file can be added.
F31:
efi arch: x86_64
EFI machine type: x64
EFI CC ccache cc
EFI lds: /usr/lib64/gnuefi/elf_x64_efi.lds
EFI crt0: /usr/lib64/gnuefi/crt0-efi-x64.o
EFI include directory: /usr/include/efi
F32:
efi arch: x86_64
EFI machine type: x64
EFI CC ccache cc
EFI lds: /usr/lib/gnuefi/x64/efi.lds
EFI crt0: /usr/lib/gnuefi/x64/crt0.o
EFI include directory: /usr/include/efi
Yu Watanabe [Tue, 4 Feb 2020 12:45:29 +0000 (21:45 +0900)]
network: split TrafficControlQueueingDiscipline section into small pieces
Closes #14763.
Yu Watanabe [Tue, 4 Feb 2020 11:26:37 +0000 (20:26 +0900)]
Merge pull request #14761 from keszybz/link-network-no-match
Refuse .network and .link files with no matches
Zbigniew Jędrzejewski-Szmek [Tue, 4 Feb 2020 07:42:50 +0000 (08:42 +0100)]
network,udev: refuse .link and .network settings with no matches
Two releases ago we started warning about this, and I think it is now to turn
this into a hard error. People get bitten by this every once in a while, and
there doesn't see to be any legitimate use case where the same .link or
.network files should be applied to _all_ interfaces, since in particular that
configuration would apply both to lo and any other interfaces. And if for
whatever reason that is actually desired, OriginalName=* or Name=* can be
easily added to silence the warning and achieve the effect.
(The case described in #12098 is particularly nasty: 'echo -n >foo.network'
creates a mask file, 'echo >foo.network' creates a "match all" file.)
Fixes #717, #12098 for realz now.
Zbigniew Jędrzejewski-Szmek [Tue, 4 Feb 2020 07:30:40 +0000 (08:30 +0100)]
test-network: do not fail if lo has a .network file
Fixes #9895.
nabijaczleweli [Mon, 3 Feb 2020 18:31:57 +0000 (19:31 +0100)]
Fix generator name in hibernate-resume-generator's drop-in
Introduced in
ff757c9d294153a26a9dd2d9817d1985656f3002
Zbigniew Jędrzejewski-Szmek [Mon, 3 Feb 2020 14:45:07 +0000 (15:45 +0100)]
presets: "disable" all passive targets by default
Officially we default to a "enable *", even though pretty much everybody
overrides this with "disable *". We have a bunch of targets and services which
should not be enabled by default. In case the default policy is not overriden,
our passive units would be enabled by presets, which is generally not useful at
all. So let's explicitly mark them as disabled.
Note that this effectively changes very little. E.g. on Fedora, all the units
listed in this patch were "disabled" already.
Fixes #14648.
Yu Watanabe [Fri, 31 Jan 2020 08:56:42 +0000 (17:56 +0900)]
test-network: add a test case for IPv6PrefixDelegation.DNS=linklocal
Yu Watanabe [Fri, 31 Jan 2020 06:52:56 +0000 (15:52 +0900)]
network,radv: make DNS= in [IPv6PrefixDelegation] section take special value 'linklocal'
Closes #13639.
Zbigniew Jędrzejewski-Szmek [Mon, 3 Feb 2020 23:04:28 +0000 (00:04 +0100)]
Merge pull request #14589 from keszybz/sysctl-downgrade-messages
sysctl: add glob patterns to set network settings more flexibly
Zbigniew Jędrzejewski-Szmek [Thu, 30 Jan 2020 09:41:31 +0000 (10:41 +0100)]
sysctl: set ipv4 settings in a race-free way
Fixes #6282.
This solution is a bit busy, but we close the race without setting *.all.*, so
it is still possible to set a different setting for particular interfaces.
Setting just "default" is not very useful because any interfaces present before
systemd-sysctl is invoked are not affected. Setting "all" is too harsh, because
the kernel takes the stronger of the device-specific setting and the "all" value,
so effectively having a weaker setting for specific interfaces is not possible.
Zbigniew Jędrzejewski-Szmek [Thu, 16 Jan 2020 18:38:21 +0000 (19:38 +0100)]
sysctl: add glob syntax to sysctl.d files
This is intended for net.*.conf.*.foo files. Setting just "default" is not very
useful because any interfaces present before systemd-sysctl is invoked are not
affected. Setting "all" is too harsh, because the kernel takes the stronger of
the device-specific setting and the "all" value, so effectively having a weaker
setting for specific interfaces is not possible. Let's add a way in which can
set "default" first and then all the others without "all".
AsciiWolf [Mon, 3 Feb 2020 15:18:36 +0000 (16:18 +0100)]
l10n: update Czech Translation
Anita Zhang [Mon, 3 Feb 2020 18:38:27 +0000 (10:38 -0800)]
Merge pull request #14747 from yuwata/core-dynamic-user-14733
core: call dynamic_user_acquire() only when 'group' is non-null
Yu Watanabe [Mon, 3 Feb 2020 11:18:02 +0000 (20:18 +0900)]
core: call dynamic_user_acquire() only when 'group' is non-null
When unit is reloaded, and the reloaded unit has bad-setting, then
unit_patch_contexts() is not called and exec_context::user and group
may not be configured.
A minimum reproducer for the case is:
- step 1.
$ sudo systemctl edit --full hoge.service
[Service]
oneshot
ExecStart=sleep 1h
- step 2.
$ sudo systemctl start hoge.service
- step 3.
$ sudo systemctl edit --full hoge.service
[Service]
Type=oneshot
ExecStart=@bindir@/sleep 1h
DynamicUser=yes
Then pid1 crashed.
Fixes #14733.
Yu Watanabe [Sun, 2 Feb 2020 23:58:28 +0000 (08:58 +0900)]
journal: drop unreachable path
splantefeve [Mon, 3 Feb 2020 00:22:15 +0000 (01:22 +0100)]
po: update French translation
Yu Watanabe [Mon, 27 Jan 2020 10:49:25 +0000 (19:49 +0900)]
udev: add {Receive,Transmit}ChecksumOffload= settings
Closes #14661.
Naïm Favier [Sun, 2 Feb 2020 23:25:48 +0000 (00:25 +0100)]
network: add SuppressPrefixLength option to RoutingPolicyRule (#14736)
Closes #14724.
Yu Watanabe [Sun, 2 Feb 2020 14:30:08 +0000 (23:30 +0900)]
po: update Japanese translation
Piotr Drąg [Sun, 2 Feb 2020 12:21:28 +0000 (13:21 +0100)]
po: update Polish translation
Lennart Poettering [Sun, 2 Feb 2020 17:17:21 +0000 (18:17 +0100)]
update NEWS
Lennart Poettering [Sun, 2 Feb 2020 16:27:50 +0000 (17:27 +0100)]
Merge pull request #14645 from keszybz/sd-bus-message-dump
sd_bus_message_dump
Lennart Poettering [Sun, 2 Feb 2020 16:16:31 +0000 (17:16 +0100)]
Merge pull request #14699 from yuwata/dhcp6-fix-t1-t2
dhcp6: do not use T1 and T2 longer than one provided by the lease
Yu Watanabe [Thu, 30 Jan 2020 14:25:12 +0000 (23:25 +0900)]
util: uid_t, gid_t, and pid_t must be 32bit
We already have assert_cc(sizeof(uid_t) == sizeof(uint32_t)) or friends
at various places.
Yu Watanabe [Thu, 30 Jan 2020 15:03:38 +0000 (00:03 +0900)]
meson: fix feature list
Lennart Poettering [Sun, 2 Feb 2020 15:57:17 +0000 (16:57 +0100)]
Merge pull request #14719 from yuwata/sd-boot-fix-warnings
sd-boot: fix warnings
David Michael [Thu, 30 Jan 2020 19:04:14 +0000 (14:04 -0500)]
sysusers: support creating users with a specific primary group
This extends the "uid:gid" syntax for "u" lines so that a group
name can be given instead of a GID. This requires that the group
is either queued for creation by sysusers, or it is already defined
on the system.
Closes #14340
Yu Watanabe [Sun, 2 Feb 2020 13:46:04 +0000 (22:46 +0900)]
Merge pull request #14672 from yuwata/network-routing-policy-uidrange
network: support UID based routing policy
Yu Watanabe [Sun, 26 Jan 2020 13:39:32 +0000 (22:39 +0900)]
test-network: add test for UID based routing policy
Yu Watanabe [Sun, 26 Jan 2020 13:22:38 +0000 (22:22 +0900)]
network: support UID based routing policy
Closes #14666.
Yu Watanabe [Sun, 26 Jan 2020 12:51:12 +0000 (21:51 +0900)]
util: add parse_uid_range() helper function
Yu Watanabe [Sat, 1 Feb 2020 02:01:41 +0000 (11:01 +0900)]
meson, man: do not install pam_systemd_home(8) when pam or homed is disabled
Fixes #14725.
Frantisek Sumsal [Fri, 31 Jan 2020 10:51:05 +0000 (11:51 +0100)]
test: don't install /etc/securetty
Having /etc/securetty in test containers prevents root from logging into
them:
```
Jan 31 10:15:11 systemd-testsuite login[69]: pam_securetty(login:auth): access denied: tty 'pts/0' is not secure !
Jan 31 10:15:11 systemd-testsuite login[69]: FAILED LOGIN 1 FROM pts/0 FOR root, Authentication failure
```
Lennart Poettering [Sat, 1 Feb 2020 10:25:48 +0000 (11:25 +0100)]
Merge pull request #14178 from poettering/journal-namespace
journal: add concept of "journal namespaces"
Anita Zhang [Fri, 31 Jan 2020 20:02:51 +0000 (12:02 -0800)]
Merge pull request #14721 from yuwata/home-tiny-fixes
homed,nspawn,userdb: trivial tiny fixes
Yu Watanabe [Fri, 31 Jan 2020 14:31:19 +0000 (23:31 +0900)]
test: also check the result of merge_gid_lists()
Fixes CID#
1412354.
Yu Watanabe [Fri, 31 Jan 2020 14:23:44 +0000 (23:23 +0900)]
user-util: fix use after free() on error path
Fixes CID#
1412356.
Yu Watanabe [Fri, 31 Jan 2020 14:20:45 +0000 (23:20 +0900)]
userdbd: fix memleak
Fixes CID#
1412416.
Lennart Poettering [Thu, 28 Nov 2019 10:07:15 +0000 (11:07 +0100)]
update TODO
Lennart Poettering [Thu, 28 Nov 2019 09:42:33 +0000 (10:42 +0100)]
man: document --namespace= switch of journalctl
Lennart Poettering [Thu, 28 Nov 2019 09:36:54 +0000 (10:36 +0100)]
man: document the new sd_journal_open_namespace() API
Lennart Poettering [Thu, 28 Nov 2019 09:02:02 +0000 (10:02 +0100)]
man: document LogNamespace= unit setting
Lennart Poettering [Wed, 27 Nov 2019 20:29:47 +0000 (21:29 +0100)]
man: document new _NAMESPACE= journal field
Lennart Poettering [Wed, 27 Nov 2019 20:38:07 +0000 (21:38 +0100)]
man: document journald@NAMESPACE.conf
Lennart Poettering [Wed, 27 Nov 2019 18:25:51 +0000 (19:25 +0100)]
man: document journald namespaces
Lennart Poettering [Thu, 28 Nov 2019 09:50:49 +0000 (10:50 +0100)]
journalctl: underline sections in --help
Yu Watanabe [Fri, 31 Jan 2020 14:10:26 +0000 (23:10 +0900)]
nspawn: voidify umount_verbose()
Fixes CID#
1415122.
Yu Watanabe [Fri, 31 Jan 2020 14:08:53 +0000 (23:08 +0900)]
user-record-util: add missing error check
Fixes CID#
1415123.
Yu Watanabe [Fri, 31 Jan 2020 14:07:07 +0000 (23:07 +0900)]
homework: fix errno in log_error_errno()
Fixes CID#
1415124.
Yu Watanabe [Fri, 31 Jan 2020 14:04:38 +0000 (23:04 +0900)]
home: add missing variable initialization
Fixes CID#
1415126.