Daan De Meyer [Wed, 3 Nov 2021 14:37:55 +0000 (14:37 +0000)]
journal: Don't allocate objects above UINT32_MAX in compact mode
To allow storing offsets as 32-bit, we should never allocate objects
outside of the 32-bit range.
Daan De Meyer [Fri, 21 Jan 2022 15:19:26 +0000 (15:19 +0000)]
journal: Run unit tests with and without compact mode enabled
Daan De Meyer [Sat, 23 Oct 2021 21:43:00 +0000 (22:43 +0100)]
journal: Enable compact mode
We also add an environment variable $SYSTEMD_JOURNAL_COMPACT that
can be used to disable compact mode if needed (similar to
$SYSTEMD_JOURNAL_KEYED_HASH).
Daan De Meyer [Sat, 23 Oct 2021 21:24:56 +0000 (22:24 +0100)]
journal: Add compact mode
This adds a new flag in preparation for incompatible journal changes
which will be gated behind this flag. The max file size of journal
files in compact mode is limited to 4 GiB.
Zbigniew Jędrzejewski-Szmek [Thu, 6 Oct 2022 17:01:33 +0000 (19:01 +0200)]
Merge pull request #24511 from martinetd/bpf1
libbpf: Add libbpf 1.0.0 compat
Arnaud Ferraris [Tue, 4 Oct 2022 16:52:33 +0000 (18:52 +0200)]
repart: always honour `--discard=no`
Currently, even if `--discard=no` is passed to `systemd-repart`, the
`context_discard_gap_after()` function still runs normally, discarding
e.g. all blocks between the GPT and the start of the first partition.
This can lead to issues on some embedded devices, where this space
holds the bootloader and shouldn't be modified (creating a protective
partition there is not always possible due to the specifics of the boot
process of some ARM-based SoC's).
This commit ensures passing `--discard=no` would be enough to ensure
the bootloader isn't wiped in such cases.
Signed-off-by: Arnaud Ferraris <arnaud.ferraris@gmail.com>
Michal Koutný [Thu, 6 Oct 2022 09:59:58 +0000 (11:59 +0200)]
meson: Require TPM2 for measuring utilities
I happened to run build with openssl but no tpm2 and ran into issues
like:
[313/1382] Compiling C object systemd-measure.p/src_boot_measure.c.o
FAILED: systemd-measure.p/src_boot_measure.c.o
cc -Isystemd-measure.p -I. -I.. -Isrc/basic -I../src/basic -Isrc/fundamental -I../src/fundamental -Isrc/systemd -I../src/systemd -I../src/libsystemd/sd-bus -I../src/libsystemd/sd-device -I../src/libsystemd/sd-event -I../src/libsystemd/sd-hwdb -I../src/libsystemd/sd-id128 -I../src/libsystemd/sd-journal -I../src/libsystemd/sd-netlink -I../src/libsystemd/sd-network -I../src/libsystemd/sd-resolve -Isrc/shared -I../src/shared -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O0 -g -Wno-missing-field-initializers -Wno-unused-parameter -Wdate-time -Wendif-labels -Werror=format=2 -Werror=format-signedness -Werror=implicit-function-declaration -Werror=incompatible-pointer-types -Werror=int-conversion -Werror=overflow -Werror=override-init -Werror=return-type -Werror=shift-count-overflow -Werror=shift-overflow=2 -Werror=undef -Wfloat-equal -Wimplicit-fallthrough=5 -Winit-self -Wlogical-op -Wmissing-include-dirs -Wmissing-noreturn -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-aliasing=2 -Wstrict-prototypes -Wsuggest-attribute=noreturn -Wunused-function -Wwrite-strings -Wno-unused-result -Werror=missing-declarations -Werror=missing-prototypes -fdiagnostics-show-option -fno-common -fno-strict-aliasing -fstack-protector -fstack-protector-strong -fvisibility=hidden --param=ssp-buffer-size=4 -fno-omit-frame-pointer -Werror=shadow -include config.h -DOPENSSL_LOAD_CONF -MD -MQ systemd-measure.p/src_boot_measure.c.o -MF systemd-measure.p/src_boot_measure.c.o.d -o systemd-measure.p/src_boot_measure.c.o -c ../src/boot/measure.c
../src/boot/measure.c: In function ‘verb_sign’:
../src/boot/measure.c:710:48: error: variable ‘c’ has initializer but incomplete type
710 | _cleanup_(tpm2_context_destroy) struct tpm2_context c = {};
[308/1382] Compiling C object systemd-pcrphase.p/src_boot_pcrphase.c.o
FAILED: systemd-pcrphase.p/src_boot_pcrphase.c.o
cc -Isystemd-pcrphase.p -I. -I.. -Isrc/basic -I../src/basic -Isrc/fundamental -I../src/fundamental -Isrc/systemd -I../src/systemd -I../src/libsystemd/sd-bus -I../src/libsystemd/sd-device -I../src/libsystemd/sd-event -I../src/libsystemd/sd-hwdb -I../src/libsystemd/sd-id128 -I../src/libsystemd/sd-journal -I../src/libsystemd/sd-netlink -I../src/libsystemd/sd-network -I../src/libsystemd/sd-resolve -Isrc/shared -I../src/shared -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O0 -g -Wno-missing-field-initializers -Wno-unused-parameter -Wdate-time -Wendif-labels -Werror=format=2 -Werror=format-signedness -Werror=implicit-function-declaration -Werror=incompatible-pointer-types -Werror=int-conversion -Werror=overflow -Werror=override-init -Werror=return-type -Werror=shift-count-overflow -Werror=shift-overflow=2 -Werror=undef -Wfloat-equal -Wimplicit-fallthrough=5 -Winit-self -Wlogical-op -Wmissing-include-dirs -Wmissing-noreturn -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-aliasing=2 -Wstrict-prototypes -Wsuggest-attribute=noreturn -Wunused-function -Wwrite-strings -Wno-unused-result -Werror=missing-declarations -Werror=missing-prototypes -fdiagnostics-show-option -fno-common -fno-strict-aliasing -fstack-protector -fstack-protector-strong -fvisibility=hidden --param=ssp-buffer-size=4 -fno-omit-frame-pointer -Werror=shadow -include config.h -DOPENSSL_LOAD_CONF -MD -MQ systemd-pcrphase.p/src_boot_pcrphase.c.o -MF systemd-pcrphase.p/src_boot_pcrphase.c.o.d -o systemd-pcrphase.p/src_boot_pcrphase.c.o -c ../src/boot/pcrphase.c
../src/boot/pcrphase.c: In function ‘determine_banks’:
../src/boot/pcrphase.c:117:24: error: unknown type name ‘TPMI_ALG_HASH’
117 | _cleanup_free_ TPMI_ALG_HASH *algs = NULL;
Guarding the utilites with HAVE_TPM2 fixes the issue for me.
This complements #24811.
Dominique Martinet [Fri, 30 Sep 2022 10:25:18 +0000 (19:25 +0900)]
libbpf: add compat helpers for libbpf down to 0.1.0
- new symbols are available from libbpf 0.6.0 so could be used with
libbpf.so.0, but we're sure the old symbols will be there and this
simplifies code
- detection at runtime should always work, regardless of whether systemd
has been compiled with older or newer libbpf and runs with older or newer
libbpf
drosdeck [Wed, 5 Oct 2022 19:48:32 +0000 (15:48 -0400)]
Fix key toggle touchpad and programmable buttom for Positivo N14
Aleksey Vasenev [Wed, 5 Oct 2022 19:33:53 +0000 (22:33 +0300)]
ata_id: Fixed getting Response Code from SCSI Sense Data (#24921)
The Response Code is contained in the first byte of the SCSI Sense Data.
Bit number 7 is reserved or has a different meaning for some Response Codes
and is set to 1 for some drives.
Daan De Meyer [Fri, 9 Sep 2022 08:38:03 +0000 (10:38 +0200)]
Try to load libbpf.so.1 as well
libbpf had a soname bump. Our usage of libbpf is compatible with
both libbpf.so.0 and libbpf.so.1, so let's try to load from both.
Daan De Meyer [Wed, 31 Aug 2022 09:59:52 +0000 (11:59 +0200)]
libbpf: Remove use of deprecated APIs
Daan De Meyer [Fri, 9 Sep 2022 08:27:57 +0000 (10:27 +0200)]
Bump libbpf version to 0.7
We already depend on the skeleton APIs introduced in libbpf 0.7 so
let's bump our minimum version to reflect that.
We don't enforce bpf compilation on mkosi anymore since not all
distros have sufficiently up-to-date libbpf available.
Frantisek Sumsal [Wed, 5 Oct 2022 13:26:16 +0000 (15:26 +0200)]
test: configure ldconfig's cache in the minimal verity images
The glibc stuff on ppc64le C8S is a little bit wild, as there are two
versions:
```
$ ldconfig -p | grep libc.so
libc.so.6 (libc6,64bit, hwcap: "power9", OS ABI: Linux 3.10.0) => /lib64/glibc-hwcaps/power9/libc-2.28.so
libc.so.6 (libc6,64bit, OS ABI: Linux 3.10.0) => /lib64/libc.so.6
```
and with `/etc/ld.so.cache` present all binaries use the first one:
```
$ ldd /bin/cat
linux-vdso64.so.1 (0x00007fffa8070000)
libc.so.6 => /lib64/glibc-hwcaps/power9/libc-2.28.so (0x00007fffa7e20000)
/lib64/ld64.so.2 (0x00007fffa8090000)
```
However, without the cache the binaries will fall back to `/lib64/libc.so.6`
which breaks tests that use the minimal verity images (like TEST-29),
because we install only the first version (that's shown by `ldd` at
the time the images are created):
```
[ 91.595343] testsuite-29.sh[747]: + portablectl --profile=trusted attach --now --runtime /usr/share/minimal_0.raw minimal-app0
Starting systemd-portabled.service...
[ OK ] Started systemd-portabled.service.
Starting minimal-app0-foo.service...
Starting minimal-app0.service...
[ 104.432217] cat[858]: cat: error while loading shared libraries: libc.so.6: cannot open shared object file: No such file or directory
[ 104.435080] cat[857]: cat: error while loading shared libraries: libc.so.6: cannot open shared object file: No such file or directory
[FAILED] Failed to start minimal-app0.service.
See 'systemctl status minimal-app0.service' for details.
```
```
$ chroot /var/tmp/systemd-test.nMHPfc/minimal/
/bin/bash: error while loading shared libraries: libc.so.6: cannot open shared object file: No such file or directory
```
With the ldconfig's cache it seems to work as expected:
```
$ chroot /var/tmp/systemd-test.gVtYLg/minimal
bash-4.4# cat --version
cat (GNU coreutils) 8.30
...
```
Luca Boccassi [Tue, 4 Oct 2022 20:59:48 +0000 (21:59 +0100)]
Merge pull request #24877 from brauner/namespace_utils
namespace-util: add an initial set of tweaks
Daan De Meyer [Tue, 4 Oct 2022 11:35:36 +0000 (13:35 +0200)]
repart: Drop usage of CHASE_WARN
CHASE_WARN only makes sense when CHASE_SAFE or CHASE_NO_AUTOFS are
used. repart uses neither so let's drop usage of CHASE_WARN.
Luca Boccassi [Tue, 4 Oct 2022 18:12:50 +0000 (20:12 +0200)]
NEWS: even more news
Christian Brauner [Sat, 1 Oct 2022 10:03:25 +0000 (12:03 +0200)]
mount-util: use in_same_namespace()
Signed-off-by: Christian Brauner (Microsoft) <brauner@kernel.org>
Christian Brauner [Fri, 30 Sep 2022 13:05:02 +0000 (15:05 +0200)]
nspawn: use in_same_namespace() helper
Christian Brauner [Fri, 30 Sep 2022 13:02:52 +0000 (15:02 +0200)]
namespace-util: add in_same_namespace()
Add a helper for the canonical way to determine whether two namespaces
are identical.
Christian Brauner [Fri, 30 Sep 2022 13:02:18 +0000 (15:02 +0200)]
nsflags: replace namespace_flag_map with general namespace_info introduced earlier
Christian Brauner [Fri, 30 Sep 2022 12:21:01 +0000 (14:21 +0200)]
namespace-util: add namespace_info
Lennart Poettering [Tue, 4 Oct 2022 16:03:25 +0000 (18:03 +0200)]
Merge pull request #24900 from yuwata/network-ndisc-drop-outdated
network: ndisc: fix zero lifetime handling
Marius Vollmer [Fri, 30 Sep 2022 08:11:04 +0000 (11:11 +0300)]
bus: Process authentication after write
Once everything has been written, a server bus might now process a
pending "BEGIN" and start the bus.
Luca Boccassi [Tue, 4 Oct 2022 12:53:44 +0000 (13:53 +0100)]
NEWS: more news
Luca Boccassi [Tue, 4 Oct 2022 12:04:35 +0000 (13:04 +0100)]
NEWS: typos
Lennart Poettering [Tue, 4 Oct 2022 11:43:48 +0000 (13:43 +0200)]
Merge pull request #24913 from keszybz/hwdb-252-2
hwdb update
Yu Watanabe [Tue, 4 Oct 2022 06:29:25 +0000 (15:29 +0900)]
udev-builtin-net_id: reading phys_port_name may be refused with EOPNOTSUPP
If reading the sysattr failed with such error, the whole operation in
net_id builtin command will fail, and the interface will not be renamed.
Fixes a bug introduced by
5bbcfbaa11a92732f9bbc8d5f77e9311e6ac3d56.
Luca Boccassi [Tue, 4 Oct 2022 10:33:50 +0000 (11:33 +0100)]
Update NEWS
Lennart Poettering [Tue, 4 Oct 2022 09:55:33 +0000 (11:55 +0200)]
update TODO
Zbigniew Jędrzejewski-Szmek [Tue, 4 Oct 2022 08:43:47 +0000 (10:43 +0200)]
hwdb: run "update-hwdb-autosuspend"
Zbigniew Jędrzejewski-Szmek [Tue, 4 Oct 2022 08:43:12 +0000 (10:43 +0200)]
hwdb: run "update-hwdb"
As usual, it seems to be mostly additions and corrections.
drosdeck [Mon, 3 Oct 2022 18:52:24 +0000 (14:52 -0400)]
Fix key toggle touchpad and programmable buttom for Positivo Motion CW14Q01P #24909
Topi Miettinen [Mon, 3 Oct 2022 15:13:42 +0000 (18:13 +0300)]
tmpfiles: fix assert
Oct 03 17:33:20 systemd-tmpfiles[872]: Assertion 'IN_SET(i->type, CREATE_BLOCK_DEVICE|CREATE_CHAR_DEVICE)' failed at src/tmpfiles/tmpfiles.c:1837, function create_device(). Aborting.
I think this is caused by the line:
b! /dev/private/smartmontools-dev/sda 0660 root disk - 8:0
Yu Watanabe [Mon, 3 Oct 2022 15:06:46 +0000 (00:06 +0900)]
network: ndisc: do not accept too many DNS servers or domains
If there exists multiple routers, then the previous logic may introduce
too many DNS servers or domains.
Yu Watanabe [Mon, 3 Oct 2022 02:54:20 +0000 (11:54 +0900)]
network: ndisc: drop addresses and friends when RA with zero lifetime is received
Routers may send options with zero lifetime if previously announced
information is outdated. Hence, if we receive such messages, then we
need to drop relevant addresses or friends.
See e.g. https://www.rfc-editor.org/rfc/rfc4861#section-12.
Follow-up for
2ccada8dc4a3571468a335808fd6fe49b8c6c6dd.
Yu Watanabe [Mon, 3 Oct 2022 03:42:40 +0000 (12:42 +0900)]
network: make sec_to_usec() map 0sec -> 0usec
Zero lifetime in RA is special, and we should not assign possibly very
short lifetime addresses or friends.
This should not change anything at least now, preparation for later
commits. Note, DHCPv4 and v6 code also uses it, but sd-dhcp-client and
sd-dhcp6-client already filtered messages with zero lifetime. Hence,
the change should not affect DHCP code.
Yu Watanabe [Mon, 3 Oct 2022 15:19:13 +0000 (00:19 +0900)]
network: ndisc: also introduce timer event source to drop outdated settings
Otherwise, settings based on previously received RA messages will never
removed without receiving a new RA message.
Yu Watanabe [Mon, 3 Oct 2022 03:18:49 +0000 (12:18 +0900)]
network: ndisc: drop outdated settings before processing RA message
Otherwise, e.g. if a router is replaced, then the previously received
settings may never dropped.
Follow-up for
2ccada8dc4a3571468a335808fd6fe49b8c6c6dd.
Yu Watanabe [Mon, 3 Oct 2022 14:57:48 +0000 (23:57 +0900)]
network: ndisc: address_get() returns 0 on success
After the commit
3b6a3bdebfb555754fdc6ee507e3f6964de7b61c, address_get()
does not return 1.
Yu Watanabe [Mon, 3 Oct 2022 03:39:56 +0000 (12:39 +0900)]
network: introduce {address,route}_remove_and_drop()
Preparation for later commits.
Yu Watanabe [Mon, 3 Oct 2022 01:12:23 +0000 (10:12 +0900)]
network: ndisc: ignore prefix option with link-local prefix
See https://www.rfc-editor.org/rfc/rfc4861#section-4.6.2.
Yu Watanabe [Mon, 3 Oct 2022 03:28:41 +0000 (12:28 +0900)]
network: ndisc: read prefix earlier
No functional changes.
Luca Boccassi [Mon, 3 Oct 2022 14:28:11 +0000 (15:28 +0100)]
TODO: tmpfiles.d m/M
Daan De Meyer [Mon, 3 Oct 2022 08:09:24 +0000 (10:09 +0200)]
repart: Use chase_symlinks() instead of path_join()
Let's properly resolve symlinks and check if the source actually
exists.
Luca Boccassi [Mon, 3 Oct 2022 12:58:09 +0000 (13:58 +0100)]
Merge pull request #23213 from bluca/jammy
Fixes for Jammy CI
Luca Boccassi [Sun, 2 Oct 2022 19:12:02 +0000 (20:12 +0100)]
test-70: check if LUKS2 plugins are actually installed, not just supported
We don't build them in Debian/Ubuntu yet, even though cryptsetup supports them
Luca Boccassi [Sun, 2 Oct 2022 19:11:21 +0000 (20:11 +0100)]
repart: workaround spurious maybe-uninitialized warning
Build fails on Ubuntu Jammy
Yu Watanabe [Mon, 3 Oct 2022 03:35:29 +0000 (12:35 +0900)]
network: fix use-after-free
If the lifetime of the route is already expired, do not try to
configure it.
Fixes a use-after-free, as the Request object is already freed, thus, we
cannot use Route or Link stored in Request object.
Yu Watanabe [Mon, 3 Oct 2022 00:29:45 +0000 (09:29 +0900)]
resolve: drop remaining references for Monitor=
Follow-up for
b25d819aee10b79a1c972d25be81a238448134dd.
Thomas Hebb [Thu, 29 Sep 2022 06:40:35 +0000 (23:40 -0700)]
network: don't forget old RAs when a new one arrives
IPv6 Neighbor Discovery lets us autoconfigure a link's IPv6 addresses,
routes, DNS servers, and DNS search domains by listening for Router
Advertisement (RA) packets broadcast by one or more routers on the link.
Each RA can contain zero or more "options," each describing one piece of
configuration (e.g. a single route).
Currently, when we receive an RA from a router, we delete any addresses,
routes, etc. that originated from that router's previous RAs unless
they're also present as options in the new RA.
That behavior is a violation of RFC 4861[1]. In Section 9, the RFC
states that
Senders MAY send a subset of options in different packets. ... Thus,
a receiver MUST NOT associate any action with the absence of an
option in a particular packet. This protocol specifies that
receivers should only act on the expiration of timers and on the
information that is received in the packets.
Several other passages in the RFC reiterate this. Section 6.2.3:
A router MAY choose not to include some or all options when sending
unsolicited Router Advertisements.
Section 6.3.4:
Hosts accept the union of all received information; the receipt of a
Router Advertisement MUST NOT invalidate all information received in
a previous advertisement or from another source.
At least one consumer router in production today, the Google Nest Wifi,
often sends RAs that omit its global IPv6 prefix. When current versions
of systemd-networkd receive those RAs, they immediately delete the
interface's global IPv6 address, which breaks IPv6 connectivity.
Fix the issue by removing the invalidation logic entirely. It's not
needed at all, since we already invalidate addresses, routes, and DNS
configuration when the interface goes down or their lifetimes expire.
This fix does have the side effect of preventing changes to the .network
file (e.g. denylisted prefixes, whether to add routes from RAs) from
taking effect as soon as a new RA arrives. Instead, a full interface
reconfiguration is needed. But triggering those changes on RA receipt
was already rather arbitrary and out of the administrator's control, so
I think this change is fine.
commit
69203fba700e ("network: ndisc: remove old addresses and routes
after at least one SLAAC address becomes ready") introduced this
behavior. commit
50550722e3ba fixed it partially, by preventing one
router's RAs from invalidating another router's configuration.
[1] https://www.rfc-editor.org/rfc/rfc4861
Fixes:
69203fba700e ("network: ndisc: remove old addresses and routes after at least one SLAAC address becomes ready")
Yu Watanabe [Mon, 3 Oct 2022 00:23:37 +0000 (09:23 +0900)]
resolve: fix typo
Daan De Meyer [Sun, 2 Oct 2022 19:37:31 +0000 (21:37 +0200)]
repart: Take --root into account in read only filesystems shortcut
Yu Watanabe [Sun, 2 Oct 2022 22:51:50 +0000 (07:51 +0900)]
Merge pull request #24897 from mrc0mmand/TEST-64-sanitiers-open-scsi
test: pre-load ASan's DSO for iscsi-init.service
Frantisek Sumsal [Sun, 2 Oct 2022 20:51:56 +0000 (22:51 +0200)]
test: pre-load ASan's DSO for iscsi-init.service
The iscsi-init.service calls `sh` which might, in certain circumstances,
pull in instrumented systemd NSS modules causing `sh` to fail. Let's mitigate
this by pulling in an env file crafted by `create_asan_wrapper()` that
(among others) pre-loads ASan's DSO.
Frantisek Sumsal [Fri, 23 Sep 2022 22:00:36 +0000 (07:00 +0900)]
test: introduce a simple environment file for test service
Daan De Meyer [Sun, 2 Oct 2022 08:51:53 +0000 (10:51 +0200)]
repart: Don't fail on missing verity sig partition
Also, provide a proper error message when we fail to find a verity
sibling partition.
Frantisek Sumsal [Sat, 1 Oct 2022 19:56:08 +0000 (21:56 +0200)]
test: expand the expression in `cleanup_initdir()`
Otherwise we might unexpectedly return 1 if the `get_bool` call fails.
If the `get_bool` part in `get_bool "$TEST_SETUP_CLEANUP_ROOTDIR" && _umount_dir "${initdir:?}"`
fails, the whole expression will short-circuit evaluate to 1, and since it's
the last expression in the function it's also it's return value, which doesn't
reflect the original intent of the expression:
```
# BUILD_DIR=$PWD/build make -C test/TEST-64-UDEV-STORAGE/ setup run TESTCASES=testcase_always_skip
make: Entering directory '/home/fsumsal/repos/@systemd/systemd/test/TEST-64-UDEV-STORAGE'
TEST-64-UDEV-STORAGE SETUP: systemd-udev storage tests
Reusing existing image /var/tmp/systemd-test.uPbJZ9/default.img → /var/tmp/systemd-test.uPbJZ9/default.img
TEST-64-UDEV-STORAGE RUN: systemd-udev storage tests
------ testcase_always_skip: BEGIN ------
Skipping...
------ testcase_always_skip: END (SKIP) ------
Passed tests: 0
*
Skipped tests: 1
* testcase_always_skip
Failed tests: 0
*
TEST-64-UDEV-STORAGE RUN: systemd-udev storage tests [OK]
make: Leaving directory '/home/fsumsal/repos/@systemd/systemd/test/TEST-64-UDEV-STORAGE'
# BUILD_DIR=$PWD/build make -C test/TEST-64-UDEV-STORAGE/ setup run TESTCASES=testcase_always_skip
make: Entering directory '/home/fsumsal/repos/@systemd/systemd/test/TEST-64-UDEV-STORAGE'
TEST-64-UDEV-STORAGE SETUP: systemd-udev storage tests
Reusing existing image /var/tmp/systemd-test.uPbJZ9/default.img → /var/tmp/systemd-test.uPbJZ9/default.img
make: *** [Makefile:4: setup] Error 1
make: Leaving directory '/home/fsumsal/repos/@systemd/systemd/test/TEST-64-UDEV-STORAGE'
```
Frantisek Sumsal [Sat, 1 Oct 2022 18:56:01 +0000 (20:56 +0200)]
test: drop the explicit bus assignment for the pci-bridge
as it doesn't work with the Q35 chipset due to a different topology.
Auto-assignment seems to work with both Q35 and i440FX chipsets.
Luca Boccassi [Sat, 1 Oct 2022 18:30:21 +0000 (19:30 +0100)]
Merge pull request #24878 from keszybz/condition-first-boot
Tweak condition first boot to use the same logic in pid1 and units
Maxim Mikityanskiy [Sat, 1 Oct 2022 11:28:44 +0000 (14:28 +0300)]
hwdb: Add Fn+F12 on HP Dragonfly G2 and mute extra rfkill keys
Add new key mappings for the HP Elite Dragonfly G2 laptop:
1. Map Fn+F12 (HP Programmable Key) to prog1.
2. Unmap Fn+F11 (Airplane mode) from atkbd and Intel HID events, as this
key is also reported by HP Wireless hotkeys.
Clyde Byrd III [Tue, 8 Mar 2022 23:26:33 +0000 (15:26 -0800)]
man: Update systemd.killMode docs
dependabot[bot] [Sat, 1 Oct 2022 11:01:11 +0000 (11:01 +0000)]
build(deps): bump ninja from 1.10.2.3 to 1.10.2.4 in /.github/workflows
Bumps [ninja](https://github.com/ninja-build/ninja) from 1.10.2.3 to 1.10.2.4.
- [Release notes](https://github.com/ninja-build/ninja/releases)
- [Commits](https://github.com/ninja-build/ninja/commits)
---
updated-dependencies:
- dependency-name: ninja
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Frantisek Sumsal [Sat, 1 Oct 2022 11:09:28 +0000 (13:09 +0200)]
ci: pin stefanbuck/github-issue-parser to a tagged release
Since [0] got resolved ([1]) we can finally pin the action to a tagged
release (v2.0.4 ATTOW) and let Dependabot to do its job by updating it
to the latest tagged release when it becomes available.
Replaces: #24886
[0] https://github.com/stefanbuck/github-issue-parser/issues/23
[1] https://github.com/stefanbuck/github-issue-parser/pull/39
dependabot[bot] [Sat, 1 Oct 2022 09:02:58 +0000 (09:02 +0000)]
build(deps): bump actions/labeler from 4.0.0 to 4.0.1
Bumps [actions/labeler](https://github.com/actions/labeler) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/actions/labeler/releases)
- [Commits](https://github.com/actions/labeler/compare/
9fd24f1f9d6ceb64ba34d181b329ee72f99978a0...
e54e5b338fbd6e6cdb5d60f51c22335fc57c401e)
---
updated-dependencies:
- dependency-name: actions/labeler
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
dependabot[bot] [Sat, 1 Oct 2022 09:03:02 +0000 (09:03 +0000)]
build(deps): bump redhat-plumbers-in-action/differential-shellcheck
Bumps [redhat-plumbers-in-action/differential-shellcheck](https://github.com/redhat-plumbers-in-action/differential-shellcheck) from 3.0.1 to 3.1.1.
- [Release notes](https://github.com/redhat-plumbers-in-action/differential-shellcheck/releases)
- [Changelog](https://github.com/redhat-plumbers-in-action/differential-shellcheck/blob/main/CHANGELOG.md)
- [Commits](https://github.com/redhat-plumbers-in-action/differential-shellcheck/compare/
a14889568f6210b361eb29e16f3b07f512fca846...
1b1b75e42f0694c1012228513b21617a748c866e)
---
updated-dependencies:
- dependency-name: redhat-plumbers-in-action/differential-shellcheck
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
dependabot[bot] [Sat, 1 Oct 2022 09:03:12 +0000 (09:03 +0000)]
build(deps): bump meson from 0.63.1 to 0.63.2 in /.github/workflows
Bumps [meson](https://github.com/mesonbuild/meson) from 0.63.1 to 0.63.2.
- [Release notes](https://github.com/mesonbuild/meson/releases)
- [Commits](https://github.com/mesonbuild/meson/compare/0.63.1...0.63.2)
---
updated-dependencies:
- dependency-name: meson
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Zbigniew Jędrzejewski-Szmek [Fri, 30 Sep 2022 13:31:40 +0000 (15:31 +0200)]
man: add cross-links about preset operations
Zbigniew Jędrzejewski-Szmek [Fri, 30 Sep 2022 10:50:40 +0000 (12:50 +0200)]
manager: fix/change evaluation of ConditionFirstBoot
The code to evaluate the kernel command line option was busted because it
was doing 'return b == !!r' at a point where 'r > 0'. Thus we'd return "true"
in both cases:
$ SYSTEMD_PROC_CMDLINE=systemd.condition-first-boot build/systemd-analyze condition 'ConditionFirstBoot=true'
test.service: ConditionFirstBoot=true succeeded.
Conditions succeeded.
$ SYSTEMD_PROC_CMDLINE=systemd.condition-first-boot build/systemd-analyze condition 'ConditionFirstBoot=false'
test.service: ConditionFirstBoot=false succeeded.
Conditions succeeded.
We only use 'ConditionFirstBoot=true' in units, so this wasn't noticed.
But I think the logic is broken in general: the condition should evaluate as
true only during initial boot. If we rerun the units at later points, we should
not consider ConditionFirstBoot to be true.
Also, the first boot logic is also used in pid1 itself. AFAICT, for two
things: in first boot machine-id is initialized transiently (this allows
first-boot operations to be restarted if boot fails), and preset-all is
executed. But this logic was different and separate from the logic to
evaluate ConditionFirstBoot. The distinction is abolished, and the operations
in pid1 now use the same logic as ConditionFirstBoot, which means that the
kernel command line option is checked, and condition_test_first_boot()
just tests whether pid1 thinks we're in first boot.
This makes things easier to grok for the user: there's just one condition for
"first boot" and it applies to both pid1 and units.
Zbigniew Jędrzejewski-Szmek [Fri, 30 Sep 2022 15:26:34 +0000 (17:26 +0200)]
docs/CONTRIBUTING: strenghten language about ABI stability, fix links, other tweaks
The text made it sound like breaking ABI in libsystemd is allowed with good reasons.
In fact, we plan never to do this, so make the language stronger.
Also remind people about distro forums for reporting bugs. Those are probably a
better place than systemd-devel for new users.
Also, add some missing articles and apostrophes, fix URLs, remove repeated phrases,
etc.
James Hilliard [Fri, 30 Sep 2022 21:42:22 +0000 (15:42 -0600)]
Revert "bpf: fix is_allow_list section"
GCC was modified to use the same default section as LLVM, as such
this is no longer required.
Details:
https://github.com/gcc-mirror/gcc/commit/
a0aafbc324aa90421f0ce99c6f5bbf64ed163da6
This reverts commit
e8b1e9cf1095f9d6d0f1e2dce2503e25fec2e6c5.
James Hilliard [Sat, 1 Oct 2022 00:09:53 +0000 (00:09 +0000)]
meson: set minimum libbpf/bpftool versions for bpf-gcc
We need the following libbpf commits for bpf-gcc compatibility:
- https://github.com/libbpf/libbpf/commit/
3d484ca47339b23afb2ec7c508ed9a3a5cf1d287
- https://github.com/libbpf/libbpf/commit/
b31ca3fa0e62fde6aa66f855136e29e088ad9dde
These are first present in libbpf 1.0.0 and bpftool 7.0.0.
Luca Boccassi [Fri, 30 Sep 2022 19:07:49 +0000 (20:07 +0100)]
Merge pull request #24829 from yuwata/blockdev-new-from-fd
blockdev-util: introduce block_device_new_from_fd() and _path()
Luca Boccassi [Fri, 30 Sep 2022 19:02:19 +0000 (20:02 +0100)]
Merge pull request #24749 from yuwata/dissect-image-file
dissect-image: introduce dissect_image_file() which works for regular file instead of block device
Jacek Migacz [Wed, 21 Sep 2022 06:23:22 +0000 (08:23 +0200)]
resolve: unsupported DNSSEC algorithms are considered INSECURE; not BOGUS
Resolves: #19824
Zbigniew Jędrzejewski-Szmek [Fri, 30 Sep 2022 15:34:21 +0000 (17:34 +0200)]
Merge pull request #24639 from yuwata/test-mountpoint-util
test-mountpoint-util: support running on a mount namespace with another mount on /proc
Christian Brauner [Fri, 30 Sep 2022 12:59:38 +0000 (14:59 +0200)]
missing_sched: add CLONE_NEWTIME
Luca Boccassi [Fri, 30 Sep 2022 14:46:13 +0000 (15:46 +0100)]
Merge pull request #24853 from poettering/resolved-monitor-fixes
resolved: various monitor fixes
Luca Boccassi [Fri, 30 Sep 2022 14:42:15 +0000 (15:42 +0100)]
Merge pull request #24739 from keszybz/coredump-formatting
Improve formatting of package metadata in coredumps
Zbigniew Jędrzejewski-Szmek [Fri, 30 Sep 2022 09:48:12 +0000 (11:48 +0200)]
firstboot: add debug logging
$ SYSTEMD_LOG_LEVEL=debug build/systemd-firstboot --prompt-root-password
Found container virtualization systemd-nspawn.
Found /etc/locale.conf, assuming locale information has been configured.
Failed to read credential firstboot.keymap, ignoring: No such device or address
Prompting for keymap was not requested.
Found /etc/localtime, assuming timezone has been configured.
Prompting for hostname was not requested.
Found /etc/machine-id, assuming machine-id has been configured.
Found /etc/passwd and /etc/shadow, assuming root account has been initialized.
Creation of /etc/kernel/cmdline was not requested, skipping.
Christian Hesse [Fri, 30 Sep 2022 08:26:43 +0000 (10:26 +0200)]
systemctl: color ignored exit status in yellow, not red
If the executable path is prefixed with "-", an exit code of the command
normally considered a failure (i.e. non-zero exit status or abnormal exit
due to signal) is recorded, but has no further effect and is considered
equivalent to success.
Let's honor this with `systemctl status`, and color ignored exit status
in yellow, not red.
Jonas Kümmerlin [Thu, 29 Sep 2022 16:51:03 +0000 (18:51 +0200)]
generator: skip fsck if fsck command is missing
This is useful for systems which don't have any fsck.
We already skip emitting the fsck dependency when the fsck.$fstype helper
is missing, but fstab-generator doesn't necessarily know the fstype when
handling the root= parameter.
Previously, systemd-fsck was started for these mounts and then exited
immediately because it couldn't find the fsck.$fstype helper.
Luca Boccassi [Thu, 29 Sep 2022 21:41:55 +0000 (22:41 +0100)]
portablectl: add --force attach/detach
Allows to skip check that ensures units must not be running.
I have a use case that would use reattach, except the orchestrator
is using a non-standard versioning scheme, so image matching cannot
work. As a workaround, need to be able to detach and then attach
manually, without stopping the units to avoid extended downtimes
and loss of FD store.
Lennart Poettering [Fri, 30 Sep 2022 12:14:33 +0000 (14:14 +0200)]
update TODO
Lennart Poettering [Fri, 30 Sep 2022 08:04:37 +0000 (10:04 +0200)]
test: rework resolved monitoring test
Let's remove some sleep loops, and instead:
1. Use Type=notify to wait until "resolvectl monitor" successfully
installed its monitor, so that we know that queries enqueued later
will definitely be seen.
2. Use "grep -m1" to watch "journalctl -f" output to wait precisely for
the RR data we want to see, and immediately exit.
This shortens code quite a bit, and should make it more robust.
Lennart Poettering [Wed, 28 Sep 2022 10:46:21 +0000 (12:46 +0200)]
resolvectl: add new "monitor" verb
Franck Bui [Fri, 30 Sep 2022 12:23:59 +0000 (14:23 +0200)]
Merge pull request #24831 from poettering/dbus-dump-doc
man: clarify that D-Bus Dump() call is a debugging interface with no guarantees
Lennart Poettering [Wed, 28 Sep 2022 10:46:09 +0000 (12:46 +0200)]
resolved: beef up monitor protocol, include full query info
Lennart Poettering [Thu, 29 Sep 2022 16:26:44 +0000 (18:26 +0200)]
resolved: add dns_question_merge() helper
Very similar to dns_answer_merge(), but for DnsQuestion objects instead
of DnsAnswer.
Lennart Poettering [Wed, 28 Sep 2022 15:17:23 +0000 (17:17 +0200)]
resolved: add generic formatters for RRs into JSON
For now we can use it to send broken-down records of JSON via the
monitor logic, but one day we can certainly reuse for dumping the
caches, or to implement a ResolveRecord() varlink call one day.
Lennart Poettering [Wed, 28 Sep 2022 10:44:43 +0000 (12:44 +0200)]
resolved: split out helper for allocating DnsResourceRecord object from raw data
No change in behaviour, just some refactoring.
Lennart Poettering [Tue, 27 Sep 2022 12:50:53 +0000 (14:50 +0200)]
resolved: split out main server listening code from manager_varlink_init()
Just some minor refactoring, to make binding the two sockets (main +
minitor) symmetric
Lennart Poettering [Tue, 27 Sep 2022 12:29:18 +0000 (14:29 +0200)]
resolved: don't make monitoring optional
The socket is only accessible to privileged clients anyway, no need to
add another (user unfriendly) restriction via opt-in setting. let's just
allow this for privileged clients, mirroring "busctl monitor", or
"tcpdump" and similar, which all just work if you have privs.
(This does not break API, since we never did a release witht the
"Monitor" dbus property or config setting in place, i.e. with
cb456374e096f0ebe9b70d7ddd98e16a4be24ee6)
Lennart Poettering [Tue, 27 Sep 2022 12:28:32 +0000 (14:28 +0200)]
resolved: rename 'notification' → 'monitor'
We expose this externally already as "monitor", name it internally the
same way. (Which is nice since it mirrors busctl monitor)
Lennart Poettering [Wed, 28 Sep 2022 09:42:05 +0000 (11:42 +0200)]
sd-event: add helper for exiting event loop on SIGTERM/SIGINT
In many (most?) of our event loops we want to exit once SIGTERM/SIGINT
is seen. Add a common helper for that, that does the right things in a
single call.
Lennart Poettering [Wed, 28 Sep 2022 09:39:25 +0000 (11:39 +0200)]
sd-event: if signal nr has high bit set sd_event_add_signal() auto-block it via sigprocmask()
So far we expected callers to block the signals manually. Which is
usually a good idea, since they should do that before forking off
threads and similar. But let's add a mode where we automatically block
it for the caller, to simplify things.
Lennart Poettering [Fri, 30 Sep 2022 12:09:54 +0000 (14:09 +0200)]
json: explicitly support offsets relative to NULL when dispatching
Let's trick out UndefinedBehaviourSanitizer:
https://github.com/systemd/systemd/pull/24853#issuecomment-
1263380745
Lennart Poettering [Wed, 28 Sep 2022 15:13:00 +0000 (17:13 +0200)]
json: add helper for json builder for octescape/base32hex
These encodings for binary data are mandated by DNS RFCs, so let's give
make them nice and easy to use with json builder logic.
Lennart Poettering [Wed, 28 Sep 2022 09:35:47 +0000 (11:35 +0200)]
json: add dispatchers for 16bit integers
Lennart Poettering [Wed, 28 Sep 2022 09:34:46 +0000 (11:34 +0200)]
glyph-util: add left arrow special glyph entry