Yu Watanabe [Sun, 17 Jan 2021 15:44:14 +0000 (00:44 +0900)]
network: address-pool: also check conflicts with foreign addresses
Fixes CI issue found in
https://github.com/systemd/systemd-centos-ci/pull/334.
Jonathan McDowell [Sun, 17 Jan 2021 22:39:07 +0000 (22:39 +0000)]
hwdb: Add NEWYES 10" LCD writing tablet (#18274)
Yu Watanabe [Sun, 17 Jan 2021 16:18:17 +0000 (01:18 +0900)]
Merge pull request #18286 from ssahani/net-1
tree-wide: more use of hashmap_ensure_put() and TAKE_PTR()
Lennart Poettering [Sun, 17 Jan 2021 13:43:17 +0000 (14:43 +0100)]
systemctl: use right type 'size_t' for counting memory
Follow-up for
e363b0e4fc4f32225034a11dd53c0cc68747ba6e
(Mostly a theoretical fix. On 64bit systems unsigned is 32bit, and we
had more than 2^32 units thing would fall apart here.)
Susant Sahani [Sun, 17 Jan 2021 10:14:15 +0000 (11:14 +0100)]
network: tc use TAKE_PTR
Susant Sahani [Sun, 17 Jan 2021 09:31:30 +0000 (10:31 +0100)]
udevadm-monitor: use TAKE_PTR
Susant Sahani [Sun, 17 Jan 2021 09:30:06 +0000 (10:30 +0100)]
udevadm-monitor: Use hashmap_ensure_put
Susant Sahani [Sun, 17 Jan 2021 09:28:15 +0000 (10:28 +0100)]
udev-rules: Use hashmap_ensure_put
Susant Sahani [Sun, 17 Jan 2021 09:24:29 +0000 (10:24 +0100)]
resolved-dnssd: Use TAKE_PTR
Susant Sahani [Sun, 17 Jan 2021 09:23:04 +0000 (10:23 +0100)]
resolved-dnssd: Use hashmap_ensure_put
Susant Sahani [Sun, 17 Jan 2021 09:20:22 +0000 (10:20 +0100)]
resolved-dns-packet: Use TAKE_PTR
Susant Sahani [Sun, 17 Jan 2021 09:19:21 +0000 (10:19 +0100)]
resolved-dns-packet: Use hashmap_ensure_put
Susant Sahani [Sun, 17 Jan 2021 09:14:25 +0000 (10:14 +0100)]
resolved-bus: Use hashmap_ensure_put
Susant Sahani [Sun, 17 Jan 2021 09:02:17 +0000 (10:02 +0100)]
journal-remote: use hashmap_ensure_put
Susant Sahani [Sun, 17 Jan 2021 08:55:00 +0000 (09:55 +0100)]
core: load fragment - use hashmap_ensure_put
Susant Sahani [Sun, 17 Jan 2021 13:24:36 +0000 (14:24 +0100)]
core: job - use hashmap_ensure_put
Yu Watanabe [Sun, 17 Jan 2021 07:15:52 +0000 (16:15 +0900)]
basic: drop unused module
Follow-up for
35b42e560039fd87d4ae4d99cd54d1d4e89710b1.
Yu Watanabe [Sun, 17 Jan 2021 11:08:59 +0000 (20:08 +0900)]
Merge pull request #18284 from ssahani/net-7
Tree wide tighten variable scope used in loop
Susant Sahani [Sun, 17 Jan 2021 11:07:02 +0000 (12:07 +0100)]
network: Use ordered_hashmap_ensure_put (#18233)
Yu Watanabe [Sun, 17 Jan 2021 11:05:22 +0000 (20:05 +0900)]
Merge pull request #18230 from ssahani/macvlan-bcqueuelen
network: macvlan - add support to configure rx queue for broadcast / multicast
Lennart Poettering [Sun, 17 Jan 2021 10:18:25 +0000 (11:18 +0100)]
Merge pull request #17576 from gportay/veritysetup-add-support-for-dm-verity-flags
veritysetup: add support for veritytab
Susant Sahani [Sun, 17 Jan 2021 08:49:14 +0000 (09:49 +0100)]
core: dbus - use hashmap_ensure_put
Susant Sahani [Sun, 17 Jan 2021 07:39:28 +0000 (08:39 +0100)]
network: macvlan - add support to configure rx queue for broadcast/multicast
Susant Sahani [Sat, 16 Jan 2021 18:38:06 +0000 (19:38 +0100)]
journal: journal-file - tighten variable scope used in loop
Susant Sahani [Sat, 16 Jan 2021 18:26:24 +0000 (19:26 +0100)]
machine: machined-dbus - tighten variable scope used in loop
Yu Watanabe [Sun, 17 Jan 2021 06:43:14 +0000 (15:43 +0900)]
tree-wide: fix typo
Yu Watanabe [Sun, 17 Jan 2021 06:39:41 +0000 (15:39 +0900)]
Merge pull request #18243 from ssahani/ensure-put-use
tree-wide: introduce hashmap_ensure_put() and use it
Yu Watanabe [Sun, 17 Jan 2021 06:39:01 +0000 (15:39 +0900)]
Merge pull request #18261 from ssahani/net2
network: modernize routing policy rule and add 0 validation where needed
Susant Sahani [Sun, 17 Jan 2021 06:38:33 +0000 (07:38 +0100)]
network: tighten variable scope used in loop (#18277)
Adam Nielsen [Sun, 17 Jan 2021 01:10:57 +0000 (11:10 +1000)]
man: clarify what network scopes are
Susant Sahani [Thu, 14 Jan 2021 06:22:49 +0000 (07:22 +0100)]
network: nexthop - use hashmap_ensure_put
Susant Sahani [Sat, 16 Jan 2021 22:10:18 +0000 (23:10 +0100)]
network: use hashmap_ensure_put
Susant Sahani [Fri, 15 Jan 2021 17:07:28 +0000 (18:07 +0100)]
network: routing-policy-rule - TAKE_PTR
Susant Sahani [Fri, 15 Jan 2021 16:49:16 +0000 (17:49 +0100)]
network: route - add a zero verification for tcp window
Susant Sahani [Sat, 16 Jan 2021 21:08:36 +0000 (22:08 +0100)]
network: tc - use TAKE_PTR (#18266)
* network: tc cake - use TAKE_PTR
* network: tc htb - use TAKE_PTR
* network: tc pie - use TAKE_PTR
* network: tc netem - use TAKE_PTR
* network: tc hhf - use TAKE_PTR
* network: tc gred - use TAKE_PTR
* network: tc fq codel - use TAKE_PTR
* network: tc fifo - use TAKE_PTR
* network: tc drr - use TAKE_PTR
* network: tc qdisc - use TAKE_PTR
Zbigniew Jędrzejewski-Szmek [Sat, 16 Jan 2021 16:21:34 +0000 (17:21 +0100)]
Merge pull request #18263 from keszybz/syscalls-auto
Generate missing syscalls headers programatically
Luca Boccassi [Sat, 16 Jan 2021 12:16:43 +0000 (12:16 +0000)]
Merge pull request #18264 from ssahani/net3
network: Use TAKE_PTR
Luca Boccassi [Sat, 16 Jan 2021 12:13:14 +0000 (12:13 +0000)]
Merge pull request #18268 from ssahani/net5
network: tighten variable scope used in loop
Susant Sahani [Fri, 15 Jan 2021 16:38:00 +0000 (17:38 +0100)]
network: manager tighten variable scope used in loop
Susant Sahani [Thu, 14 Jan 2021 11:58:58 +0000 (12:58 +0100)]
network: route - use ordered_set_ensure_put
Susant Sahani [Fri, 15 Jan 2021 18:00:13 +0000 (19:00 +0100)]
network: address label - use TAKE_PTR
Susant Sahani [Fri, 15 Jan 2021 17:57:11 +0000 (18:57 +0100)]
network: mdb - use TAKE_PTR
Susant Sahani [Fri, 15 Jan 2021 19:34:53 +0000 (20:34 +0100)]
networkctl: tighten variable scope used in loop
Daan De Meyer [Fri, 15 Jan 2021 19:51:42 +0000 (20:51 +0100)]
mkosi: Allow setting version-tag option via VERSION_TAG env variable
With https://github.com/systemd/mkosi/pull/630, we can set environment
variables for the build script in mkosi. Let's modify the build script
so we can set the version-tag option via an environment variable of the
same name. The default is the empty string which causes meson to fall
back to the default behavior (git version).
Frantisek Sumsal [Fri, 15 Jan 2021 19:50:47 +0000 (20:50 +0100)]
ci: bump the Semaphore CI badge to the v2 instance
Zbigniew Jędrzejewski-Szmek [Fri, 15 Jan 2021 09:31:00 +0000 (10:31 +0100)]
rpm: expose $systemd_util_dir also as rpm macro
This variable (a.k.a. rootlibexecdir), was exposed through the .pc file, but
not as rpm macro.
The .pc file must be located in the package that provides libraries, which
pulls in a lot of dependencies. In Fedora, the macros are split out to a
separate package so that other packages which need to refer to some systemd
path but don't otherwise require it, can only pull in the (much smaller and
dependency-less) macros package. zram-generator uses the path to specify the
location of systemd-makefs, so by using the rpm macro we'll be able to use
a much smaller buildroot.
Susant Sahani [Fri, 15 Jan 2021 19:30:04 +0000 (20:30 +0100)]
network: macsec - tighten variable scope used in loop
Susant Sahani [Fri, 15 Jan 2021 19:26:25 +0000 (20:26 +0100)]
network: generator tighten variable scope used in loop
Frantisek Sumsal [Fri, 15 Jan 2021 17:04:47 +0000 (18:04 +0100)]
ci: migrate to Semaphore CI 2.0
Lennart Poettering [Fri, 15 Jan 2021 13:54:11 +0000 (14:54 +0100)]
fs-util: make laccess() macro follow our usual error propagation
Functions defined by us are supposed to return negative errno-style
errors on errors. laccess() is for access() what lstat() is for stat(),
but defined by us as a macro. This led to some confusion regarding error
handling.
Let's return a negative errno code just in case. This means callers can
it use either way: like access(), i.e. checking for a negative return
value + looking at errno, or like our own code, i.e. using the negative
errno code it returns.
Daan De Meyer [Sun, 10 Jan 2021 12:18:36 +0000 (13:18 +0100)]
meson: Use configure_file when version-tag is specified
vcs_tag() is slow. When the version-tag meson option is set,
we can use configure_file() directly to speed up incremental
builds.
Before (with version-tag set to v247):
```
‣ Running build script...
[1/418] Generating version.h with a custom command
real 0m0.521s
user 0m0.229s
sys 0m0.067s
```
After (with version-tag set to v247):
```
‣ Running build script...
ninja: no work to do.
real 0m0.094s
user 0m0.048s
sys 0m0.022s
```
Susant Sahani [Fri, 15 Jan 2021 17:55:17 +0000 (18:55 +0100)]
network: nexthop - use TAKE_PTR
Zbigniew Jędrzejewski-Szmek [Fri, 15 Jan 2021 16:06:19 +0000 (17:06 +0100)]
src/basic: generate missing syscall headers programatically
Getting the numbers right for all architectures has proven to be a
constant chore. Let's autogenerate the header from the tables that
were imported in one of the previous commits.
Fixes #18074. (Hopefully. I cannot verify this on all architectures.)
To update the lists, or to update the header after template changes:
ninja -C build update-syscall-tables update-syscall-header
Note: the generated file is saved in git. Initially I wanted to only
store the tables in git, and generate the header during each build.
Generation is quick enough, but the header is used in many many
places (wherever missing_syscall.h is included, directly or indirectly),
which means that we would need to declare the dependency in meson, so
the header would be generated early enough. This turned out to be very
noisy. Storing the generated header in version control avoids the hassle.
Zbigniew Jędrzejewski-Szmek [Fri, 15 Jan 2021 12:02:44 +0000 (13:02 +0100)]
tree-wide: use curl --fail
curl will save the 404 response page (or another error) if the page
download fails, which we never want. Let it error out instead.
Zbigniew Jędrzejewski-Szmek [Fri, 15 Jan 2021 10:46:14 +0000 (11:46 +0100)]
syscalls: update tables
$ ninja -C build update-syscall-tables
Zbigniew Jędrzejewski-Szmek [Fri, 15 Jan 2021 10:43:47 +0000 (11:43 +0100)]
meson: download full syscall tables from hrw/syscalls-table
The target is renamed to 'update-syscall-tables'. (Other targets
with similar names will be added later.)
Zbigniew Jędrzejewski-Szmek [Fri, 15 Jan 2021 17:00:14 +0000 (18:00 +0100)]
systemctl: avoid warning about signed-unsigned compare on 32 bits
../src/systemctl/systemctl-list-units.c: In function ‘output_units_list’:
../src/systemctl/systemctl-list-units.c:112:75: warning: comparison of integer expressions of different signedness: ‘int’ and ‘unsigned int’ [-Wsign-compare]
112 | for (const UnitInfo *u = unit_infos; unit_infos && u - unit_infos < c; u++) {
| ^
The pointer difference is signed. I don't know why gcc warns on 32bits, but
not otherwise.
gcc-10.2.1-9.fc33.x86_64, -m32
Gaël PORTAY [Thu, 31 Dec 2020 11:38:49 +0000 (06:38 -0500)]
man/systemd-veritysetup-generator: fix trailing space
Gaël PORTAY [Thu, 31 Dec 2020 11:25:17 +0000 (06:25 -0500)]
veritysetup: remove unused globals
This removes the three global variables arg_root_hash, arg_data_what and
arg_hash_what which were presents since the beginning but were never
being used.
Gaël PORTAY [Sat, 14 Nov 2020 14:21:39 +0000 (09:21 -0500)]
veritysetup-generator: add support for veritytab
This adds the support for veritytab.
The veritytab file contains at most five fields, the first four are
mandatory, the last one is optional:
- The first field contains the name of the resulting verity volume; its
block device is set up /dev/mapper/</filename>.
- The second field contains a path to the underlying block data device,
or a specification of a block device via UUID= followed by the UUID.
- The third field contains a path to the underlying block hash device,
or a specification of a block device via UUID= followed by the UUID.
- The fourth field is the roothash in hexadecimal.
- The fifth field, if present, is a comma-delimited list of options.
The following options are recognized only: ignore-corruption,
restart-on-corruption, panic-on-corruption, ignore-zero-blocks,
check-at-most-once and root-hash-signature. The others options will
be implemented later.
Also, this adds support for the new kernel verity command line boolean
option "veritytab" which enables the read for veritytab, and the new
environment variable SYSTEMD_VERITYTAB which sets the path to the file
veritytab to read.
Luca Boccassi [Fri, 15 Jan 2021 14:00:06 +0000 (14:00 +0000)]
Merge pull request #18254 from keszybz/trivial-cleanups
Assorted small cleanups
Susant Sahani [Thu, 14 Jan 2021 06:18:59 +0000 (07:18 +0100)]
udevd: Use hashmap_ensure_put
Susant Sahani [Fri, 15 Jan 2021 13:32:16 +0000 (14:32 +0100)]
network: online - use hashmap_ensure_put
Susant Sahani [Thu, 14 Jan 2021 06:05:49 +0000 (07:05 +0100)]
network: routing policy rule - Use hashmap_ensure_put
Susant Sahani [Thu, 14 Jan 2021 06:04:11 +0000 (07:04 +0100)]
network: route - Use hashmap_ensure_put
Susant Sahani [Thu, 14 Jan 2021 06:02:58 +0000 (07:02 +0100)]
network: radv - Use hashmap_ensure_put
Susant Sahani [Thu, 14 Jan 2021 06:01:11 +0000 (07:01 +0100)]
network: neighbor - use hashmap_ensure_put
Susant Sahani [Thu, 14 Jan 2021 05:54:47 +0000 (06:54 +0100)]
network: mdb - use hashmap_ensure_put
Susant Sahani [Thu, 14 Jan 2021 05:42:50 +0000 (06:42 +0100)]
network: link - use hashmap_ensure_put
Susant Sahani [Thu, 14 Jan 2021 05:33:52 +0000 (06:33 +0100)]
network: link - use hashmap_ensure_put
Susant Sahani [Thu, 14 Jan 2021 05:32:05 +0000 (06:32 +0100)]
network: fdb - Use hashmap_ensure_put
Susant Sahani [Thu, 14 Jan 2021 05:30:39 +0000 (06:30 +0100)]
network: dhcp6 - use hashmap_ensure_put
Susant Sahani [Thu, 14 Jan 2021 05:28:04 +0000 (06:28 +0100)]
network: address label - use hashmap_ensure_put
Susant Sahani [Thu, 14 Jan 2021 05:25:12 +0000 (06:25 +0100)]
network: wireguard - Use hashmap_ensure_put
Susant Sahani [Thu, 14 Jan 2021 05:24:02 +0000 (06:24 +0100)]
network: netdev - Use hashmap_ensure_put
Susant Sahani [Thu, 14 Jan 2021 05:21:09 +0000 (06:21 +0100)]
generator: Use hashmap_ensure_put
Susant Sahani [Thu, 14 Jan 2021 05:19:47 +0000 (06:19 +0100)]
basic: introuce hashmap_ensure_put
Susant Sahani [Thu, 14 Jan 2021 05:00:53 +0000 (06:00 +0100)]
homed: use ordered_set_ensure_put
Lennart Poettering [Fri, 15 Jan 2021 10:43:15 +0000 (11:43 +0100)]
Merge pull request #18214 from elmarco/vsock
udev: allow kvm group to access vhost net and vsock devices
Zbigniew Jędrzejewski-Szmek [Fri, 15 Jan 2021 10:10:43 +0000 (11:10 +0100)]
Merge pull request #18197 from weblate/weblate-systemd-master
Translations update from Weblate
Zbigniew Jędrzejewski-Szmek [Fri, 15 Jan 2021 10:07:02 +0000 (11:07 +0100)]
Merge pull request #18244 from anitazha/systemctledit
systemctl-edit fixes
Zbigniew Jędrzejewski-Szmek [Fri, 15 Jan 2021 09:23:57 +0000 (10:23 +0100)]
basic/env-util: modernization
Zbigniew Jędrzejewski-Szmek [Fri, 11 Dec 2020 11:24:26 +0000 (12:24 +0100)]
nspawn: minor modernization
Zbigniew Jędrzejewski-Szmek [Thu, 10 Dec 2020 16:13:12 +0000 (17:13 +0100)]
sysctl.d: shorten comment
The grammar was a bit suspect in a few places...
Zbigniew Jędrzejewski-Szmek [Thu, 10 Dec 2020 16:05:42 +0000 (17:05 +0100)]
man: s/dash/mdash/
Lennart Poettering [Fri, 15 Jan 2021 08:58:17 +0000 (09:58 +0100)]
Merge pull request #18124 from ryncsn/initrd
initrd: add an env variable to accept non-ramfs rootfs
Lucas Werkmeister [Thu, 14 Jan 2021 21:32:55 +0000 (22:32 +0100)]
Add truncate: to StandardOutput= etc.
This adds the ability to specify truncate:PATH for StandardOutput= and
StandardError=, similar to the existing append:PATH. The code is mostly
copied from the related append: code. Fixes #8983.
Gaël PORTAY [Fri, 13 Nov 2020 11:00:25 +0000 (06:00 -0500)]
veritysetup-generator: add support for verity root options
This adds support for a new kernel root verity command line option
"verity_root_options=" which controls the behaviour of dm-verity by
forwarding options directly to systemd-veritysetup.
See `veritysetup(8)` for more details.
Gaël PORTAY [Thu, 5 Nov 2020 18:37:43 +0000 (13:37 -0500)]
veritysetup: add support for dm-verity options
This patch allows controlling the behaviour of dm-verity by reusing the
fifth argument that was used to set the roothash signature.
That argument is now a comma-separated list of dm-verity options in the
given format: option[=value]. The option is the name of the long option
in the world of veritysetup.
See `veritysetup(8)` for more details.
Note: The former ROOTHASHSIG the positional argument is now deprecated
in favour of the option root-hash-signature=(base64:SIG|FILE). However,
the previous format is maintained and a warning is logged.
Anita Zhang [Thu, 14 Jan 2021 08:17:41 +0000 (00:17 -0800)]
systemctl-edit: Add missing ret_dropin_paths argument in retry path
find_paths_to_edit() makes 2 calls to unit_find_paths(), one of which is
a retry client-side. ret_dropin_paths should be passed the same in
both cases.
Anita Zhang [Thu, 14 Jan 2021 08:02:09 +0000 (00:02 -0800)]
systemctl-edit: fix abort in find_paths_to_edit()
After
85c5d313b5c92115f5c77663e736bcf21e99f02f, if you, for example,
create a drop-in for -.slice without a corresponding -.slice file, you will
get the following:
# put some valid stuff in /etc/systemd/system/-.slice.d/override.conf
[root@image ~]# systemctl daemon-reload
[root@image ~]# systemctl edit -- -.slice
Assertion 'path' failed at src/systemctl/systemctl-edit.c:425, function
find_paths_to_edit(). Aborting.
Aborted
The aforementioned commit sets the ret_dropin_paths argument for
unit_find_paths(). Thus, unit_find_paths() returns 1 in the example above
because it finds a relevant drop-in. However find_paths_to_edit() was written
to expect 1 only if the unit file itself exists (it does not in this example).
To make this behave more like the version of `systemctl edit` prior to
this commit, add an additional check so the code enters the
"unit file not found" code branch.
Daan De Meyer [Thu, 14 Jan 2021 18:33:42 +0000 (19:33 +0100)]
mkosi: Only reset file permissions when $SRCDIR is not a mountpoint
If $SRCDIR is mounted into the build image (via mkosi overrides),
let's not reset the permissions fo the source tree so as to not
modify the original files on the host.
Luca Boccassi [Thu, 14 Jan 2021 18:46:48 +0000 (18:46 +0000)]
Merge pull request #18245 from poettering/unit-file-install-fixes
minor unit file install fixes
Lennart Poettering [Thu, 14 Jan 2021 14:02:33 +0000 (15:02 +0100)]
systemctl: unit_file_find_fragment() doesn't log about errors, hence do it in the caller
Lennart Poettering [Thu, 14 Jan 2021 14:02:27 +0000 (15:02 +0100)]
systemctl: explicitly comment two cases where we don't log on error cases, on purpose
Lennart Poettering [Thu, 14 Jan 2021 14:01:55 +0000 (15:01 +0100)]
systemctl: properly initialize return params in all success cases
Lennart Poettering [Thu, 14 Jan 2021 14:00:41 +0000 (15:00 +0100)]
unit-file: downgrade log message to debug
In the other error paths unit_file_find_fragment() doesn't log beyond
debug level, i.e. is of the non-logging library-like kind. Make sure
this error path is handled the same, so that the caller can log.
Lennart Poettering [Thu, 14 Jan 2021 14:00:29 +0000 (15:00 +0100)]
unit-file: fix indentation
Kairui Song [Wed, 13 Jan 2021 17:25:20 +0000 (01:25 +0800)]
initrd: do a debug log if /etc/initrd-release doesn't take effect
Signed-off-by: Kairui Song <kasong@redhat.com>
Lennart Poettering [Thu, 14 Jan 2021 13:14:24 +0000 (14:14 +0100)]
update TODO