Yu Watanabe [Tue, 12 Jan 2021 11:46:44 +0000 (20:46 +0900)]
sd-bus: fix memleak
Closes CID#
1437780.
Yu Watanabe [Tue, 12 Jan 2021 11:43:02 +0000 (20:43 +0900)]
boot: at least one of os_name_pretty or os_name exists in this block
Closes CID#
1438933.
Tad Fisher [Thu, 7 Jan 2021 22:13:06 +0000 (14:13 -0800)]
hwdb.d/70-mouse.hwdb: add entry for ELECOM Huge TrackBall
Yu Watanabe [Tue, 12 Jan 2021 05:24:37 +0000 (14:24 +0900)]
Merge pull request #18209 from poettering/virt-fix
three minor fixes to virt.c
Yu Watanabe [Mon, 11 Jan 2021 15:02:09 +0000 (00:02 +0900)]
network: introduce new UseAddress= setting in [DHCPv6] section
If it is disabled, then the addresses provided by the DHCPv6 server will
be ignored.
Closes #18203.
Yu Watanabe [Tue, 12 Jan 2021 05:18:24 +0000 (14:18 +0900)]
Merge pull request #18204 from yuwata/wifi-util-fix-18059
wifi-util: do not ignore wifi iftype when the interface does not have SSID
igo95862 [Mon, 11 Jan 2021 13:04:33 +0000 (16:04 +0300)]
docs: `mesonconf` is not a valid command, `meson configure` is
Meson documentation for `meson configure`
https://mesonbuild.com/Commands.html#configure
Iago López Galeiras [Fri, 11 Dec 2020 12:21:54 +0000 (13:21 +0100)]
exit-status: fix mappings comment
It didn't reflect the current status.
Lennart Poettering [Mon, 11 Jan 2021 20:09:37 +0000 (21:09 +0100)]
virt: fix path mentioned in log message
Lennart Poettering [Mon, 11 Jan 2021 20:08:51 +0000 (21:08 +0100)]
virt: debug log on unexpected error conditions
Let's make this more debuggable by logging if we look for something and
get any error other than ENOENT back.
Lennart Poettering [Mon, 11 Jan 2021 20:08:01 +0000 (21:08 +0100)]
virt: merge three variable declarations
Luca Boccassi [Mon, 11 Jan 2021 17:56:13 +0000 (17:56 +0000)]
Merge pull request #18174 from systemd/coverity-now-for-real
ci: move the Coverity job to GitHub Actions
Yu Watanabe [Mon, 11 Jan 2021 14:36:42 +0000 (23:36 +0900)]
wifi-util: do not ignore wifi iftype when SSID is not set
Previously, if an interface does not have SSID, e.g. run in mesh-point
type, then the wifi iftype obtained by the netlink call was ignored.
Fixes #18059.
Yu Watanabe [Mon, 11 Jan 2021 14:26:54 +0000 (23:26 +0900)]
wifi-util: cleanup header inclusion
Frantisek Sumsal [Mon, 11 Jan 2021 14:14:10 +0000 (15:14 +0100)]
ci: remove remaining Travis CI artifacts
Frantisek Sumsal [Fri, 8 Jan 2021 20:45:08 +0000 (21:45 +0100)]
ci: move the Coverity job to GitHub Actions
Frantisek Sumsal [Fri, 8 Jan 2021 18:53:43 +0000 (19:53 +0100)]
ci: drop a forgotten empty line
Evgeny Vereshchagin [Mon, 11 Jan 2021 14:39:47 +0000 (17:39 +0300)]
Merge pull request #18195 from bluca/bpf_init
bpf: do not use structured initialization for bpf_attr
Daan De Meyer [Mon, 11 Jan 2021 11:52:03 +0000 (12:52 +0100)]
Merge pull request #18198 from yuwata/trivial-cleanups
Trivial cleanups
Yu Watanabe [Mon, 11 Jan 2021 04:31:33 +0000 (13:31 +0900)]
linux: move nl80211.h to basic/linux
As sd-netlink uses the header.
Yu Watanabe [Mon, 11 Jan 2021 04:29:39 +0000 (13:29 +0900)]
udev: drop doubled blank line
Luca Boccassi [Sun, 10 Jan 2021 15:39:24 +0000 (15:39 +0000)]
ci: do not build with --optimization=1 with Clang
Luca Boccassi [Sun, 10 Jan 2021 15:36:31 +0000 (15:36 +0000)]
bpf: do not use structured initialization for bpf_attr
It looks like zero'ing the struct is not enough, and with some level
of optimizations there is still non-zero padding left over.
Switch to member-by-member initialization. Also convert all remaining
bpf_attr variables in other files.
Luca Boccassi [Sun, 10 Jan 2021 15:06:04 +0000 (15:06 +0000)]
dissect: fix root hash signature autodiscovery
The root hash signature is auto discovered only if the root hash was specified
manually. Ensure that an auto discovered root hash is also enough.
Luca Boccassi [Sun, 10 Jan 2021 14:37:56 +0000 (14:37 +0000)]
Merge pull request #18186 from DaanDeMeyer/translations-option
meson: Add option to disable translations
Daan De Meyer [Sat, 9 Jan 2021 19:05:56 +0000 (20:05 +0100)]
mkosi: Disable translations
Speeds up incremental builds by half a second. Let's assume translations
won't be necessary in the resulting test images.
Daan De Meyer [Sat, 9 Jan 2021 18:59:56 +0000 (19:59 +0100)]
meson: Add option to disable translations
This speeds up the meson install step by half a second
which, given the trivial changes required to add this
option, makes it worth the effort to support this.
Before:
```
‣ Running build script...
[1/418] Generating version.h with a custom command
Installing /root/build/po/be.gmo to /root/dest/usr/share/locale/be/LC_MESSAGES/systemd.mo
Installing /root/build/po/be@latin.gmo to /root/dest/usr/share/locale/be@latin/LC_MESSAGES/systemd.mo
Installing /root/build/po/bg.gmo to /root/dest/usr/share/locale/bg/LC_MESSAGES/systemd.mo
Installing /root/build/po/ca.gmo to /root/dest/usr/share/locale/ca/LC_MESSAGES/systemd.mo
Installing /root/build/po/cs.gmo to /root/dest/usr/share/locale/cs/LC_MESSAGES/systemd.mo
Installing /root/build/po/da.gmo to /root/dest/usr/share/locale/da/LC_MESSAGES/systemd.mo
Installing /root/build/po/de.gmo to /root/dest/usr/share/locale/de/LC_MESSAGES/systemd.mo
Installing /root/build/po/el.gmo to /root/dest/usr/share/locale/el/LC_MESSAGES/systemd.mo
Installing /root/build/po/es.gmo to /root/dest/usr/share/locale/es/LC_MESSAGES/systemd.mo
Installing /root/build/po/fr.gmo to /root/dest/usr/share/locale/fr/LC_MESSAGES/systemd.mo
Installing /root/build/po/gl.gmo to /root/dest/usr/share/locale/gl/LC_MESSAGES/systemd.mo
Installing /root/build/po/hr.gmo to /root/dest/usr/share/locale/hr/LC_MESSAGES/systemd.mo
Installing /root/build/po/hu.gmo to /root/dest/usr/share/locale/hu/LC_MESSAGES/systemd.mo
Installing /root/build/po/id.gmo to /root/dest/usr/share/locale/id/LC_MESSAGES/systemd.mo
Installing /root/build/po/it.gmo to /root/dest/usr/share/locale/it/LC_MESSAGES/systemd.mo
Installing /root/build/po/ja.gmo to /root/dest/usr/share/locale/ja/LC_MESSAGES/systemd.mo
Installing /root/build/po/ko.gmo to /root/dest/usr/share/locale/ko/LC_MESSAGES/systemd.mo
Installing /root/build/po/lt.gmo to /root/dest/usr/share/locale/lt/LC_MESSAGES/systemd.mo
Installing /root/build/po/pl.gmo to /root/dest/usr/share/locale/pl/LC_MESSAGES/systemd.mo
Installing /root/build/po/pt_BR.gmo to /root/dest/usr/share/locale/pt_BR/LC_MESSAGES/systemd.mo
Installing /root/build/po/ro.gmo to /root/dest/usr/share/locale/ro/LC_MESSAGES/systemd.mo
Installing /root/build/po/ru.gmo to /root/dest/usr/share/locale/ru/LC_MESSAGES/systemd.mo
Installing /root/build/po/sk.gmo to /root/dest/usr/share/locale/sk/LC_MESSAGES/systemd.mo
Installing /root/build/po/sr.gmo to /root/dest/usr/share/locale/sr/LC_MESSAGES/systemd.mo
Installing /root/build/po/sv.gmo to /root/dest/usr/share/locale/sv/LC_MESSAGES/systemd.mo
Installing /root/build/po/tr.gmo to /root/dest/usr/share/locale/tr/LC_MESSAGES/systemd.mo
Installing /root/build/po/uk.gmo to /root/dest/usr/share/locale/uk/LC_MESSAGES/systemd.mo
Installing /root/build/po/zh_CN.gmo to /root/dest/usr/share/locale/zh_CN/LC_MESSAGES/systemd.mo
Installing /root/build/po/zh_TW.gmo to /root/dest/usr/share/locale/zh_TW/LC_MESSAGES/systemd.mo
Installing /root/build/po/pa.gmo to /root/dest/usr/share/locale/pa/LC_MESSAGES/systemd.mo
real 0m1.467s
user 0m1.064s
sys 0m0.392s
```
After (with translations disabled):
```
‣ Running build script...
[1/418] Generating version.h with a custom command
real 0m0.925s
user 0m0.622s
sys 0m0.301s
```
Yu Watanabe [Sun, 10 Jan 2021 11:41:46 +0000 (20:41 +0900)]
Merge pull request #18178 from weblate/weblate-systemd-master
Translations update from Weblate
Luka Kudra [Sun, 10 Jan 2021 05:36:07 +0000 (06:36 +0100)]
network: register callback for dhcp server (#18146)
Setting dhcp_server_callback is needed in order to get an event when dhcp
leases change.
The callback was introduced by
38ee31a6e4ceb0381ed838340929aae2b5634c3e,
but never used.
Daan De Meyer [Sat, 9 Jan 2021 19:48:39 +0000 (20:48 +0100)]
meson: Optimize add-wants targets
Instead of invoking meson-add-wants.sh once for each wants that has
to be added, we pass all wants to a single invocation of
meson-add-wants.sh and in meson-add-wants.sh, loop over the
arguments.
This saves about 300ms on the install step.
Before:
```
‣ Running build script...
[1/418] Generating version.h with a custom command
Installing /root/build/po/be.gmo to /root/dest/usr/share/locale/be/LC_MESSAGES/systemd.mo
Installing /root/build/po/be@latin.gmo to /root/dest/usr/share/locale/be@latin/LC_MESSAGES/systemd.mo
Installing /root/build/po/bg.gmo to /root/dest/usr/share/locale/bg/LC_MESSAGES/systemd.mo
Installing /root/build/po/ca.gmo to /root/dest/usr/share/locale/ca/LC_MESSAGES/systemd.mo
Installing /root/build/po/cs.gmo to /root/dest/usr/share/locale/cs/LC_MESSAGES/systemd.mo
Installing /root/build/po/da.gmo to /root/dest/usr/share/locale/da/LC_MESSAGES/systemd.mo
Installing /root/build/po/de.gmo to /root/dest/usr/share/locale/de/LC_MESSAGES/systemd.mo
Installing /root/build/po/el.gmo to /root/dest/usr/share/locale/el/LC_MESSAGES/systemd.mo
Installing /root/build/po/es.gmo to /root/dest/usr/share/locale/es/LC_MESSAGES/systemd.mo
Installing /root/build/po/fr.gmo to /root/dest/usr/share/locale/fr/LC_MESSAGES/systemd.mo
Installing /root/build/po/gl.gmo to /root/dest/usr/share/locale/gl/LC_MESSAGES/systemd.mo
Installing /root/build/po/hr.gmo to /root/dest/usr/share/locale/hr/LC_MESSAGES/systemd.mo
Installing /root/build/po/hu.gmo to /root/dest/usr/share/locale/hu/LC_MESSAGES/systemd.mo
Installing /root/build/po/id.gmo to /root/dest/usr/share/locale/id/LC_MESSAGES/systemd.mo
Installing /root/build/po/it.gmo to /root/dest/usr/share/locale/it/LC_MESSAGES/systemd.mo
Installing /root/build/po/ja.gmo to /root/dest/usr/share/locale/ja/LC_MESSAGES/systemd.mo
Installing /root/build/po/ko.gmo to /root/dest/usr/share/locale/ko/LC_MESSAGES/systemd.mo
Installing /root/build/po/lt.gmo to /root/dest/usr/share/locale/lt/LC_MESSAGES/systemd.mo
Installing /root/build/po/pl.gmo to /root/dest/usr/share/locale/pl/LC_MESSAGES/systemd.mo
Installing /root/build/po/pt_BR.gmo to /root/dest/usr/share/locale/pt_BR/LC_MESSAGES/systemd.mo
Installing /root/build/po/ro.gmo to /root/dest/usr/share/locale/ro/LC_MESSAGES/systemd.mo
Installing /root/build/po/ru.gmo to /root/dest/usr/share/locale/ru/LC_MESSAGES/systemd.mo
Installing /root/build/po/sk.gmo to /root/dest/usr/share/locale/sk/LC_MESSAGES/systemd.mo
Installing /root/build/po/sr.gmo to /root/dest/usr/share/locale/sr/LC_MESSAGES/systemd.mo
Installing /root/build/po/sv.gmo to /root/dest/usr/share/locale/sv/LC_MESSAGES/systemd.mo
Installing /root/build/po/tr.gmo to /root/dest/usr/share/locale/tr/LC_MESSAGES/systemd.mo
Installing /root/build/po/uk.gmo to /root/dest/usr/share/locale/uk/LC_MESSAGES/systemd.mo
Installing /root/build/po/zh_CN.gmo to /root/dest/usr/share/locale/zh_CN/LC_MESSAGES/systemd.mo
Installing /root/build/po/zh_TW.gmo to /root/dest/usr/share/locale/zh_TW/LC_MESSAGES/systemd.mo
Installing /root/build/po/pa.gmo to /root/dest/usr/share/locale/pa/LC_MESSAGES/systemd.mo
real 0m1.465s
user 0m1.025s
sys 0m0.426s
```
After:
```
‣ Running build script...
[1/418] Generating version.h with a custom command
Installing /root/build/po/be.gmo to /root/dest/usr/share/locale/be/LC_MESSAGES/systemd.mo
Installing /root/build/po/be@latin.gmo to /root/dest/usr/share/locale/be@latin/LC_MESSAGES/systemd.mo
Installing /root/build/po/bg.gmo to /root/dest/usr/share/locale/bg/LC_MESSAGES/systemd.mo
Installing /root/build/po/ca.gmo to /root/dest/usr/share/locale/ca/LC_MESSAGES/systemd.mo
Installing /root/build/po/cs.gmo to /root/dest/usr/share/locale/cs/LC_MESSAGES/systemd.mo
Installing /root/build/po/da.gmo to /root/dest/usr/share/locale/da/LC_MESSAGES/systemd.mo
Installing /root/build/po/de.gmo to /root/dest/usr/share/locale/de/LC_MESSAGES/systemd.mo
Installing /root/build/po/el.gmo to /root/dest/usr/share/locale/el/LC_MESSAGES/systemd.mo
Installing /root/build/po/es.gmo to /root/dest/usr/share/locale/es/LC_MESSAGES/systemd.mo
Installing /root/build/po/fr.gmo to /root/dest/usr/share/locale/fr/LC_MESSAGES/systemd.mo
Installing /root/build/po/gl.gmo to /root/dest/usr/share/locale/gl/LC_MESSAGES/systemd.mo
Installing /root/build/po/hr.gmo to /root/dest/usr/share/locale/hr/LC_MESSAGES/systemd.mo
Installing /root/build/po/hu.gmo to /root/dest/usr/share/locale/hu/LC_MESSAGES/systemd.mo
Installing /root/build/po/id.gmo to /root/dest/usr/share/locale/id/LC_MESSAGES/systemd.mo
Installing /root/build/po/it.gmo to /root/dest/usr/share/locale/it/LC_MESSAGES/systemd.mo
Installing /root/build/po/ja.gmo to /root/dest/usr/share/locale/ja/LC_MESSAGES/systemd.mo
Installing /root/build/po/ko.gmo to /root/dest/usr/share/locale/ko/LC_MESSAGES/systemd.mo
Installing /root/build/po/lt.gmo to /root/dest/usr/share/locale/lt/LC_MESSAGES/systemd.mo
Installing /root/build/po/pl.gmo to /root/dest/usr/share/locale/pl/LC_MESSAGES/systemd.mo
Installing /root/build/po/pt_BR.gmo to /root/dest/usr/share/locale/pt_BR/LC_MESSAGES/systemd.mo
Installing /root/build/po/ro.gmo to /root/dest/usr/share/locale/ro/LC_MESSAGES/systemd.mo
Installing /root/build/po/ru.gmo to /root/dest/usr/share/locale/ru/LC_MESSAGES/systemd.mo
Installing /root/build/po/sk.gmo to /root/dest/usr/share/locale/sk/LC_MESSAGES/systemd.mo
Installing /root/build/po/sr.gmo to /root/dest/usr/share/locale/sr/LC_MESSAGES/systemd.mo
Installing /root/build/po/sv.gmo to /root/dest/usr/share/locale/sv/LC_MESSAGES/systemd.mo
Installing /root/build/po/tr.gmo to /root/dest/usr/share/locale/tr/LC_MESSAGES/systemd.mo
Installing /root/build/po/uk.gmo to /root/dest/usr/share/locale/uk/LC_MESSAGES/systemd.mo
Installing /root/build/po/zh_CN.gmo to /root/dest/usr/share/locale/zh_CN/LC_MESSAGES/systemd.mo
Installing /root/build/po/zh_TW.gmo to /root/dest/usr/share/locale/zh_TW/LC_MESSAGES/systemd.mo
Installing /root/build/po/pa.gmo to /root/dest/usr/share/locale/pa/LC_MESSAGES/systemd.mo
real 0m1.162s
user 0m0.803s
sys 0m0.338s
```
Lennart Poettering [Sat, 9 Jan 2021 20:52:56 +0000 (21:52 +0100)]
Merge pull request #18183 from poettering/arg-json-rework
--json= argument rework in various tools
Lennart Poettering [Sat, 9 Jan 2021 15:32:55 +0000 (16:32 +0100)]
test-xattr-util: don't insist that /usr supports xattrs
(apparently overlayfs has issues with xattrs, hence don't require that
/usr supports xattrs)
Daan De Meyer [Sat, 9 Jan 2021 17:27:56 +0000 (17:27 +0000)]
Merge pull request #18182 from DaanDeMeyer/mkosi-build-pushd
mkosi.build: Silence "Entering directory" message from ninja
Daan De Meyer [Sat, 9 Jan 2021 16:41:16 +0000 (17:41 +0100)]
mkosi.build: Only create groups if they don't exist yet
Daan De Meyer [Sat, 9 Jan 2021 16:32:00 +0000 (17:32 +0100)]
mkosi.build: Silence "Entering directory" message from ninja
When using `ninja -C "$BUILDDIR"`, ninja prints an annoying log
message about entering the directory that cannot be silenced. Let's
manually move in and out of the build directory instead.
Lennart Poettering [Sat, 9 Jan 2021 16:31:02 +0000 (17:31 +0100)]
busctl: port busctl to JSON_FORMAT_OFF too
This is a bit more complex, since busctl's JSON code predates json.c and
was only minimally updated sofar.
Lennart Poettering [Sat, 9 Jan 2021 16:08:53 +0000 (17:08 +0100)]
json: port various tools to the new JSON_FORMAT_OFF flag
These are the obvious cases.
Lennart Poettering [Sat, 9 Jan 2021 15:58:46 +0000 (16:58 +0100)]
json: add generic cmdline parser for --json= switch
Lennart Poettering [Sat, 9 Jan 2021 15:56:00 +0000 (16:56 +0100)]
json: add new json format flag for disabling JSON output
This adds a new flag JSON_FORMAT_OFF that is a marker for "no JSON
output please!".
Of course, this flag sounds pointless in a JSON implementation, however
this is useful in code that can generate JSON output, but also more
human friendly output (for example our table formatters).
With this in place various tools that so far maintained one boolean
field "arg_json" that controlled whether JSON output was requested at
all and another field "arg_json_format_flags" for selecing the precise
json output flags may merge them into one, simplifying code a bit.
Luca Boccassi [Fri, 8 Jan 2021 23:47:03 +0000 (23:47 +0000)]
bpf: zero bpf_attr before initialization
When building with Clang and using structured initialization, the
bpf_attr union is not zero-padded, so the kernel misdetects it as
an unsupported extension.
zero it until Clang's behaviour matches GCC. Do not skip the test
on Github Actions anymore.
Lennart Poettering [Sat, 9 Jan 2021 16:34:50 +0000 (17:34 +0100)]
Merge pull request #18179 from poettering/machine-image-tweaks
two simple tweaks to the machine-image.c logic
Lennart Poettering [Fri, 8 Jan 2021 15:57:02 +0000 (16:57 +0100)]
machine-image: pick up crtime of directory images, too
Lennart Poettering [Fri, 8 Jan 2021 15:56:37 +0000 (16:56 +0100)]
machine-image: use structured initialization
Ariel Fermani [Sat, 9 Jan 2021 03:20:01 +0000 (00:20 -0300)]
hwdb: Add HP ENVY x360 13 microphone mute key
It has the same code as the Spectre x360 13, but
is located at F8 button instead of F12.
Tested on a 13-ay0xxx model.
Yuri Chornoivan [Sat, 9 Jan 2021 10:51:31 +0000 (11:51 +0100)]
Translated using Weblate (Ukrainian)
Currently translated at 100.0% (189 of 189 strings)
Co-authored-by: Yuri Chornoivan <yurchor@ukr.net>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/uk/
Translation: systemd/master
Weblate [Sat, 9 Jan 2021 10:51:31 +0000 (11:51 +0100)]
Update translation files
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.
Co-authored-by: Weblate <noreply@weblate.org>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/
Translation: systemd/master
Arnaud T [Sat, 9 Jan 2021 10:51:31 +0000 (11:51 +0100)]
Translated using Weblate (French)
Currently translated at 100.0% (187 of 187 strings)
Co-authored-by: Arnaud T <listes.00@gmail.com>
Translate-URL: https://translate.fedoraproject.org/projects/systemd/master/fr/
Translation: systemd/master
Zach Smith [Fri, 8 Jan 2021 02:06:30 +0000 (18:06 -0800)]
systemd-sleep: Set SYSTEMD_SLEEP_ACTION for systemd-sleep hooks.
When suspend-then-hibernate is called, hooks have no ability to determine which
stage of the request is being handled; they only see 'pre' and 'post' with the
verb 'suspend-then-hibernate'. This change introduces an environment variable
called SYSTEMD_SLEEP_ACTION that contains the name of the action that is
processing: 'suspend', 'hibernate', 'hybrid-sleep', or
'suspend-after-failed-hibernate'.
Yu Watanabe [Sat, 9 Jan 2021 00:24:16 +0000 (09:24 +0900)]
Merge pull request #18137 from keszybz/deprecate-blanket-import-environment
Deprecate blanket import-environment
Zbigniew Jędrzejewski-Szmek [Fri, 8 Jan 2021 19:27:48 +0000 (20:27 +0100)]
meson: fix git ls-files invocations during rebase
Normally ls-files prints the full path to files from the repo root. But when
$GIT_WORK_TREE is set, ls-files prints paths relative to the current
directory. When rebasing, $GIT_WORK_TREE is set in the commands executed from
'rebase -x'. This causes problems if meson config is touched and the meson
reconfigures itself. ($GIT_WORK_TREE shouldn't be relevant, since the paths that
ls-files reports don't depend on the work tree, but whatever.) Let's unset
GIT_WORK_TREE to avoid the issue.
$ (cd test; git --git-dir=$PWD/../.git ls-files ':/test/dmidecode-dumps/*.bin')
test/dmidecode-dumps/HP-Z600.bin
test/dmidecode-dumps/Lenovo-ThinkPad-X280.bin
test/dmidecode-dumps/Lenovo-Thinkcentre-m720s.bin
$ (cd test; GIT_WORK_TREE=$PWD/.. git --git-dir=$PWD/../.git ls-files ':/test/dmidecode-dumps/*.bin')
dmidecode-dumps/HP-Z600.bin
dmidecode-dumps/Lenovo-ThinkPad-X280.bin
dmidecode-dumps/Lenovo-Thinkcentre-m720s.bin
Fixes #18148.
Yu Watanabe [Sat, 9 Jan 2021 00:21:54 +0000 (09:21 +0900)]
Merge pull request #18169 from OnkelUlla/can_bus_error_reporting
network: can: add support for bus error reporting
Yu Watanabe [Sat, 9 Jan 2021 00:21:19 +0000 (09:21 +0900)]
Merge pull request #18168 from yuwata/network-cleanups
network: several follow-ups for recently merged PRs
Luca Boccassi [Fri, 8 Jan 2021 21:50:37 +0000 (21:50 +0000)]
Merge pull request #18172 from dmedri/master
po: minor fixes and updates
Ulrich Ölmann [Tue, 5 Jan 2021 17:53:44 +0000 (18:53 +0100)]
network: can: add support for bus error reporting
Enhance systemd-networkd to be able to control a CAN device's berr-reporting
flag via the new boolean directive BusErrorReporting= to be used in network
files.
Ulrich Ölmann [Fri, 8 Jan 2021 17:12:36 +0000 (18:12 +0100)]
network: can: pretty up debug messages
Do not construct the english words "Enabling"/"Disabling" but use one of the
smart helper functions here.
Zbigniew Jędrzejewski-Szmek [Tue, 5 Jan 2021 11:34:28 +0000 (12:34 +0100)]
shell-completion: fix systemctl set/unset/import-environment
unset-environment is completed with variable names in the environment block.
set-environment the same, but suffixed with "=".
import-environment is completed with variable names in the client environment.
Zbigniew Jędrzejewski-Szmek [Tue, 5 Jan 2021 10:24:03 +0000 (11:24 +0100)]
systemctl: deprecate blanket import-environment
Importing the full environment is convenient, but it doesn't work too well in
practice, because we get a metric ton of shell-specific crap that should never
end up in the global environment block:
$ systemctl --user show-environment
...
SHELL=/bin/zsh
AUTOJUMP_ERROR_PATH=/home/zbyszek/.local/share/autojump/errors.log
AUTOJUMP_SOURCED=1
CONDA_SHLVL=0
CVS_RSH=ssh
DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1000/bus
DESKTOP_SESSION=gnome
DISPLAY=:0
FPATH=/usr/share/Modules/init/zsh-functions:/usr/local/share/zsh/site-functions:/usr/share/zsh/site-functions:/usr/share/zsh/5.8/functions
GDMSESSION=gnome
GDM_LANG=en_US.UTF-8
GNOME_SETUP_DISPLAY=:1
GUESTFISH_INIT=$'\\e[1;34m'
GUESTFISH_OUTPUT=$'\\e[0m'
GUESTFISH_PS1=$'\\[\\e[1;32m\\]><fs>\\[\\e[0;31m\\] '
GUESTFISH_RESTORE=$'\\e[0m'
HISTCONTROL=ignoredups
HISTSIZE=1000
LOADEDMODULES=
OLDPWD=/home/zbyszek
PWD=/home/zbyszek
QTDIR=/usr/lib64/qt-3.3
QTINC=/usr/lib64/qt-3.3/include
QTLIB=/usr/lib64/qt-3.3/lib
QT_IM_MODULE=ibus
SDL_VIDEO_MINIMIZE_ON_FOCUS_LOSS=0
SESSION_MANAGER=local/unix:@/tmp/.ICE-unix/2612,unix/unix:/tmp/.ICE-unix/2612
SHLVL=0
STEAM_FRAME_FORCE_CLOSE=1
TERM=xterm-256color
USERNAME=zbyszek
WISECONFIGDIR=/usr/share/wise2/
...
Plenty of shell-specific and terminal-specific stuff that have no global
significance.
Let's start warning when this is used to push people towards importing only
specific variables.
Putative NEWS entry:
* systemctl import-environment will now emit a warning when called without
any arguments (i.e. to import the full environment block of the called
program). This command will usually be invoked from a shell, which means
that it'll inherit a bunch of variables which are specific to that shell,
and usually to the tty the shell is connected to, and don't have any
meaning in the global context of the system or user service manager.
Instead, only specific variables should be imported into the manager
environment block.
Similarly, programs which update the manager environment block by directly
calling the D-Bus API of the manager, should also push specific variables,
and not the full inherited environment.
Zbigniew Jędrzejewski-Szmek [Tue, 5 Jan 2021 10:17:14 +0000 (11:17 +0100)]
man: improve description of environment block creation
This adds a general description of "philosphy" of keeping the environemnt
block small and hints about systemd-run -P env.
The list of generated variables is split out to a subsection. Viewing
the patch with ignoring whitespace changes is recommended.
We don't ignore invalid assignments (except in import-environment to some
extent), previous description was wrong.
For https://bugzilla.redhat.com/show_bug.cgi?id=
1912046#c17.
Luca Boccassi [Fri, 8 Jan 2021 18:11:55 +0000 (18:11 +0000)]
Merge pull request #18128 from mrc0mmand/coverity
ci: move jobs from Travis CI to GitHub Actions
Yu Watanabe [Tue, 5 Jan 2021 06:27:11 +0000 (15:27 +0900)]
resolve: fix use after free in DnsAnswer
This fixes a bug introduced by
ae45e1a3832fbb6c96707687e42f0b4aaab52c9b.
The set DnsAnswer::set_items contains the reference to the array in
DnsAnswer. So, the set must be reconstructed when we realloc() the
object.
Fixes #18132.
Ulrich Ölmann [Fri, 8 Jan 2021 17:39:42 +0000 (18:39 +0100)]
network: can: simplify usage of booleans
Harmonize with what is done for TripleSampling, Termination & ListenOnly.
Daniele Medri [Fri, 8 Jan 2021 16:59:36 +0000 (17:59 +0100)]
po: systemd.pot updated
Daniele Medri [Fri, 8 Jan 2021 16:58:51 +0000 (17:58 +0100)]
po: italian minor fix and updates
Yu Watanabe [Fri, 8 Jan 2021 15:05:41 +0000 (00:05 +0900)]
network: refuse to set 0 for rx or tx queue
Man page says that the valid value is 1-4096.
Yu Watanabe [Fri, 8 Jan 2021 15:01:53 +0000 (00:01 +0900)]
test-network: add tests for route advmss
Yu Watanabe [Fri, 8 Jan 2021 14:56:13 +0000 (23:56 +0900)]
network: read RTAX_ADVMSS in received route message
Yu Watanabe [Fri, 8 Jan 2021 14:25:20 +0000 (23:25 +0900)]
network: add missing TAKE_PTR()
Yu Watanabe [Mon, 4 Jan 2021 18:07:23 +0000 (03:07 +0900)]
udev/cdrom: split main() into main() and run()
However, we do not use DEFINE_MAIN_FUNCTION() here, as ubuntu s390x CI
does not like it...
Yu Watanabe [Mon, 28 Dec 2020 06:30:16 +0000 (15:30 +0900)]
udev/cdrom: drop unnecessary headers
Yu Watanabe [Mon, 28 Dec 2020 07:41:34 +0000 (16:41 +0900)]
udev/cdrom: drop never hit condition
Yu Watanabe [Mon, 28 Dec 2020 06:45:54 +0000 (15:45 +0900)]
udev/cdrom: void()ify several function calls
Yu Watanabe [Mon, 28 Dec 2020 06:43:42 +0000 (15:43 +0900)]
udev/cdrom: tighten variable scope used in loop
Yu Watanabe [Mon, 28 Dec 2020 06:25:19 +0000 (15:25 +0900)]
udev/cdrom: use unaligned_read_be32() or friends
Yu Watanabe [Thu, 24 Dec 2020 18:29:13 +0000 (03:29 +0900)]
udev/cdrom: split cd_media_info() into small pieces
Yu Watanabe [Thu, 24 Dec 2020 17:57:37 +0000 (02:57 +0900)]
udev/cdrom: introduce enum for media state
Yu Watanabe [Thu, 24 Dec 2020 16:00:17 +0000 (01:00 +0900)]
udev/cdrom: move media status to Context
Yu Watanabe [Thu, 24 Dec 2020 09:33:54 +0000 (18:33 +0900)]
udev/cdrom: introduce enum for media and drive feature
Yu Watanabe [Thu, 24 Dec 2020 15:11:07 +0000 (00:11 +0900)]
udev/cdrom: introduce Context
Yu Watanabe [Thu, 24 Dec 2020 08:24:29 +0000 (17:24 +0900)]
udev/cdrom: make cd_profiles() return positive value if drive has media
Yu Watanabe [Thu, 24 Dec 2020 08:06:50 +0000 (17:06 +0900)]
udev/cdrom: make media_lock() return negative errno
Yu Watanabe [Thu, 24 Dec 2020 08:06:00 +0000 (17:06 +0900)]
udev/cdrom: introduce scsi_cmd_run_and_log()
Yu Watanabe [Thu, 24 Dec 2020 06:22:12 +0000 (15:22 +0900)]
udev/cdrom: use random_u64() and usleep()
Yu Watanabe [Thu, 24 Dec 2020 05:59:30 +0000 (14:59 +0900)]
udev/cdrom: split out parse_argv() and help()
Susant Sahani [Thu, 7 Jan 2021 15:17:17 +0000 (16:17 +0100)]
network: route - add support to configure tcp advmss
hadess [Fri, 8 Jan 2021 10:52:17 +0000 (11:52 +0100)]
Merge pull request #18156 from BjoernDaase/patch-3
hwdb: Force no "mouse" type on Logitech MX Keys
Frantisek Sumsal [Fri, 8 Jan 2021 10:20:50 +0000 (11:20 +0100)]
test: temporarily skip failing tests on GH Actions
Frantisek Sumsal [Tue, 5 Jan 2021 10:52:46 +0000 (11:52 +0100)]
ci: move Travis CI unit test jobs to GH Actions
Björn Daase [Thu, 7 Jan 2021 08:14:16 +0000 (09:14 +0100)]
hwdb: Force no "mouse" type on Logitech MX Keys
Fixes https://gitlab.freedesktop.org/upower/upower/-/issues/128
Björn Daase [Fri, 8 Jan 2021 09:32:36 +0000 (10:32 +0100)]
hwdb: Relax parsing script to allow 0 and 1 for all ID_* properties
AJ Jordan [Mon, 14 Dec 2020 23:35:43 +0000 (15:35 -0800)]
man: clarify that coredumps are gc'd after 3 days
Jan Tojnar [Sat, 2 Jan 2021 01:46:33 +0000 (02:46 +0100)]
pkg-config: make prefix overridable again
While we don't support prefix being != /usr, and this is hardcoded
all over the place, variables in pkg-config file are expected
to have overridable base directory.
This is important for at least the following two use cases:
- Installing projects to non-FHS package-specific prefixes for Nix-style
package managers. Of course, it is then their responsibility
to ensure systemd can find the service files.
- Installing to local path for development purposes.
This is a compromise between running a program from a build directory,
and running it fully installed to system prefix.
You will not want to write to system prefix in either case.
For more information, see also
https://www.bassi.io/articles/2018/03/15/pkg-config-and-paths/
Fixes https://github.com/systemd/systemd/issues/18082
Partially reverts
6e65df89c348242dbd10036abc7dd5e8181cf733
Evgeny Vereshchagin [Wed, 6 Jan 2021 11:50:09 +0000 (11:50 +0000)]
ci: turn off Azure Pipelines
Daan De Meyer [Wed, 6 Jan 2021 17:41:44 +0000 (18:41 +0100)]
mkosi: Enable InstallDirectory and SourceFileTransferFinal options
- InstallDirectory caches the install part of the build process
which speeds up incremental builds a little and allows inspecting
the installed components in mkosi.installdir.
- SourceFileTransferFinal copies the source files to the final
image which makes the gdb experience in qemu/systemd-nspawn a bit
nicer as it can now find the source files and show the source code
in the gdb cli itself.
Lennart Poettering [Wed, 6 Jan 2021 17:05:56 +0000 (18:05 +0100)]
stat-util: don't try to open path on path_is_temporary_fs()
I mean, the old code at least used O_PATH, but still, we shouldn't
allocate/close an fd if we don't have to.
Lennart Poettering [Wed, 6 Jan 2021 19:02:54 +0000 (20:02 +0100)]
Merge pull request #18044 from weblate/weblate-systemd-master
Translations update from Weblate
Daan De Meyer [Sat, 26 Dec 2020 14:27:55 +0000 (15:27 +0100)]
networkd: Enable IPv6SendRA on builtin network files
RAs trigger neighbor discovery which allows users to query the
LL address of the container/VM via `ip neighbor get dev`. This is
useful as it gives users an easy way to connect to the container
without needing LLMNR or mDNS to resolve the hostname of the container
to an IP address. In practice, this allows connecting with only
networkd enabled and without resolved running in the host/container.
Lennart Poettering [Wed, 6 Jan 2021 18:55:29 +0000 (19:55 +0100)]
Merge pull request #18150 from poettering/strextend-tweak
tree-wide: beef up strextend() a bit
Luca Boccassi [Tue, 5 Jan 2021 13:44:26 +0000 (13:44 +0000)]
systemctl: have is-enabled return success for aliases when calling into pid1 too
commit
15d7ab87c4e5917f5788f1f8dce327a1e272bea3 introduced the
change to add an 'alias' state, but it was wired to systemctl
only when running in 'client-side' mode. Return success as
expected and documented also when running in 'server-mode'.
Fixes https://github.com/systemd/systemd/issues/18134
Lennart Poettering [Wed, 6 Jan 2021 16:23:38 +0000 (17:23 +0100)]
string-util: use GREEDY_ALLOC_ROUND_UP() in strextend()
This uses GREEDY_ALLOC_ROUND_UP() to grow the allocation size
exponentially. This should speed allocation loops up a bit, given
that we often call strextend() repeatedly in a loop on the same
buffer.
Lennart Poettering [Tue, 5 Jan 2021 14:03:41 +0000 (15:03 +0100)]
string-util: imply NULL termination of strextend() argument list
The trailing NULL in the argument list is now implied (similar to
what we already have in place in strjoin()).