Daan De Meyer [Sun, 2 Oct 2022 08:51:53 +0000 (10:51 +0200)]
repart: Don't fail on missing verity sig partition
Also, provide a proper error message when we fail to find a verity
sibling partition.
Frantisek Sumsal [Sat, 1 Oct 2022 19:56:08 +0000 (21:56 +0200)]
test: expand the expression in `cleanup_initdir()`
Otherwise we might unexpectedly return 1 if the `get_bool` call fails.
If the `get_bool` part in `get_bool "$TEST_SETUP_CLEANUP_ROOTDIR" && _umount_dir "${initdir:?}"`
fails, the whole expression will short-circuit evaluate to 1, and since it's
the last expression in the function it's also it's return value, which doesn't
reflect the original intent of the expression:
```
# BUILD_DIR=$PWD/build make -C test/TEST-64-UDEV-STORAGE/ setup run TESTCASES=testcase_always_skip
make: Entering directory '/home/fsumsal/repos/@systemd/systemd/test/TEST-64-UDEV-STORAGE'
TEST-64-UDEV-STORAGE SETUP: systemd-udev storage tests
Reusing existing image /var/tmp/systemd-test.uPbJZ9/default.img → /var/tmp/systemd-test.uPbJZ9/default.img
TEST-64-UDEV-STORAGE RUN: systemd-udev storage tests
------ testcase_always_skip: BEGIN ------
Skipping...
------ testcase_always_skip: END (SKIP) ------
Passed tests: 0
*
Skipped tests: 1
* testcase_always_skip
Failed tests: 0
*
TEST-64-UDEV-STORAGE RUN: systemd-udev storage tests [OK]
make: Leaving directory '/home/fsumsal/repos/@systemd/systemd/test/TEST-64-UDEV-STORAGE'
# BUILD_DIR=$PWD/build make -C test/TEST-64-UDEV-STORAGE/ setup run TESTCASES=testcase_always_skip
make: Entering directory '/home/fsumsal/repos/@systemd/systemd/test/TEST-64-UDEV-STORAGE'
TEST-64-UDEV-STORAGE SETUP: systemd-udev storage tests
Reusing existing image /var/tmp/systemd-test.uPbJZ9/default.img → /var/tmp/systemd-test.uPbJZ9/default.img
make: *** [Makefile:4: setup] Error 1
make: Leaving directory '/home/fsumsal/repos/@systemd/systemd/test/TEST-64-UDEV-STORAGE'
```
Frantisek Sumsal [Sat, 1 Oct 2022 18:56:01 +0000 (20:56 +0200)]
test: drop the explicit bus assignment for the pci-bridge
as it doesn't work with the Q35 chipset due to a different topology.
Auto-assignment seems to work with both Q35 and i440FX chipsets.
Luca Boccassi [Sat, 1 Oct 2022 18:30:21 +0000 (19:30 +0100)]
Merge pull request #24878 from keszybz/condition-first-boot
Tweak condition first boot to use the same logic in pid1 and units
Maxim Mikityanskiy [Sat, 1 Oct 2022 11:28:44 +0000 (14:28 +0300)]
hwdb: Add Fn+F12 on HP Dragonfly G2 and mute extra rfkill keys
Add new key mappings for the HP Elite Dragonfly G2 laptop:
1. Map Fn+F12 (HP Programmable Key) to prog1.
2. Unmap Fn+F11 (Airplane mode) from atkbd and Intel HID events, as this
key is also reported by HP Wireless hotkeys.
Clyde Byrd III [Tue, 8 Mar 2022 23:26:33 +0000 (15:26 -0800)]
man: Update systemd.killMode docs
dependabot[bot] [Sat, 1 Oct 2022 11:01:11 +0000 (11:01 +0000)]
build(deps): bump ninja from 1.10.2.3 to 1.10.2.4 in /.github/workflows
Bumps [ninja](https://github.com/ninja-build/ninja) from 1.10.2.3 to 1.10.2.4.
- [Release notes](https://github.com/ninja-build/ninja/releases)
- [Commits](https://github.com/ninja-build/ninja/commits)
---
updated-dependencies:
- dependency-name: ninja
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Frantisek Sumsal [Sat, 1 Oct 2022 11:09:28 +0000 (13:09 +0200)]
ci: pin stefanbuck/github-issue-parser to a tagged release
Since [0] got resolved ([1]) we can finally pin the action to a tagged
release (v2.0.4 ATTOW) and let Dependabot to do its job by updating it
to the latest tagged release when it becomes available.
Replaces: #24886
[0] https://github.com/stefanbuck/github-issue-parser/issues/23
[1] https://github.com/stefanbuck/github-issue-parser/pull/39
dependabot[bot] [Sat, 1 Oct 2022 09:02:58 +0000 (09:02 +0000)]
build(deps): bump actions/labeler from 4.0.0 to 4.0.1
Bumps [actions/labeler](https://github.com/actions/labeler) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/actions/labeler/releases)
- [Commits](https://github.com/actions/labeler/compare/
9fd24f1f9d6ceb64ba34d181b329ee72f99978a0...
e54e5b338fbd6e6cdb5d60f51c22335fc57c401e)
---
updated-dependencies:
- dependency-name: actions/labeler
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
dependabot[bot] [Sat, 1 Oct 2022 09:03:02 +0000 (09:03 +0000)]
build(deps): bump redhat-plumbers-in-action/differential-shellcheck
Bumps [redhat-plumbers-in-action/differential-shellcheck](https://github.com/redhat-plumbers-in-action/differential-shellcheck) from 3.0.1 to 3.1.1.
- [Release notes](https://github.com/redhat-plumbers-in-action/differential-shellcheck/releases)
- [Changelog](https://github.com/redhat-plumbers-in-action/differential-shellcheck/blob/main/CHANGELOG.md)
- [Commits](https://github.com/redhat-plumbers-in-action/differential-shellcheck/compare/
a14889568f6210b361eb29e16f3b07f512fca846...
1b1b75e42f0694c1012228513b21617a748c866e)
---
updated-dependencies:
- dependency-name: redhat-plumbers-in-action/differential-shellcheck
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
dependabot[bot] [Sat, 1 Oct 2022 09:03:12 +0000 (09:03 +0000)]
build(deps): bump meson from 0.63.1 to 0.63.2 in /.github/workflows
Bumps [meson](https://github.com/mesonbuild/meson) from 0.63.1 to 0.63.2.
- [Release notes](https://github.com/mesonbuild/meson/releases)
- [Commits](https://github.com/mesonbuild/meson/compare/0.63.1...0.63.2)
---
updated-dependencies:
- dependency-name: meson
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Zbigniew Jędrzejewski-Szmek [Fri, 30 Sep 2022 13:31:40 +0000 (15:31 +0200)]
man: add cross-links about preset operations
Zbigniew Jędrzejewski-Szmek [Fri, 30 Sep 2022 10:50:40 +0000 (12:50 +0200)]
manager: fix/change evaluation of ConditionFirstBoot
The code to evaluate the kernel command line option was busted because it
was doing 'return b == !!r' at a point where 'r > 0'. Thus we'd return "true"
in both cases:
$ SYSTEMD_PROC_CMDLINE=systemd.condition-first-boot build/systemd-analyze condition 'ConditionFirstBoot=true'
test.service: ConditionFirstBoot=true succeeded.
Conditions succeeded.
$ SYSTEMD_PROC_CMDLINE=systemd.condition-first-boot build/systemd-analyze condition 'ConditionFirstBoot=false'
test.service: ConditionFirstBoot=false succeeded.
Conditions succeeded.
We only use 'ConditionFirstBoot=true' in units, so this wasn't noticed.
But I think the logic is broken in general: the condition should evaluate as
true only during initial boot. If we rerun the units at later points, we should
not consider ConditionFirstBoot to be true.
Also, the first boot logic is also used in pid1 itself. AFAICT, for two
things: in first boot machine-id is initialized transiently (this allows
first-boot operations to be restarted if boot fails), and preset-all is
executed. But this logic was different and separate from the logic to
evaluate ConditionFirstBoot. The distinction is abolished, and the operations
in pid1 now use the same logic as ConditionFirstBoot, which means that the
kernel command line option is checked, and condition_test_first_boot()
just tests whether pid1 thinks we're in first boot.
This makes things easier to grok for the user: there's just one condition for
"first boot" and it applies to both pid1 and units.
Zbigniew Jędrzejewski-Szmek [Fri, 30 Sep 2022 15:26:34 +0000 (17:26 +0200)]
docs/CONTRIBUTING: strenghten language about ABI stability, fix links, other tweaks
The text made it sound like breaking ABI in libsystemd is allowed with good reasons.
In fact, we plan never to do this, so make the language stronger.
Also remind people about distro forums for reporting bugs. Those are probably a
better place than systemd-devel for new users.
Also, add some missing articles and apostrophes, fix URLs, remove repeated phrases,
etc.
James Hilliard [Fri, 30 Sep 2022 21:42:22 +0000 (15:42 -0600)]
Revert "bpf: fix is_allow_list section"
GCC was modified to use the same default section as LLVM, as such
this is no longer required.
Details:
https://github.com/gcc-mirror/gcc/commit/
a0aafbc324aa90421f0ce99c6f5bbf64ed163da6
This reverts commit
e8b1e9cf1095f9d6d0f1e2dce2503e25fec2e6c5.
James Hilliard [Sat, 1 Oct 2022 00:09:53 +0000 (00:09 +0000)]
meson: set minimum libbpf/bpftool versions for bpf-gcc
We need the following libbpf commits for bpf-gcc compatibility:
- https://github.com/libbpf/libbpf/commit/
3d484ca47339b23afb2ec7c508ed9a3a5cf1d287
- https://github.com/libbpf/libbpf/commit/
b31ca3fa0e62fde6aa66f855136e29e088ad9dde
These are first present in libbpf 1.0.0 and bpftool 7.0.0.
Luca Boccassi [Fri, 30 Sep 2022 19:07:49 +0000 (20:07 +0100)]
Merge pull request #24829 from yuwata/blockdev-new-from-fd
blockdev-util: introduce block_device_new_from_fd() and _path()
Luca Boccassi [Fri, 30 Sep 2022 19:02:19 +0000 (20:02 +0100)]
Merge pull request #24749 from yuwata/dissect-image-file
dissect-image: introduce dissect_image_file() which works for regular file instead of block device
Jacek Migacz [Wed, 21 Sep 2022 06:23:22 +0000 (08:23 +0200)]
resolve: unsupported DNSSEC algorithms are considered INSECURE; not BOGUS
Resolves: #19824
Zbigniew Jędrzejewski-Szmek [Fri, 30 Sep 2022 15:34:21 +0000 (17:34 +0200)]
Merge pull request #24639 from yuwata/test-mountpoint-util
test-mountpoint-util: support running on a mount namespace with another mount on /proc
Luca Boccassi [Fri, 30 Sep 2022 14:46:13 +0000 (15:46 +0100)]
Merge pull request #24853 from poettering/resolved-monitor-fixes
resolved: various monitor fixes
Luca Boccassi [Fri, 30 Sep 2022 14:42:15 +0000 (15:42 +0100)]
Merge pull request #24739 from keszybz/coredump-formatting
Improve formatting of package metadata in coredumps
Zbigniew Jędrzejewski-Szmek [Fri, 30 Sep 2022 09:48:12 +0000 (11:48 +0200)]
firstboot: add debug logging
$ SYSTEMD_LOG_LEVEL=debug build/systemd-firstboot --prompt-root-password
Found container virtualization systemd-nspawn.
Found /etc/locale.conf, assuming locale information has been configured.
Failed to read credential firstboot.keymap, ignoring: No such device or address
Prompting for keymap was not requested.
Found /etc/localtime, assuming timezone has been configured.
Prompting for hostname was not requested.
Found /etc/machine-id, assuming machine-id has been configured.
Found /etc/passwd and /etc/shadow, assuming root account has been initialized.
Creation of /etc/kernel/cmdline was not requested, skipping.
Christian Hesse [Fri, 30 Sep 2022 08:26:43 +0000 (10:26 +0200)]
systemctl: color ignored exit status in yellow, not red
If the executable path is prefixed with "-", an exit code of the command
normally considered a failure (i.e. non-zero exit status or abnormal exit
due to signal) is recorded, but has no further effect and is considered
equivalent to success.
Let's honor this with `systemctl status`, and color ignored exit status
in yellow, not red.
Jonas Kümmerlin [Thu, 29 Sep 2022 16:51:03 +0000 (18:51 +0200)]
generator: skip fsck if fsck command is missing
This is useful for systems which don't have any fsck.
We already skip emitting the fsck dependency when the fsck.$fstype helper
is missing, but fstab-generator doesn't necessarily know the fstype when
handling the root= parameter.
Previously, systemd-fsck was started for these mounts and then exited
immediately because it couldn't find the fsck.$fstype helper.
Luca Boccassi [Thu, 29 Sep 2022 21:41:55 +0000 (22:41 +0100)]
portablectl: add --force attach/detach
Allows to skip check that ensures units must not be running.
I have a use case that would use reattach, except the orchestrator
is using a non-standard versioning scheme, so image matching cannot
work. As a workaround, need to be able to detach and then attach
manually, without stopping the units to avoid extended downtimes
and loss of FD store.
Lennart Poettering [Fri, 30 Sep 2022 12:14:33 +0000 (14:14 +0200)]
update TODO
Lennart Poettering [Fri, 30 Sep 2022 08:04:37 +0000 (10:04 +0200)]
test: rework resolved monitoring test
Let's remove some sleep loops, and instead:
1. Use Type=notify to wait until "resolvectl monitor" successfully
installed its monitor, so that we know that queries enqueued later
will definitely be seen.
2. Use "grep -m1" to watch "journalctl -f" output to wait precisely for
the RR data we want to see, and immediately exit.
This shortens code quite a bit, and should make it more robust.
Lennart Poettering [Wed, 28 Sep 2022 10:46:21 +0000 (12:46 +0200)]
resolvectl: add new "monitor" verb
Franck Bui [Fri, 30 Sep 2022 12:23:59 +0000 (14:23 +0200)]
Merge pull request #24831 from poettering/dbus-dump-doc
man: clarify that D-Bus Dump() call is a debugging interface with no guarantees
Lennart Poettering [Wed, 28 Sep 2022 10:46:09 +0000 (12:46 +0200)]
resolved: beef up monitor protocol, include full query info
Lennart Poettering [Thu, 29 Sep 2022 16:26:44 +0000 (18:26 +0200)]
resolved: add dns_question_merge() helper
Very similar to dns_answer_merge(), but for DnsQuestion objects instead
of DnsAnswer.
Lennart Poettering [Wed, 28 Sep 2022 15:17:23 +0000 (17:17 +0200)]
resolved: add generic formatters for RRs into JSON
For now we can use it to send broken-down records of JSON via the
monitor logic, but one day we can certainly reuse for dumping the
caches, or to implement a ResolveRecord() varlink call one day.
Lennart Poettering [Wed, 28 Sep 2022 10:44:43 +0000 (12:44 +0200)]
resolved: split out helper for allocating DnsResourceRecord object from raw data
No change in behaviour, just some refactoring.
Lennart Poettering [Tue, 27 Sep 2022 12:50:53 +0000 (14:50 +0200)]
resolved: split out main server listening code from manager_varlink_init()
Just some minor refactoring, to make binding the two sockets (main +
minitor) symmetric
Lennart Poettering [Tue, 27 Sep 2022 12:29:18 +0000 (14:29 +0200)]
resolved: don't make monitoring optional
The socket is only accessible to privileged clients anyway, no need to
add another (user unfriendly) restriction via opt-in setting. let's just
allow this for privileged clients, mirroring "busctl monitor", or
"tcpdump" and similar, which all just work if you have privs.
(This does not break API, since we never did a release witht the
"Monitor" dbus property or config setting in place, i.e. with
cb456374e096f0ebe9b70d7ddd98e16a4be24ee6)
Lennart Poettering [Tue, 27 Sep 2022 12:28:32 +0000 (14:28 +0200)]
resolved: rename 'notification' → 'monitor'
We expose this externally already as "monitor", name it internally the
same way. (Which is nice since it mirrors busctl monitor)
Lennart Poettering [Wed, 28 Sep 2022 09:42:05 +0000 (11:42 +0200)]
sd-event: add helper for exiting event loop on SIGTERM/SIGINT
In many (most?) of our event loops we want to exit once SIGTERM/SIGINT
is seen. Add a common helper for that, that does the right things in a
single call.
Lennart Poettering [Wed, 28 Sep 2022 09:39:25 +0000 (11:39 +0200)]
sd-event: if signal nr has high bit set sd_event_add_signal() auto-block it via sigprocmask()
So far we expected callers to block the signals manually. Which is
usually a good idea, since they should do that before forking off
threads and similar. But let's add a mode where we automatically block
it for the caller, to simplify things.
Lennart Poettering [Fri, 30 Sep 2022 12:09:54 +0000 (14:09 +0200)]
json: explicitly support offsets relative to NULL when dispatching
Let's trick out UndefinedBehaviourSanitizer:
https://github.com/systemd/systemd/pull/24853#issuecomment-
1263380745
Lennart Poettering [Wed, 28 Sep 2022 15:13:00 +0000 (17:13 +0200)]
json: add helper for json builder for octescape/base32hex
These encodings for binary data are mandated by DNS RFCs, so let's give
make them nice and easy to use with json builder logic.
Lennart Poettering [Wed, 28 Sep 2022 09:35:47 +0000 (11:35 +0200)]
json: add dispatchers for 16bit integers
Lennart Poettering [Wed, 28 Sep 2022 09:34:46 +0000 (11:34 +0200)]
glyph-util: add left arrow special glyph entry
Yu Watanabe [Thu, 29 Sep 2022 07:50:27 +0000 (16:50 +0900)]
resolve: do not cache mDNS goodbye packet
Fixes #24842.
Yu Watanabe [Fri, 30 Sep 2022 09:50:31 +0000 (18:50 +0900)]
Merge pull request #24820 from keszybz/tmpfiles-warning
Downgrade warning about unitialized-/etc in tmpfiles
Frantisek Sumsal [Fri, 30 Sep 2022 07:31:47 +0000 (09:31 +0200)]
test: wait until the unit finishes before checking the log
Otherwise we might read an incomplete log and fail:
```
test_added_after (__main__.ExecutionResumeTest) ... FAIL
test_added_before (__main__.ExecutionResumeTest) ... ok
test_interleaved (__main__.ExecutionResumeTest) ... ok
test_issue_6533 (__main__.ExecutionResumeTest) ... ok
test_no_change (__main__.ExecutionResumeTest) ... ok
test_removal (__main__.ExecutionResumeTest) ... ok
test_swapped (__main__.ExecutionResumeTest) ... ok
======================================================================
FAIL: test_added_after (__main__.ExecutionResumeTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/build/./test/test-exec-deserialization.py", line 152, in test_added_after
self.check_output(expected_output)
File "/build/./test/test-exec-deserialization.py", line 107, in check_output
self.assertEqual(output, expected_output)
AssertionError: 'foo\n' != 'foo\nbar\n'
foo
+ bar
----------------------------------------------------------------------
Ran 7 tests in 27.470s
```
Frantisek Sumsal [Fri, 30 Sep 2022 06:48:53 +0000 (08:48 +0200)]
test: kill the machine on oops/panic/soft_lockup
Otherwise the machine will hang on the panic until the timeout happens,
which might waste quite a considerable amount of time in certain cases.
Lennart Poettering [Tue, 27 Sep 2022 10:18:47 +0000 (12:18 +0200)]
manager: make clear internal Dump() logic is debugging only.
Lennart Poettering [Tue, 27 Sep 2022 10:18:43 +0000 (12:18 +0200)]
man: document the Dump() calls of the PID 1 D-Bus interface, and what they are
Adam Williamson [Thu, 29 Sep 2022 19:58:03 +0000 (12:58 -0700)]
kbd-model-map: correct variants for cz-qwerty to include comma
As explained by @poncovka , the 'xvariant' string should contain
the same number of comma-separated elements as 'xlayout'. When
we have two layouts we need two items in xvariant, in this case
one of them is empty.
See https://github.com/rhinstaller/anaconda/pull/4355#pullrequestreview-
1119913870
for @poncovka's full explanation.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
Frantisek Sumsal [Thu, 29 Sep 2022 22:01:48 +0000 (00:01 +0200)]
Merge pull request #24865 from yuwata/udevadm-tweaks
udevadm: fix misleading error message
JeroenHD [Thu, 29 Sep 2022 20:23:42 +0000 (22:23 +0200)]
Add special keyboard combos for Thinkpad P1 Gen 3 (#24862)
* Add special keyboard combos for Thinkpad P1 Gen 3
These are based on the key codes I've found with evtest. See issue
https://github.com/systemd/systemd/issues/24814 for more details.
I'm not entirely sure what some of these keys are supposed to do,
notably Fn+RShift; this doesn't seem to do anything in Windows on
my machine. Binding them to prog# makes them available to desktop
managers' key bindings at least, in case someone wishes to make
use of this extra keybind possibility.
Yu Watanabe [Thu, 29 Sep 2022 17:38:22 +0000 (02:38 +0900)]
test-64-udev-storage: use wait command instead of hackish "udevadm lock true"
Otherwise, "udevadm lock true" may lock a block device earlier than
"udevadm lock sfdisk &".
Yu Watanabe [Thu, 29 Sep 2022 17:03:32 +0000 (02:03 +0900)]
udevadm: do not try to find device unit when a path like string is provided
Otherwise, we provide misleading error message.
Before:
---
$ udevadm info /sys/class/foo
Bad argument "/sys/class/foo", expected an absolute path in /dev/ or /sys/ or a unit name: Invalid argument
---
After:
---
$ udevadm info /sys/class/foo
Unknown device "/sys/class/foo": No such device
---
Zbigniew Jędrzejewski-Szmek [Thu, 29 Sep 2022 12:30:24 +0000 (14:30 +0200)]
docs/CONTRIBUTING: explain various labels and add link to "reviewable" PRs
The linked filter gives an up-to-date list of pull requests that need review.
(Yes, there's too many.) We used to set 'needs-review' label, but that is
not available to non-members, and also every pull requests which is not labeled
'reviewed/needs-rework'/'ci-fails/needs-rework'/'needs-rebase' can and should
be reviewed.
If this is merged, I'll drop the 'needs-review' label.
Frantisek Sumsal [Thu, 29 Sep 2022 12:23:11 +0000 (14:23 +0200)]
test: bump the `reattach` timeout when running w/ plain QEMU
As it might sometimes take slightly longer without the acceleration:
```
[ 176.805681] testsuite-29.sh[534]: + cp /usr/share/app1.raw /tmp/app1_2.raw
[ 176.885365] testsuite-29.sh[534]: + timeout 30 portablectl reattach --now --runtime --extension /tmp/app1_2.raw /usr/share/minimal_1.raw app1
[ 177.053358] portablectl[993]: (Matching unit files with prefixes 'app1'.)
[ 177.138770] kernel: loop0: detected capacity change from 0 to
2965504
[ 177.343137] kernel: loop1: detected capacity change from 0 to 4096
...
[ 201.932062] systemd[1]: app1.service: Deactivated successfully.
[ 202.009310] systemd[1]: Stopped app1.service.
[ 202.053776] systemd[1]: app1.service: Consumed 2.183s CPU time.
[ 202.125061] systemd[1]: Stopping app1.service...
[ 202.611760] systemd[1]: Starting modprobe@dm_mod.service...
[ 202.851031] systemd[1]: Starting modprobe@dm_verity.service...
[ 202.909352] systemd[1]: Starting modprobe@loop.service...
[ 203.198918] systemd[1]: Starting app1.service...
[ 207.145494] kernel: audit: type=1130 audit(
1663770336.105:428): pid=1 uid=0 auid=
4294967295 ses=
4294967295 subj=kernel msg='unit=testsuite-29 comm="systemd" exe="/usr/lib/systemd/systemd" hostname=? addr=? terminal=? res=failed'
[ 207.652545] systemd[1]: testsuite-29.service: Main process exited, code=exited, status=124/n/a
[ 207.665088] systemd[1]: testsuite-29.service: Failed with result 'exit-code'.
[ 207.830522] systemd[1]: Failed to start testsuite-29.service.
...
[ 208.889449] script1.sh[1035]: ID="centos"
[ 208.889449] script1.sh[1035]: VERSION_ID="8"
[ 208.889449] script1.sh[1035]: SYSEXT_SCOPE=portable
[ 208.889449] script1.sh[1035]: PORTABLE_PREFIXES=app1
...
[ 214.155097] systemd[1]: app1.service: Deactivated successfully.
```
Spotted in Ubuntu CI and CentOS CI.
Follow-up to
706c9a30ac.
Jan Janssen [Thu, 29 Sep 2022 07:09:52 +0000 (09:09 +0200)]
stub: Remove unused function parameter
Lennart Poettering [Tue, 27 Sep 2022 12:32:35 +0000 (14:32 +0200)]
resolved: paranoia: restrict socket mode as much as we can
Frantisek Sumsal [Wed, 28 Sep 2022 15:01:55 +0000 (17:01 +0200)]
test: wrap `ls` and `stat` to make it work w/ sanitizers in specific cases
When `/etc/nsswitch.conf` uses `systemd` together with `[SUCCESS=merge]`,
`ls -l` will pull in `libnss_systemd` causing `SIGABRT`, as `ls` is not
instrumented (by default):
```
-bash-5.1# strace -f -e %file ls -l /dev
execve("/usr/bin/ls", ["ls", "-l", "/dev"], 0x7ffc3bb211c8 /* 24 vars*/) = 0
...
openat(AT_FDCWD, "/etc/passwd", O_RDONLY|O_CLOEXEC) = 3
newfstatat(3, "", {st_mode=S_IFREG|0644, st_size=1896, ...}, AT_EMPTY_PATH) = 0
newfstatat(AT_FDCWD, "/etc/nsswitch.conf", {st_mode=S_IFREG|0644, st_size=359, ...}, 0) = 0
openat(AT_FDCWD, "/etc/group", O_RDONLY|O_CLOEXEC) = 3
newfstatat(3, "", {st_mode=S_IFREG|0644, st_size=965, ...}, AT_EMPTY_PATH) = 0
openat(AT_FDCWD, "/etc/ld.so.cache", O_RDONLY|O_CLOEXEC) = 3
newfstatat(3, "", {st_mode=S_IFREG|0644, st_size=10779, ...}, AT_EMPTY_PATH) = 0
openat(AT_FDCWD, "/usr/lib/libnss_systemd.so.2", O_RDONLY|O_CLOEXEC) = 3
newfstatat(3, "", {st_mode=S_IFREG|0755, st_size=
16195176, ...}, AT_EMPTY_PATH) = 0
openat(AT_FDCWD, "/usr/lib/libasan.so.8", O_RDONLY|O_CLOEXEC) = 3
...
readlink("/proc/self/exe", "/usr/bin/ls", 4096) = 11
open("/proc/self/cmdline", O_RDONLY) = 3
open("/proc/self/environ", O_RDONLY) = 3
==620==ASan runtime does not come first in initial library list; you should either link runtime to your application or manually preload it with LD_PRELOAD.
--- SIGABRT {si_signo=SIGABRT, si_code=SI_TKILL, si_pid=620, si_uid=0} ---
+++ killed by SIGABRT (core dumped) +++
Aborted (core dumped)
```
This also happens with `stat`. Let's add both `ls` and `stat` to the "wrap list"
to work around this.
Spotted on Arch Linux.
Lennart Poettering [Wed, 28 Sep 2022 10:45:31 +0000 (12:45 +0200)]
resolvectl: add line breaks for readability
Lennart Poettering [Wed, 28 Sep 2022 15:12:20 +0000 (17:12 +0200)]
resolved: don't access sshfp fields from tlsa printer
Lennart Poettering [Wed, 28 Sep 2022 09:44:57 +0000 (11:44 +0200)]
resolved: return regular varlink invalid parameter error if more is not specified on monitor call
No point in returning EINVAL if we can just return a proper varlink
invalid parameter error
Lennart Poettering [Wed, 28 Sep 2022 09:44:18 +0000 (11:44 +0200)]
resolved: fix parameter reuse in DNS_ANSWER_FOREACH_ITEM() iterator macro
Frantisek Sumsal [Wed, 28 Sep 2022 09:30:13 +0000 (11:30 +0200)]
test: fix a copy-paste error
Daan De Meyer [Wed, 28 Sep 2022 08:50:55 +0000 (10:50 +0200)]
Merge pull request #24837 from yuwata/kernel-install
kernel-install: two fixlets
Zbigniew Jędrzejewski-Szmek [Mon, 19 Sep 2022 07:33:28 +0000 (09:33 +0200)]
coredump: print build-id only when package version is missing
The build-id is quite verbose, and probably not very useful to a user when they
already know the nvra of the package.
Zbigniew Jędrzejewski-Szmek [Sun, 18 Sep 2022 17:26:29 +0000 (19:26 +0200)]
coredump: shorten output about package metadata to one line
We would print the whole thing in extenso. Users generally don't care,
and would likely prefer to just get the compact identifier of the package
that they can use in a bug report or package manager commands.
Before:
systemd-coredump[40645]: [🡕] Process 1975 (gnome-shell) of user 1000 dumped core.
Module /usr/bin/gnome-shell (deleted) with build-id
aafdb7d69a7efca937e490080ad9348541fc57d8
Metadata for module /usr/bin/gnome-shell (deleted) owned by FDO found: {
"type" : "rpm",
"name" : "gnome-shell",
"version" : "43~rc-3.fc37",
"architecture" : "x86_64",
"osCpe" : "cpe:/o:fedoraproject:fedora:37"
}
Module /usr/lib64/gnome-shell/libgvc.so (deleted) with build-id
56cbb9862e1ee84ca1549b94f2b4cda03537613e
Metadata for module /usr/lib64/gnome-shell/libgvc.so (deleted) owned by FDO found: {
"type" : "rpm",
"name" : "gnome-shell",
"version" : "43~rc-2.fc37",
"architecture" : "x86_64",
"osCpe" : "cpe:/o:fedoraproject:fedora:37"
}
Module /usr/lib64/libLLVM-14.so (deleted) with build-id
ffa7e43f48eb4c189304c0241b1862710de4c3a4
Metadata for module /usr/lib64/libLLVM-14.so (deleted) owned by FDO found: {
"type" : "rpm",
"name" : "gnome-shell",
"version" : "43~rc-2.fc37",
"architecture" : "x86_64",
"osCpe" : "cpe:/o:fedoraproject:fedora:37"
}
After:
systemd-coredump[235218]: [🡕] Process 235216 (bash) of user 1000 dumped core.
Module libtinfo.so.6 from rpm ncurses-6.3-3.
20220501.fc37.x86_64, build-id=
71a04d23fd572525eb6efc47026c379725e06d96
Module bash from rpm bash-5.1.16-3.fc37.x86_64, build-id=
6c936aff95a2ccda04a3fb685a81a84a0a8d10da
Stack trace of thread 235216:
#0 0x00007fa409ec8d8b kill (libc.so.6 + 0x38d8b)
#1 0x0000560d35e366b1 kill_builtin (bash + 0xad6b1)
#2 0x0000560d35dd7227 execute_builtin.lto_priv.0 (bash + 0x4e227)
#3 0x0000560d35dd0459 execute_simple_command (bash + 0x47459)
#4 0x0000560d35dd1de0 execute_command_internal (bash + 0x48de0)
#5 0x0000560d35e307aa parse_and_execute (bash + 0xa77aa)
#6 0x0000560d35e91b08 run_one_command.isra.0 (bash + 0x108b08)
#7 0x0000560d35dba07c main (bash + 0x3107c)
#8 0x00007fa409eb3510 __libc_start_call_main (libc.so.6 + 0x23510)
#9 0x00007fa409eb35c9 __libc_start_main@@GLIBC_2.34 (libc.so.6 + 0x235c9)
#10 0x0000560d35dbad85 _start (bash + 0x31d85)
Yu Watanabe [Sun, 18 Sep 2022 03:28:45 +0000 (12:28 +0900)]
loop-util: re-introduce loop_device_open() which takes sd_device object
Then, this makes loop_device_open_from_fd() or _from_path() be wrappers
of loop_device_open() with block_device_new_from_fd() or _from_path(),
respectively.
Yu Watanabe [Mon, 19 Sep 2022 00:12:15 +0000 (09:12 +0900)]
loop-util: rename loop_device_open() -> loop_device_open_from_path()
No functional changes, just preparation for later commits.
Yu Watanabe [Sun, 18 Sep 2022 21:33:26 +0000 (06:33 +0900)]
blockdev-util: introduce block_device_new_from_fd() and block_device_new_from_path()
These are possible replacements of get_block_device(),
get_block_device_harder(), path_get_whole_disk(), and friends.
Yu Watanabe [Sun, 18 Sep 2022 21:27:37 +0000 (06:27 +0900)]
blockdev-util: re-implement block_get_originating() by using sd_device
And split out the core logic as block_device_get_originating().
Hopefully, this changes no behavior. Just refactoring and preparation
for later commits.
Yu Watanabe [Mon, 19 Sep 2022 23:43:45 +0000 (08:43 +0900)]
blockdev-util: reopen file descriptor only when O_PATH is set
Prompted by
13879c54d4f8b912e1f8c57e0ff7b516dd2a6f52.
Yu Watanabe [Sun, 18 Sep 2022 07:15:54 +0000 (16:15 +0900)]
blockdev-util: split-out fd_get_devnum()
No functional changes, just preparation for later commits.
Zbigniew Jędrzejewski-Szmek [Mon, 19 Sep 2022 09:29:56 +0000 (11:29 +0200)]
coredump: when parsing json, optionally copy the string first
Yu Watanabe [Wed, 28 Sep 2022 04:42:01 +0000 (13:42 +0900)]
fuzz: tighten acceptable data size
Fixes oss-fuzz#51887 (https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=51887).
Fixes #24833.
Sarah Brofeldt [Wed, 28 Sep 2022 06:43:30 +0000 (08:43 +0200)]
docs/NETWORK_ONLINE: systemd.network hyperlink fix
Yu Watanabe [Wed, 28 Sep 2022 04:35:49 +0000 (13:35 +0900)]
kernel-install: do not fail if a plugin exits with 77
Yu Watanabe [Wed, 28 Sep 2022 04:27:19 +0000 (13:27 +0900)]
kernel-install: do not fail if $layout is not "bls"
Fixes #24836.
msizanoen1 [Tue, 27 Sep 2022 14:48:48 +0000 (21:48 +0700)]
resolve: persist DNSOverTLS configuration in state file
Currently, NetworkManager will set DNSOverTLS according to its
`connection.dnsovertls` configuration only once during connection,
instead of every single restart of systemd-resolved, causing resolved to
lose the configuration on restart.
Fix this by persisting DNSOverTLS in the runtime state file, which will
also make it more consistent with other interface-specific settings.
Edson Juliano Drosdeck [Tue, 27 Sep 2022 23:06:34 +0000 (19:06 -0400)]
hwdb: fix Positivo-vaio FE14 V2 key toggle touchpad #24822 (#24825)
Luca Boccassi [Mon, 26 Sep 2022 14:33:35 +0000 (15:33 +0100)]
resolved notifications: follow-up fixes
Further review comments from: https://github.com/systemd/systemd/pull/22845
Yu Watanabe [Mon, 19 Sep 2022 14:57:43 +0000 (23:57 +0900)]
mkosi: install fdisk for test-loop-block
Yu Watanabe [Mon, 19 Sep 2022 04:59:52 +0000 (13:59 +0900)]
test: add test for dissect_image_file()
Yu Watanabe [Mon, 19 Sep 2022 02:57:35 +0000 (11:57 +0900)]
dissect-image: introduce dissect_image_file() which works for regular file
Yu Watanabe [Mon, 19 Sep 2022 11:30:29 +0000 (20:30 +0900)]
dissect-image: split-out dissected_image_probe_filesystem()
No functional changes, just preparation for later commits.
Yu Watanabe [Tue, 27 Sep 2022 17:26:55 +0000 (02:26 +0900)]
Merge pull request #24832 from mrc0mmand/more-TEST-64-tweaks
A couple of performance tweaks for TEST-64 under QEMU
Zbigniew Jędrzejewski-Szmek [Mon, 26 Sep 2022 12:46:08 +0000 (14:46 +0200)]
tmpfiles: downgrade message about unitialized-/etc
If we're running with --root, or in a chroot (*), it's expected that machine-id
and other specifiers will be unresolvable, so downgrade the warning to debug.
Fixes #24655.
(*) sd_booted() in principle means more than that, but nowadays systemd
dominates and those others things are infrequently seen.
Zbigniew Jędrzejewski-Szmek [Mon, 26 Sep 2022 12:22:49 +0000 (14:22 +0200)]
tmpfiles: fix detection of unitialized-/etc
In
6ec4c852c910b1aca649e87ba3143841334f01fa I changed specifier_machine_id() to
return EUNATCH, but the code catching in tmpfiles wasn't adjusted.
Instead of translating errors at various levels, let the "original" errno value
(whatever was returned by the low-level reading function) propagate all the way
to the logging function, and only check which errnos to suppress there. This
makes it easier to follow the flow of data through all the layers. Also, we
don't need to provide wrapper functions for each place where we want to do the
supression.
The common set of errnos that have similar meaning are are caught using
ERRNO_IS_NOINFO(). It is more managable to use a wider net than to figure out
which errors could be returned in specific cases.
Frantisek Sumsal [Tue, 27 Sep 2022 11:57:04 +0000 (13:57 +0200)]
test: use fewer partitions/LVs when running with plain QEMU
Frantisek Sumsal [Tue, 27 Sep 2022 11:47:59 +0000 (13:47 +0200)]
test: make the symlink helpers a bit more quiet
and show only errors/warnings.
Frantisek Sumsal [Tue, 27 Sep 2022 11:06:27 +0000 (13:06 +0200)]
test: ignore tty* devices when checking device units
This lower the runtime of `check_device_units()` in a plain QEMU VM from
~45 seconds to ~25 seconds.
Frantisek Sumsal [Tue, 27 Sep 2022 11:05:43 +0000 (13:05 +0200)]
test: lower the # of iterations when running with plain QEMU
Frantisek Sumsal [Mon, 26 Sep 2022 21:14:18 +0000 (23:14 +0200)]
test: support open-iscsi >= 2.1.2
Since open-iscsi 2.1.2 [0] the initiator name should be generated via
a one-time service instead of distro package's post-install scripts.
However, some distros still use this approach even after this patch,
so prefer the already existing initiatorname.iscsi file if it exists.
[0] https://github.com/open-iscsi/open-iscsi/commit/
f37d5b653f9f251845db3f29b1a3dcb90ec89731
Lennart Poettering [Tue, 27 Sep 2022 09:28:25 +0000 (11:28 +0200)]
Merge pull request #24805 from yuwata/sd-network
sd-network: several cleanups
Richard Phibel [Wed, 7 Sep 2022 10:53:09 +0000 (03:53 -0700)]
systemctl: add support for --image option
All tools that support --root= should also learn --image=
so that they can operate on disk images directly.
Yu Watanabe [Tue, 27 Sep 2022 05:10:02 +0000 (14:10 +0900)]
Merge pull request #24812 from yuwata/udev-drop-netlink
udev: drop workaround for slow read of phys_port_name sysattr
Yu Watanabe [Sat, 24 Sep 2022 00:31:00 +0000 (09:31 +0900)]
sd-network: make sd_network_link_get_dns() or friends return -ENODATA
To make them consistent with other functions.
Yu Watanabe [Sat, 24 Sep 2022 00:22:03 +0000 (09:22 +0900)]
sd-network: drop fallback values
This drops spurious lines in `networkctl status` for unmanaged interfaces.
Before:
```
$ networkctl status --lines 0 lo
● 1: lo
Link File: n/a
Network File: n/a
Type: loopback
State: carrier (unmanaged)
Online state: unknown
HW Address: 00:00:00:00:00:00
MTU: 65536
QDisc: noqueue
IPv6 Address Generation Mode: eui64
Queue Length (Tx/Rx): 1/1
Address: 127.0.0.1
::1
Activation Policy: up
Required For Online: yes
```
After:
```
$ networkctl status --lines 0 lo
● 1: lo
Link File: n/a
Network File: n/a
State: carrier (unmanaged)
Online state: unknown
Type: loopback
Hardware Address: 00:00:00:00:00:00
MTU: 65536
QDisc: noqueue
IPv6 Address Generation Mode: eui64
Number of Queues (Tx/Rx): 1/1
Address: 127.0.0.1
::1
```
That is, the lines for Activation Policy and Required For Online are
dropped.
Yu Watanabe [Sat, 24 Sep 2022 00:20:36 +0000 (09:20 +0900)]
sd-network: introduce network_link_get_boolean() helper function
Yu Watanabe [Sat, 24 Sep 2022 00:05:05 +0000 (09:05 +0900)]
sd-network: accept all space-like separators