Yu Watanabe [Tue, 20 Feb 2024 21:20:45 +0000 (06:20 +0900)]
network: introduce per-interface IP forwarding settings
This deprecates IPForward= setting, which unconditionally controled
the global setting, even though it is a setting in .network file.
Instead, this introduces new IPv4Forwarding= and IPv6Forwarding=
settings both in .network and networkd.conf.
If these settings are specified in a .network file, then the
per-interface forwarding setting will be configured.
If specified in networkd.conf, then the global IP forwarding setting will
be configured.
Closes #30648.
zzywysm [Thu, 22 Feb 2024 18:03:06 +0000 (13:03 -0500)]
README: mention fq_codel
In 2014, systemd started choosing fq_codel as the default_qdisc in order to fight internet bufferbloat.
https://github.com/systemd/systemd/commit/
e6c253e363dee77ef7e5c5f44c4ca55cded3fd47
https://github.com/systemd/systemd/commit/
fa98c99ea7f7c5bec3962fa52f4d3496a9777024
While the subsequent change made this change no longer trigger warnings if fq_codel wasn't present, it is still recommended to have this enabled. Add the necessary kernel configuration to the documentation.
Luca Boccassi [Thu, 22 Feb 2024 18:48:43 +0000 (18:48 +0000)]
Merge pull request #31441 from yuwata/sd-ndisc-fix-timer
sd-ndisc: disable timer event source only when a valid RA received
Luca Boccassi [Thu, 22 Feb 2024 14:14:23 +0000 (14:14 +0000)]
Merge pull request #31445 from keszybz/slow-tests
Mark more tests as slow
Luca Boccassi [Thu, 22 Feb 2024 12:48:38 +0000 (12:48 +0000)]
Merge pull request #31414 from poettering/bsod-tweaks
bsod: some small bsod tweaks
Zbigniew Jędrzejewski-Szmek [Thu, 22 Feb 2024 12:01:17 +0000 (13:01 +0100)]
Luca Boccassi [Thu, 22 Feb 2024 11:04:45 +0000 (11:04 +0000)]
Merge pull request #31432 from poettering/vmspawn-qemu-rename
vmspawn: drop "qemu" word from most switches
Zbigniew Jędrzejewski-Szmek [Thu, 22 Feb 2024 11:04:29 +0000 (12:04 +0100)]
Merge pull request #31178 from neighbourhoodie/add-old-website-content
Migrate the content of the old website
Zbigniew Jędrzejewski-Szmek [Thu, 22 Feb 2024 10:35:07 +0000 (11:35 +0100)]
test-nss-hosts: treat negative host lookup as slow
The negative lookup can be quite slow. On my local network, skipping
this test saves about half of the runtime of test-nss-hosts.
Zbigniew Jędrzejewski-Szmek [Thu, 22 Feb 2024 10:26:53 +0000 (11:26 +0100)]
test-ukify: skip signing in tests when slow tests are disabled
I have a large initrd (built with mkosi-initrd) and the test-ukify takes 30 s.
Let's use the usual approach of skipping the slowests tests.
(pytest has marks, and it would be nicer to mark tests with pytest.mark.slow,
and then use "-m 'not slow'" in the meson test invocation. But markers must be
pre-registered, otherwise pytest emits a warning. There are a few ways to
register markers, but they all require "project configuration", but because of
how we invoke pytest, this is hard to do. So let's just use an environment
variable.)
hulkoba [Tue, 30 Jan 2024 11:57:10 +0000 (12:57 +0100)]
docs: use collections to structure the data
hulkoba [Mon, 29 Jan 2024 12:20:19 +0000 (13:20 +0100)]
docs: add distributions and mastodon
hulkoba [Mon, 29 Jan 2024 11:55:10 +0000 (12:55 +0100)]
docs: add Manuals and Documentation for Users and Administrators
Mariano Giménez [Tue, 23 Jan 2024 16:44:31 +0000 (17:44 +0100)]
docs: add documentation for developers
Mariano Giménez [Tue, 23 Jan 2024 15:25:38 +0000 (16:25 +0100)]
add related packages links
Mariano Giménez [Tue, 23 Jan 2024 14:51:29 +0000 (15:51 +0100)]
add The systemd for Developers Series pages
Mariano Giménez [Tue, 23 Jan 2024 11:17:17 +0000 (12:17 +0100)]
add administrators blog series links to extra_pages.json
Mariano Giménez [Tue, 23 Jan 2024 09:38:32 +0000 (10:38 +0100)]
add videos and presentations
Mariano Giménez [Tue, 23 Jan 2024 08:58:17 +0000 (09:58 +0100)]
add publications to extra_pages.json
Yu Watanabe [Thu, 22 Feb 2024 05:33:29 +0000 (14:33 +0900)]
sd-ndisc: actually refuse RA message from null address
Yu Watanabe [Thu, 22 Feb 2024 04:59:57 +0000 (13:59 +0900)]
sd-ndisc: disable timer event source only when a valid RA received
Fixes #31439.
Yu Watanabe [Thu, 22 Feb 2024 03:40:54 +0000 (12:40 +0900)]
Merge pull request #31409 from ssahani/macvlan
netdev: macvlan - Allow to set the broadcast queueing threshold
Susant Sahani [Thu, 22 Feb 2024 00:45:41 +0000 (09:45 +0900)]
test-network: add test for macvlan BroadcastQueueMulticastLength= and BroadcastQueueThreashold=
Yu Watanabe [Thu, 22 Feb 2024 00:46:45 +0000 (09:46 +0900)]
test-network: use assertIn()
Susant Sahani [Tue, 20 Feb 2024 13:12:20 +0000 (18:42 +0530)]
netdev/macvlan: allow to set the broadcast queueing threshold
Allow to set the broadcast queueing threshold
on macvlan devices. This controls which multicast packets will be
processed in a workqueue instead of inline.
Yu Watanabe [Wed, 21 Feb 2024 23:29:56 +0000 (08:29 +0900)]
Merge pull request #31429 from poettering/pcrlock-hash-order-fix
pcrlock: handle cases where order of hash algs in firmware binary logs differs in header and records
Yu Watanabe [Wed, 21 Feb 2024 23:29:11 +0000 (08:29 +0900)]
Merge pull request #31425 from YHNdnzj/fd-util-followup
fd-util: introduce fd_verify_safe_flags
Yu Watanabe [Wed, 21 Feb 2024 23:28:38 +0000 (08:28 +0900)]
Merge pull request #31403 from yuwata/pam-sd-bus-session
pam_systemd_home: close sd-bus connection on failure
Yu Watanabe [Wed, 21 Feb 2024 19:50:18 +0000 (04:50 +0900)]
basic/linux: update kernel headers from v6.8-rc5
Mike Yuan [Wed, 21 Feb 2024 06:03:55 +0000 (14:03 +0800)]
journal-native: ignore server_process_native_file error on caller's side
Also, stop saying ", ignoring". It is unclear whether the message
or the error is ignored. "ignoring message" or "refusing" is OK.
Mike Yuan [Wed, 21 Feb 2024 05:45:01 +0000 (13:45 +0800)]
fd-util: introduce fd_verify_safe_flags
As per https://github.com/systemd/systemd/pull/31419#discussion_r1496921074
medusalix [Wed, 21 Feb 2024 20:02:37 +0000 (21:02 +0100)]
hwdb: Add headset form-factor override for Xbox Wireless Dongle
The Xbox Wireless Headset does not get assigned a sound form factor
when connected via the dongle using the `xone` driver.
Add USB IDs for the old & new dongle and built-in variants.
Yu Watanabe [Wed, 21 Feb 2024 19:26:42 +0000 (04:26 +0900)]
network/json: use DUID obtained by sd_dhcp6_client_get_duid()
Follow-up for
e5aa8c193d730bca26fe123258d9a73834509f26.
Lennart Poettering [Wed, 21 Feb 2024 10:03:35 +0000 (11:03 +0100)]
tree-wide: be more careful when passing literal integers to "t" bus message fields
Since we use varargs for sd_message_append() we need to make sure the
parameters we pass are actually 64bit wide, if "t" is used. Hence cast
appropriately if necessary.
I went through the whole tree, and in most cases we got it right, but
there are some cases we missed so far.
Inspired by: #31420
Frantisek Sumsal [Wed, 21 Feb 2024 14:42:35 +0000 (15:42 +0100)]
test: temporarily enable session lingering for the test user #2
Similarly to
bbac11c993 we need to enable session lingering for the test
user, so the long-running test units are not killed prematurely:
[ 18.822261] testsuite-55.sh[403]: + systemctl start --machine testuser@.host --user testsuite-55-testchill.service
[ 18.852775] systemd[1]: Started run-u17.service.
[ 19.256431] (o-bridge)[526]: pam_unix(login:session): session opened for user testuser(uid=4711) by testuser(uid=0)
[ 19.288346] systemd[1]: Started session-2.scope.
[ 20.165874] systemd[392]: Created slice session.slice.
[ 20.166459] systemd[392]: Starting dbus-broker.service...
[ 20.220189] dbus-broker-launch[529]: Policy to allow eavesdropping in /usr/share/dbus-1/session.conf +31: Eavesdropping is deprecated and ignored
[ 20.220189] dbus-broker-launch[529]: Policy to allow eavesdropping in /usr/share/dbus-1/session.conf +33: Eavesdropping is deprecated and ignored
[ 20.220494] systemd[392]: Started dbus-broker.service.
[ 20.224276] dbus-broker-launch[529]: Ready
[ 20.231702] systemd[392]: Created slice testsuite.slice.
[ 20.231976] systemd[392]: Created slice testsuite-55.slice.
[ 20.232259] systemd[392]: Created slice testsuite-55-workload.slice.
[ 31.065294] testsuite-55.sh[403]: + systemctl start --machine testuser@.host --user testsuite-55-testbloat.service
[ 31.065641] (sd-pam)[528]: pam_unix(login:session): session closed for user testuser
[ 31.066103] (sd-pam)[528]: pam_systemd(login:session): Failed to release session: Access denied
[ 31.066152] systemd[392]: Started testsuite-55-testchill.service.
[ 31.068062] systemd[1]: run-u17.service: Deactivated successfully.
[ 31.068217] dbus-broker[389]: A security policy denied :1.20 to send method call /org/freedesktop/login1:org.freedesktop.login1.Manager.ReleaseSession to org.freedesktop.login1.
[ 31.075901] (o-bridge)[537]: pam_unix(login:session): session opened for user testuser(uid=4711) by testuser(uid=0)
[ 31.091098] systemd[1]: Stopping session-2.scope...
[ 31.092158] systemd[1]: Started run-u21.service.
[ 31.092993] systemd[1]: session-2.scope: Deactivated successfully.
[ 31.093287] systemd[1]: Stopped session-2.scope.
[ 31.095798] systemd[1]: Stopping user@4711.service...
[ 31.103541] systemd[392]: Activating special unit exit.target...
[ 31.108359] systemd[392]: Stopped target default.target.
[ 31.109798] systemd[392]: Stopped target timers.target.
[ 31.110790] systemd[392]: Stopping testsuite-55-testchill.service...
[ 31.112154] systemd[392]: Stopped testsuite-55-testchill.service.
[ 31.114033] systemd[392]: Removed slice testsuite-55-workload.slice.
[ 31.114971] systemd[392]: Removed slice testsuite-55.slice.
[ 31.115858] systemd[392]: Removed slice testsuite.slice.
...
[ 31.475949] testsuite-55.sh[403]: + systemctl --machine testuser@.host --user status testsuite-55-testchill.service
[ 31.490464] systemd[1]: session-3.scope: Deactivated successfully.
[ 31.565929] systemd[1]: Started run-u33.service.
[ 31.592437] (o-bridge)[583]: pam_unix(login:session): session opened for user testuser(uid=4711) by testuser(uid=0)
[ 31.610210] systemd[1]: Started session-5.scope.
[ 31.616960] testsuite-55.sh[578]: ○ testsuite-55-testchill.service - No memory pressure
[ 31.616960] testsuite-55.sh[578]: Loaded: loaded (/usr/lib/systemd/tests/testdata/units/testsuite-55-testchill.service; static)
[ 31.616960] testsuite-55.sh[578]: Active: inactive (dead)
[ 31.617438] (sd-pam)[586]: pam_unix(login:session): session closed for user testuser
Addresses https://github.com/systemd/systemd/pull/31426#issuecomment-
1956436844.
Lennart Poettering [Wed, 21 Feb 2024 15:23:55 +0000 (16:23 +0100)]
vmspawn: rename "qemu" specific switches to not carry the "qemu" prefix
This renames a few of the switches vmspawn takes, such as --qemu-mem=
and --qemu-smp= to names without the "qemu" moniker and uses less
cryptic names (i.e. --ram= and --cpus=).
I think it's a bit unsystematic that so far we use the "qemu" prefix for
some options but not for others. At least I could not figure out a
system when we use it and when we don't. Hence let's clean it up and
just use simpler names without suffix.
After all we might want to plug other hypervisors behind vmspawn one
day, hence I think there's value in sticking to generic names for these
switches that allow us to switch out backends easily. In particular for
--ram= and --cpus= which are probably the most fundamental of VM settings
there are.
The old switches are support for compat, but not advertised in man page
or --help text anymore.
I left "--qemu-gui" under its current name, since it fundamentally is a
a qemu concept, exposing a qemu specific graphical UI.
Lennart Poettering [Wed, 21 Feb 2024 15:18:24 +0000 (16:18 +0100)]
vspawn: prefer "VSOCK" spelling over "vsock" and "VSock"
The vsock(7) man page appears to prefer "VSOCK" spelling for the
concept, let's also use it as much as we can.
Lennart Poettering [Wed, 21 Feb 2024 14:46:12 +0000 (15:46 +0100)]
update TODO
Lennart Poettering [Wed, 21 Feb 2024 08:59:51 +0000 (09:59 +0100)]
bsod: don't fail in an error path
If we fail in an error path, don't override the error we are processing,
just print a warning and continue.
Lennart Poettering [Wed, 21 Feb 2024 08:59:35 +0000 (09:59 +0100)]
bsod: remove one redundant variable
Lennart Poettering [Wed, 21 Feb 2024 08:53:58 +0000 (09:53 +0100)]
bsod: normalize VT indexes
The 1-based VT indexes are what people usually expect, since the primary
name of VTs uses them (i.e. /dev/tty1, /dev/tty2, …). Hence, let's
always use 1-based VT indexes, and early on convert 0-based VT indexes
to minimize confusion.
Lennart Poettering [Wed, 21 Feb 2024 08:46:15 +0000 (09:46 +0100)]
bsod: correct log level on some messages
Lennart Poettering [Tue, 20 Feb 2024 15:33:01 +0000 (16:33 +0100)]
bsod: make sure "Press Any Key" has a blue background too
Lennart Poettering [Tue, 20 Feb 2024 14:42:10 +0000 (15:42 +0100)]
bsod: remove some duplicate logging
display_emergency_message_fullscreen() already logs about all erros,
hence don't log again.
Lennart Poettering [Tue, 20 Feb 2024 14:41:16 +0000 (15:41 +0100)]
bsod: add new option --tty= to specify TTY to output on
If specified we'll not try to find a free V, but instead just output
directly to the specified TTY. This is particularly useful for
debugging, as it means "systemd-bsod --tty=/dev/tty" just works.
Lennart Poettering [Tue, 20 Feb 2024 14:32:49 +0000 (15:32 +0100)]
bsod: adjust --help text to match our usual output
Susant Sahani [Tue, 20 Feb 2024 08:33:13 +0000 (14:03 +0530)]
network: JSON - Export DHCPv4 client ID
Allow networkd to export the DHCP4 client ID which right now we don't support.
Luca Boccassi [Wed, 21 Feb 2024 13:52:22 +0000 (13:52 +0000)]
Merge pull request #31326 from CodethinkLabs/vmspawn/extra_drives
vmspawn: add --extra-drive= and correctly escape ',' in certain qemu arguments
Lennart Poettering [Wed, 21 Feb 2024 13:43:42 +0000 (14:43 +0100)]
pcrlock: handle measurement logs where hash algs in header are announced in different order than in records
Apparently on HyperV the measurement logs announce the hash algs in a
different order in the header than the records have them. Let's handle
this gracefully
Lennart Poettering [Wed, 21 Feb 2024 13:42:50 +0000 (14:42 +0100)]
pcrlock: document the env vars we honour to find measurement logs
This env vars have been supported for a while, let's document them where
we usually document them.
hulkoba [Wed, 24 Jan 2024 11:13:12 +0000 (12:13 +0100)]
docs: show mkosi project on website
Luca Boccassi [Wed, 21 Feb 2024 11:35:34 +0000 (11:35 +0000)]
Merge pull request #31426 from YHNdnzj/logind-minor-cleanup
logind: some cleanups
Martin Ivicic [Wed, 21 Feb 2024 01:07:26 +0000 (02:07 +0100)]
networkd: support setting dhcp server port
Susant Sahani [Wed, 21 Feb 2024 10:32:27 +0000 (16:02 +0530)]
network: DHCP6 Allow to export DHCP6 DUID (#31355)
We did not support the export of DHCP6 DUID. Let's add this. Some
applications may use it.
Antonio Alvarez Feijoo [Wed, 21 Feb 2024 10:08:18 +0000 (11:08 +0100)]
cryptsetup-tokens: fix typo in comments
Sam Leonard [Wed, 14 Feb 2024 16:40:40 +0000 (16:40 +0000)]
vmspawn: add --extra-drive=
Sam Leonard [Wed, 14 Feb 2024 15:38:31 +0000 (15:38 +0000)]
vmspawn: correctly escape ',' in certain values passed to qemu
Frantisek Sumsal [Tue, 20 Feb 2024 21:38:42 +0000 (22:38 +0100)]
homectl: make sure we sent the full 8 bytes as flags
Otherwise weird stuff happens on the other side:
[
1217111.957263] testsuite-46.sh[61]: + homectl create test-user --disk-size=min --luks-discard=yes --image-path=/home/test-user.home --luks-pbkdf-type=pbkdf2 --luks-pbkdf-time-cost=1ms
[
1217112.598219] homectl[66]: Operation on home test-user failed: Provided flags are unsupported (
0ad2578000000000).
(taken from TEST-46-HOME run on armv7l)
Fixes issue mentioned in https://github.com/systemd/systemd/pull/31419#issuecomment-
1955117397.
Mike Yuan [Tue, 20 Feb 2024 15:39:27 +0000 (23:39 +0800)]
logind-dbus: clean up manager_{start,stop,kill}_unit
Mike Yuan [Tue, 20 Feb 2024 09:49:12 +0000 (17:49 +0800)]
logind-dbus: rearrange functions
Mike Yuan [Tue, 20 Feb 2024 10:03:14 +0000 (18:03 +0800)]
logind-session-dbus: drop unneeded unref_and_replace
If there's pending s->upgrade_message, we already return early
above.
Yu Watanabe [Wed, 21 Feb 2024 05:29:01 +0000 (14:29 +0900)]
Merge pull request #31405 from yuwata/network-ndisc-reachable-time
network/ndisc: set neighbor reachable time
Mike Yuan [Wed, 21 Feb 2024 05:12:30 +0000 (13:12 +0800)]
Merge pull request #31419 from AdrianVovk/fixup-largefile-define
Fixup largefile define
Yu Watanabe [Wed, 21 Feb 2024 04:21:31 +0000 (13:21 +0900)]
pam_systemd_home: always close already opened bus connection in open_session()
Fixes #31375.
Yu Watanabe [Wed, 21 Feb 2024 03:45:27 +0000 (12:45 +0900)]
pam_systemd_home: open sd-bus session when necessary
No functional change, just refactoring.
Yu Watanabe [Tue, 20 Feb 2024 03:27:42 +0000 (12:27 +0900)]
pam-util: add one more debugging log about sd-bus connection
Continuation of
b5b2510800fa50187f5c7342cb9471fdb97bc4b0.
Yu Watanabe [Wed, 21 Feb 2024 03:01:48 +0000 (12:01 +0900)]
Merge pull request #31408 from mrc0mmand/verify-unit-files-v2
test: verify our own units (where applicable)
Luca Boccassi [Tue, 20 Feb 2024 23:45:52 +0000 (23:45 +0000)]
Merge pull request #31400 from poettering/askpw-rework
Password Asking rework
Adrian Vovk [Tue, 20 Feb 2024 19:54:21 +0000 (14:54 -0500)]
fd-util: Add helpers to check if FD flags are safe
Adds a SAFE_FD_FLAGS define to list out all the safe FD flags, and also
an UNSAFE_FD_FLAGS() macro to strip out the safe flags and leave only
the unsafe flags. This can be used to quickly check if any unsafe flags
are set and print them for diagnostic purposes
Adrian Vovk [Tue, 20 Feb 2024 19:24:01 +0000 (14:24 -0500)]
missing_fcntl: Fix RAW_O_LARGEFILE
This value is actually arch-specific, so this commit defines it for all
the arches that set it to some custom value
Fixes https://github.com/systemd/systemd/issues/31417
Zbigniew Jędrzejewski-Szmek [Tue, 20 Feb 2024 17:14:53 +0000 (18:14 +0100)]
analyze: always recommend saving the output to a file
The command will refuse to write to a TTY, so give a strong hint
that redirecting to a file is recommended. This makes the synopsis,
man page text, and --help output consistent.
Also drop the space after the redirection operator everywhere.
Lennart Poettering [Mon, 19 Feb 2024 17:45:49 +0000 (18:45 +0100)]
cryptsetup: drop "headless" bool, make it a flag in AskPasswordFlags instead
This bool controls whether we should interactively ask for a password,
which is pretty much what the ask_password-api.c APIs are about. Hence,
just make the bool a flag in AskPasswordFlags enum, and use it
everywhere.
This still catches the flag early in upper levels of the codebase,
exactly as before, but if the flag is still present in the lower layers
it's also handled there and results in ENOEXEC if seen.
This is mostly an excercise in simplifying our ridiculously long
function call parameter lists a bit.
Lennart Poettering [Mon, 19 Feb 2024 17:21:31 +0000 (18:21 +0100)]
man: tweak cryptsetup credentials docs a bit
Let's bring the credentials into a better order, in order of relevance.
Also, let's clarify what the generic LUKS PIN is about.
Finally, list the credentials in system-credentials(7) too, after all
people might want to unlock a disk with this via SMBIOS Type 11 or so.
Lennart Poettering [Mon, 19 Feb 2024 17:22:49 +0000 (18:22 +0100)]
man: now that the crdentials used by systemd-cryptenroll are in order, document them
Replaces: #31370
Lennart Poettering [Mon, 19 Feb 2024 17:16:47 +0000 (18:16 +0100)]
cryptsetup-pkcs11: also plug credential name to use to credential plugin
Lennart Poettering [Mon, 19 Feb 2024 17:06:34 +0000 (18:06 +0100)]
cryptenroll,cryptsetup: clean up unlock credential for TPM2 + FIDO2
Let's make sure that when cryptenroll asks for the TPM2 or FIDO2 token
PIN it uses cryptenroll.* credential namespace, and cryptsetup uses
cryptsetup.*.
Lennart Poettering [Mon, 19 Feb 2024 16:44:01 +0000 (17:44 +0100)]
pkcs11-util: clean up credential handling for PKCS11 PIN
similar as the previous commit, let's clean up the credential name we
use. Use home.token-pin in case of homectl, and cryptenroll.pkcs11-pin
in case of cryptenroll.
Lennart Poettering [Mon, 19 Feb 2024 16:34:20 +0000 (17:34 +0100)]
cryptenroll: use a different credential for new new PIN
The TPM2 enrollment is the only of the three token enrollments where the
user picks a PIN at enrollment time (the others have a PIN set for the
token, not for the enrollment). Let's make sure it uses a different
credential for retrieving this PIN, in order to make sure people can
programmatically change PINs via credentials (in which case they need to
supply both).
Lennart Poettering [Mon, 19 Feb 2024 16:30:56 +0000 (17:30 +0100)]
libfido2: tweak credential to read fido2 PIN from
Querying a fido2 PIN via askpw for enrolling is currently used in two
places: cryptenroll and homectl. So far we sloppily used the same fixed
credential name "fido2-pin" in both cases. Let's tweak that and make the
credential name match the other credentials cryptenroll or home query,
i.e. using the cryptenroll.* and home.* namespaces.
This is particular done in light of #31370, which wants to make the
credential name public. We really should get the name in order before
making it public.
Lennart Poettering [Mon, 19 Feb 2024 16:03:49 +0000 (17:03 +0100)]
pcrlock: normalize credential name for TPM2 PIN
Let's drop the "systemd-" prefix from the credential name. We do not
prefix credentials that way so far. Don't do so here either.
The name is not really API, it's not documented, hence change it now
where we still can.
Lennart Poettering [Mon, 19 Feb 2024 16:01:01 +0000 (17:01 +0100)]
cryptenroll: use correct askpw id for pw request
The "id" is used in the askpw protocol to recognize password prompts, in
case a service is replying to them and needs some id. Previously we set
an incorrect id, the one of cryptsetup. Fix that.
(I guess the id is not used much, it comes from a time where we had no
credentials, and thus some people wanted to supply passphrases
programmatically rather interactively. The usecase is probably gone, but
we should still set some valid id I guess.)
Lennart Poettering [Mon, 19 Feb 2024 15:38:01 +0000 (16:38 +0100)]
dissect-image: use strv_free_erase() at one more place
Lennart Poettering [Mon, 19 Feb 2024 15:37:36 +0000 (16:37 +0100)]
cryptenroll: fix type confusion on acquire_tpm2_key() parameter
Lennart Poettering [Mon, 19 Feb 2024 15:35:12 +0000 (16:35 +0100)]
ask-password: rework how we pass request meta info when asking passwords
Rather than adding more and more parameters to ask_password_auto(), let's
pass a structure of the fields that often are constant anyway.
This way, callers can fill in what they need, and we take the filled
structure which we can pass around internally as one.
This is in particular preparation for adding one more field in one of
the next commits.
Mike Yuan [Fri, 16 Feb 2024 19:03:50 +0000 (03:03 +0800)]
core/mount: if umount(8) fails but mount disappeared, assume success
Fixes #31337
Frantisek Sumsal [Mon, 19 Feb 2024 19:41:49 +0000 (20:41 +0100)]
test: verify our own units (where applicable)
This is inspired by one of our internal tests that does pretty much the
same thing. However, it is slightly more convoluted than I'd like it to
be, since I really don't want to duplicate the list of our units in
another place, so we need to, somehow, pass the list from the meson file
to the test script. I originally envisioned this to be a part of the
unit test suite, but this doesn't work for unit files with absolute
paths to binaries, as we'd have to install the build first (maybe using
a chroot would work?).
It doesn't check man pages (since they might not be installed on the
test machine) and also skip recursive dependencies (as that would trip
over issues in files that are not under our direct control), but it
should still cover typos and such.
There are currently two units for which the check had to be disabled -
syslog.socket, as the corresponding syslog.service might not be
installed, and rc-local.service as that's a compat API and the necessary
/etc/rc.d/rc.local file may not (and most likely won't be) present.
Zmyeir [Tue, 20 Feb 2024 10:50:03 +0000 (18:50 +0800)]
hwdb: Add support for MetawillBook01 to 60-sensor.hwdb
Add accel orientation quirk for the METAPHYUNI MetawillBook01 2-in-1 laptop
MrSmör [Thu, 16 Nov 2023 12:31:50 +0000 (13:31 +0100)]
boot: padding for default arrow at too long lines
If the default boot entry name doesnt leave enough space for the
indicator arrow, it overwrote the first two characters of the entry
Now every line will always have enough padding.
Frantisek Sumsal [Mon, 19 Feb 2024 19:52:16 +0000 (20:52 +0100)]
test: fix mixed indent
Frantisek Sumsal [Mon, 19 Feb 2024 19:37:31 +0000 (20:37 +0100)]
test: support TEST_MATCH_* stuff in TEST-23-UNIT-FILE as well
TEST-23 uses run_subtests_with_signals() which I forgot about when
introducing the change.
Follow-up for
0efa27bd4b.
Luca Boccassi [Tue, 20 Feb 2024 12:15:24 +0000 (12:15 +0000)]
Merge pull request #31388 from keszybz/bitfield-cleanup
Bitfield cleanup
Yu Watanabe [Tue, 20 Feb 2024 02:09:43 +0000 (11:09 +0900)]
analyze: skip to check ExecCommand for .mount and .swap units
They are not set by a unit file, but dynamically generated.
Fixes a bug caused by
abf0ccc1c6fb81fdcb801566695600a518a28b43.
Fixes #31396.
Zbigniew Jędrzejewski-Szmek [Mon, 19 Feb 2024 11:25:29 +0000 (12:25 +0100)]
logind: drop bitfield annotations
As in other cases, this is simpler but better.
pahole:
- /* size: 336, cachelines: 6, members: 50 */
- /* sum members: 316, holes: 4, sum holes: 19 */
- /* sum bitfield members: 4 bits, bit holes: 1, sum bit holes: 4 bits */
- /* last cacheline: 16 bytes */
+ /* size: 328, cachelines: 6, members: 50 */
+ /* sum members: 320, holes: 3, sum holes: 8 */
+ /* last cacheline: 8 bytes */
Zbigniew Jędrzejewski-Szmek [Mon, 19 Feb 2024 11:20:20 +0000 (12:20 +0100)]
timesyncd: reorder structs instead of useless bitfields
Because of alignment, those bitfields were not doing anything useful,
and were causing the generated code to be more complicated. But in this
case, at least potentially there might be a number of copies of those
structs (if we have a bunch of time servers configured), so let's actually
implement the intended space savings by reording the fields to reduce the
size of holes.
Zbigniew Jędrzejewski-Szmek [Mon, 19 Feb 2024 11:11:19 +0000 (12:11 +0100)]
systemctl: drop pointless bitfield
Zbigniew Jędrzejewski-Szmek [Mon, 19 Feb 2024 11:10:34 +0000 (12:10 +0100)]
sysupdate: drop pointless bitfields
Again, even without considering how many copies of the struct there
can be, this bitfield is useless because of alignment.
Zbigniew Jędrzejewski-Szmek [Mon, 19 Feb 2024 11:02:55 +0000 (12:02 +0100)]
core/kmod-setup: drop another pointless bitfield annotation
We have two bools followed by a func pointer, which is aligned to e.g. 8 bytes,
so whether the two bools take one bit, one byte, or even a full word, makes no
difference in storage size. But the code generated to service a bitfield is
more complicated.
Also switch to FOREACH_ARRAY().
Yu Watanabe [Tue, 20 Feb 2024 06:24:09 +0000 (15:24 +0900)]
network/ndisc: set IPv6 neighbor reachable time
Closes #31402.
Yu Watanabe [Tue, 20 Feb 2024 06:10:59 +0000 (15:10 +0900)]
sd-ndisc: introduce sd_ndisc_router_get_reachable_time()
Yu Watanabe [Mon, 19 Feb 2024 01:37:23 +0000 (10:37 +0900)]
network/ndisc: ignore most fields of RA header when lifetime is zero