systemd/.git
6 years agoConsider smb3 as remote filesystem
Kenneth D'souza [Mon, 30 Sep 2019 10:31:21 +0000 (16:01 +0530)]
Consider smb3 as remote filesystem

Currently systemd will treat smb3 as local filesystem and cause
can't boot failures. Add smb3 to the list of remote filesystems
to fix this issue.

Signed-off-by: Kenneth D'souza <kdsouza@redhat.com>
(cherry picked from commit ff7d6a740b0c6fa3be63d3908a0858730a0837c5)

6 years agoHandle d_type == DT_UNKNOWN correctly
Michael Olbrich [Sun, 29 Sep 2019 11:43:00 +0000 (13:43 +0200)]
Handle d_type == DT_UNKNOWN correctly

As documented in the man-page, readdir() may return a directory entry with
d_type == DT_UNKNOWN. This must be handled for regular filesystems.

dirent_ensure_type() is available to set d_type if necessary. Use it in
some more places.

Without this systemd will fail to boot correctly with nfsroot and some
other filesystems.

Closes #13609

(cherry picked from commit 28e68bb23547cbc11cd3f62a1a38dbe2b387b370)

6 years agoutil-lib: Don't propagate EACCES from find_binary PATH lookup to caller
Chris Down [Wed, 25 Sep 2019 16:09:38 +0000 (17:09 +0100)]
util-lib: Don't propagate EACCES from find_binary PATH lookup to caller

On one of my test machines, test-path-util was failing because the
find_binary("xxxx-xxxx") was returning -EACCES instead of -ENOENT. This
happens because the PATH entry on that host contains a directory which
the user in question doesn't have access to. Typically applications
ignore permission errors when searching through PATH, for example in
bash:

    $ whoami
    cdown
    $ PATH=/root:/bin type sh
    sh is /bin/sh

This behaviour is present on zsh and other shells as well, though. This
patch brings our PATH search behaviour closer to other major Unix tools.

(cherry picked from commit 4e1ddb661272ddb2f03d6046369c973657dfdd62)

6 years agonetwork: drop noisy log message
Yu Watanabe [Wed, 25 Sep 2019 15:21:00 +0000 (00:21 +0900)]
network: drop noisy log message

Closes #13595.

(cherry picked from commit 55a1729fd095f2e0733247e7b4911cf41bf6b2ed)

6 years agoUpdated log message when the timesync happens for the first time (#13624)
cbzxt [Wed, 25 Sep 2019 15:02:46 +0000 (20:32 +0530)]
Updated log message when the timesync happens for the first time (#13624)

(cherry picked from commit 37afb0ac787783a1635165b8a4e3ba5fbd007dfd)

6 years agounits: make systemd-binfmt.service easier to work with no autofs
Zbigniew Jędrzejewski-Szmek [Wed, 18 Sep 2019 10:01:41 +0000 (12:01 +0200)]
units: make systemd-binfmt.service easier to work with no autofs

See https://bugzilla.redhat.com/show_bug.cgi?id=1731772:
when autofs4 is disabled in the kernel,
proc-sys-fs-binfmt_misc.automount is not started, so the binfmt_misc module is
never loaded. If we added a dependency on proc-sys-fs-binfmt_misc.mount
to systemd-binfmt.service, things would work even if autofs4 was disabled, but
we would unconditionally pull in the module and mount, which we don't want to do.
(Right now we ony load the module if some binfmt is configured.)
But let's make it easier to handle this case by doing two changes:
1. order systemd-binfmt.service after the .mount unit (so that the .service
   can count on the mount if both units are pulled in, even if .automount
   is skipped)
2. add [Install] section to the service unit. This way the user can do
   'systemctl enable proc-sys-fs-binfmt_misc.mount' to get the appropriate behaviour.

(cherry picked from commit 508133917d9628f8c0adc5db34d595196b72b1c8)

6 years agoCorect man page reference in systemd-nologin.conf comments
Steve Traylen [Tue, 24 Sep 2019 07:48:03 +0000 (09:48 +0200)]
Corect man page reference in systemd-nologin.conf comments

The reference to the man page of `systemd-user-sessions.service`
in the comments of `tmpfiles.d/systemd-nologin.conf` is corrected.

(cherry picked from commit 7a72a95741970fa4919f137f6844fe11b951efd3)

6 years agoman: Add a missing space in machinectl(1)
Philip Withnall [Tue, 24 Sep 2019 15:07:23 +0000 (16:07 +0100)]
man: Add a missing space in machinectl(1)

Signed-off-by: Philip Withnall <withnall@endlessm.com>
(cherry picked from commit abdc57dfe149bfba79af094fd623eb9929eff5e3)

6 years agolog: Add missing "%" in "%m" log format strings
Filipe Brandenburger [Tue, 24 Sep 2019 22:31:27 +0000 (15:31 -0700)]
log: Add missing "%" in "%m" log format strings

These were clearly intended to be "%m" to display the human readable version
of the error stored in errno.

(cherry picked from commit 28b77ab246b88d05076080bbd69ca3c353fa0f27)

6 years agopid1: do not warn if /run/systemd/relabel-extra.d/ doesn't exist
Zbigniew Jędrzejewski-Szmek [Wed, 18 Sep 2019 15:52:30 +0000 (17:52 +0200)]
pid1: do not warn if /run/systemd/relabel-extra.d/ doesn't exist

After all, that is the expected state.

(cherry picked from commit 90b059b608d6c53c8efb23b8791190dffadd1a17)

6 years agoman: fix typo
Michael Biebl [Sat, 21 Sep 2019 15:06:25 +0000 (17:06 +0200)]
man: fix typo

(cherry picked from commit decef551afaff9fb72f3cde499c9c1bcd23e5874)

6 years agodhcp6: use unaligned_read_be32() v243.2
Yu Watanabe [Wed, 18 Sep 2019 13:14:45 +0000 (22:14 +0900)]
dhcp6: use unaligned_read_be32()

Closes #13591.

(cherry picked from commit 0eb5e6d3f08c6b3a41cfa7ac02bcc6302259ed4a)

6 years agodhcp6: add missing option length check
Yu Watanabe [Tue, 17 Sep 2019 13:18:49 +0000 (22:18 +0900)]
dhcp6: add missing option length check

Closes #13578.

(cherry picked from commit 6ffe71d0e22326f8ea5775c188ae0e13573cd123)

6 years agondisc: make first solicit delayed randomly
Yu Watanabe [Fri, 6 Sep 2019 18:36:19 +0000 (03:36 +0900)]
ndisc: make first solicit delayed randomly

Closes #13460.

(cherry picked from commit 9973e6c43abb9d3d73fcfee83c886dbd32e700ca)

6 years agodhcp6: read OPTION_INFORMATION_REFRESH_TIME option
Yu Watanabe [Fri, 6 Sep 2019 18:29:46 +0000 (03:29 +0900)]
dhcp6: read OPTION_INFORMATION_REFRESH_TIME option

Fixes #13460.

(cherry picked from commit fcb51238e0523d64a698b8738a15bbc1aea9febe)

6 years agol10n: update Czech Translation
AsciiWolf [Thu, 19 Sep 2019 13:36:42 +0000 (15:36 +0200)]
l10n: update Czech Translation

(cherry picked from commit 1697a28567628ba0c2cb69ab36a7c80e66c01aa0)

6 years agosd-radv: if lifetime < SD_RADV_DEFAULT_MAX_TIMEOUT_USEC, adjust timeout (#13491)
Georg Müller [Fri, 20 Sep 2019 08:23:45 +0000 (10:23 +0200)]
sd-radv: if lifetime < SD_RADV_DEFAULT_MAX_TIMEOUT_USEC, adjust timeout (#13491)

The RFC states that lifetime (AdvDefaultLifetime) must be at least
MaxRtrAdvInterval (which more or less corresponds to SD_RADV_DEFAULT_MAX_TIMEOUT_USEC
in systemd).

To fulfill this limit, virtually lower MaxRtrAdvInterval and MinRtrAdvInterval
accordingly.

Also check that min is not lower than 3s and max is not lower than 4s.

(cherry picked from commit ef90b6a4fb9509f61b9b917bbe4db7343afe1853)

6 years agopolkit: fix typo
AsciiWolf [Thu, 19 Sep 2019 12:34:31 +0000 (14:34 +0200)]
polkit: fix typo

(cherry picked from commit 984b96aa7a793f74747b0349f0ed68e992ae17b2)

6 years agosd-netlink: fix invalid assertion
Yu Watanabe [Sun, 15 Sep 2019 13:50:36 +0000 (22:50 +0900)]
sd-netlink: fix invalid assertion

It is natural that n_attiributes is less than type. But in that case,
the message does not contain any message about the type. So, we should
not abort execution with assertion, but just return -ENODATA.

(cherry picked from commit 48fb0d1301c78112360df943f2b6ebeb545b8510)

6 years agonetwork: do not enter failed state if device's sysfs entry does not exist yet
Yu Watanabe [Tue, 17 Sep 2019 12:34:06 +0000 (21:34 +0900)]
network: do not enter failed state if device's sysfs entry does not exist yet

(cherry picked from commit 4d59e14f321d50cbdec1a2ef702e2d258e377356)

6 years agonetwork: add missing link->network checks
Yu Watanabe [Tue, 17 Sep 2019 12:29:23 +0000 (21:29 +0900)]
network: add missing link->network checks

When the function is called, no network file may be assigned to the
link.

(cherry picked from commit b1b0b42e48303134731e017a108c6c334ef5f4c8)

6 years agopath: stop watching path specs once we triggered the target unit
Michal Sekletar [Mon, 9 Sep 2019 12:38:35 +0000 (14:38 +0200)]
path: stop watching path specs once we triggered the target unit

We start watching them again once we get a notification that triggered
unit entered inactive or failed state.

Fixes: #10503
(cherry picked from commit 8fca6944c2ee20c63d62154c8badddc77170b176)

6 years agohwdb: add Medion Akoya E2292 (#13498)
matthiasroos [Mon, 16 Sep 2019 19:10:15 +0000 (21:10 +0200)]
hwdb: add Medion Akoya E2292 (#13498)

Fixes #13480.

(cherry picked from commit 358e50fa7fab98509f2ef96cd8d6d7d1af6ed59a)

6 years agopo: update Brazilian Portuguese translation
Rafael Fontenelle [Sun, 8 Sep 2019 22:08:14 +0000 (19:08 -0300)]
po: update Brazilian Portuguese translation

(cherry picked from commit bf55a2df4da0234932c0949801579a9a9dca72bc)

6 years agopo: update Polish translation
Piotr Drąg [Sat, 14 Sep 2019 10:44:57 +0000 (12:44 +0200)]
po: update Polish translation

(cherry picked from commit 9870c55ef5df8f079cd972b409ec59414869a256)

6 years agopolkit: change "revert settings" to "reset settings"
Zbigniew Jędrzejewski-Szmek [Sun, 8 Sep 2019 14:13:15 +0000 (16:13 +0200)]
polkit: change "revert settings" to "reset settings"

"reset" is more understandable. The verb is "revert", but it might actually be
better to have a description which uses different words instead of duplicating
the name of the command.

https://github.com/systemd/systemd/commit/379158684abd981cc760342aad61b1c813b71eb2#commitcomment-34992552
(cherry picked from commit ea2552639b22004c89df26f2374e3d3f1d2acace)

6 years agoman: fix description of ARPIntervalSec= units
Zbigniew Jędrzejewski-Szmek [Thu, 12 Sep 2019 09:15:35 +0000 (11:15 +0200)]
man: fix description of ARPIntervalSec= units

https://bugzilla.redhat.com/show_bug.cgi?id=1751363
(cherry picked from commit 06c52cc2b7c6cf2729e130f2a23c5a7ce62e27b9)

6 years agohwdb: axis override for Dell 9360 touchpad
baybal [Wed, 11 Sep 2019 02:08:59 +0000 (08:08 +0600)]
hwdb: axis override for Dell 9360 touchpad

and possibly other XPS models sharing the touchpad (#13472)

(cherry picked from commit 26fe3af8ae7d52847eb3f2267eaa3df3af90d811)

6 years agotest: drop the missed || exit 1 expression
Frantisek Sumsal [Sat, 10 Aug 2019 14:05:07 +0000 (16:05 +0200)]
test: drop the missed || exit 1 expression

...as we've already done in the rest of the testsuite, see
cc469c3dfc398210f38f819d367e68646c71d8da

(cherry picked from commit 67c434b03f8a24f5350f017dfb4b2464406046db)

6 years agoudevadm: use usec_add()
Yu Watanabe [Tue, 17 Sep 2019 16:28:23 +0000 (01:28 +0900)]
udevadm: use usec_add()

Also fixes description of event source.

(cherry picked from commit f6e8ba816577a1a26037a8aeae23fda36d74f0ac)

6 years agoudevadm: missing initialization of descriptor
Yu Watanabe [Tue, 17 Sep 2019 15:52:07 +0000 (00:52 +0900)]
udevadm: missing initialization of descriptor

(cherry picked from commit 2f5b282aab78bd2378df428c57c5fd1cc09e9f4f)

6 years agonetworkd: unbreak routing_policy_rule_compare_func()
Zbigniew Jędrzejewski-Szmek [Tue, 17 Sep 2019 17:27:58 +0000 (19:27 +0200)]
networkd: unbreak routing_policy_rule_compare_func()

!r is the same r == 0, so this was short-circuiting the comparison when
streq(a->iff, b->iff) or streq(a->off, b->off). Before the parent commit which
moved those comparisons to the end, this was short-circuiting quite a bit
of the comparison function.

(cherry picked from commit 314ed4f9948bb73300862935546a63294bba1d5c)

6 years agocore: coldplug possible nop_job
ypf791 [Fri, 19 Jul 2019 10:28:04 +0000 (18:28 +0800)]
core: coldplug possible nop_job

(cherry picked from commit b49e14d5f3081dfcd363d8199a14c0924ae9152f)

6 years agotty-ask-pwd-agent: fix message forwarded to wall(1)
Franck Bui [Mon, 16 Sep 2019 20:03:43 +0000 (22:03 +0200)]
tty-ask-pwd-agent: fix message forwarded to wall(1)

Commit a1c111c2d12429d2 wrongly replaced '!' with ':' when the message is
forwarded to wall(1).

Indeed in this case we are not requesting the user for providing a password but
instead we are simply displaying a message to suggest starting
tty-ask-password-agent for providing the password.

(cherry picked from commit 65943cc3507bf54390d598e06df60771e913fb72)

6 years agocore: Fix setting StatusUnitFormat from config files
Maciej Stanczew [Mon, 16 Sep 2019 00:09:35 +0000 (02:09 +0200)]
core: Fix setting StatusUnitFormat from config files

(cherry picked from commit 6327aa9f6c5701e44541e685c6bf44d3a8c40f50)

6 years agonetwork DHCP4: Dont mislead the logs.
Susant Sahani [Mon, 16 Sep 2019 18:46:39 +0000 (20:46 +0200)]
network DHCP4: Dont mislead the logs.

The debug log making sense to the end user as an error.

(cherry picked from commit 61cda4d7964ff00dfa6260f84219720d9b97671a)

6 years agoUpdate m4 for selective utmp support.
Donald A. Cupp Jr [Thu, 5 Sep 2019 22:03:54 +0000 (15:03 -0700)]
Update m4 for selective utmp support.
modified:   tmpfiles.d/systemd.conf.m4

(cherry picked from commit d34a58222de4c2ee93c68411b4f9042f08e5132f)

6 years agocore: restore initialization of u->source_mtime
Franck Bui [Thu, 5 Sep 2019 14:53:50 +0000 (16:53 +0200)]
core: restore initialization of u->source_mtime

During the rework of unit file loading, commit e8630e695232bdfc dropped the
initialization u->source_mtime. This had the bad side effect that generated
units always needed daemon reloading.

(cherry picked from commit 5a1c1b534fe13e60ef9bce0dc680ad6f2a0c577f)

6 years agomount-setup: relabel items mentioned directly in relabel-extra.d
Benjamin Gilbert [Wed, 11 Sep 2019 03:23:59 +0000 (23:23 -0400)]
mount-setup: relabel items mentioned directly in relabel-extra.d

relabel_extra() relabels the descendants of directories listed in
relabel-extra.d, but doesn't relabel the files or directories
explicitly named there.  This makes it impossible to use
relabel-extra.d to relabel the root of a filesystem.  Fix by
relabeling the named items too.

(cherry picked from commit 71de68476c1897b8624538ce32218891251fa5f6)

6 years agoCall getgroups() to know size of supplementary groups array to allocate
Renaud Métrich [Fri, 13 Sep 2019 09:18:18 +0000 (11:18 +0200)]
Call getgroups() to know size of supplementary groups array to allocate

Resolves RHBZ #1743230 - journalctl dumps core when stack limit is reduced to 256 KB

(cherry picked from commit f5e0b942af1e86993c21f4e5c84342bb10403dac)

6 years agotest: add test cases for empty string match
Yu Watanabe [Wed, 11 Sep 2019 00:06:15 +0000 (09:06 +0900)]
test: add test cases for empty string match

(cherry picked from commit 48d26c90852c22ec94be961f5fbdcf462bb9a6e8)

6 years agoudev: fix multi match
Yu Watanabe [Tue, 10 Sep 2019 23:50:21 +0000 (08:50 +0900)]
udev: fix multi match

Fixes #13518.

(cherry picked from commit 067cc51f2e6eb94305556597f0254f115857ff49)

6 years agoman: move TimeoutCleanSec= entry from .service to .exec
Yu Watanabe [Fri, 13 Sep 2019 08:12:59 +0000 (17:12 +0900)]
man: move TimeoutCleanSec= entry from .service to .exec

Follow-up for 12213aed128456af33ff6131a14b637318227346.

Closes #13546.

(cherry picked from commit bd9014c360f86aefcf4d417d50372a5fc29af7ce)

6 years agozsh: udpate bootctl completions
Ronan Pigott [Thu, 12 Sep 2019 17:13:13 +0000 (10:13 -0700)]
zsh: udpate bootctl completions

(cherry picked from commit 4f6c7276372a458e81402ba38bfae2e3ba3f1154)

6 years agoresolved: fix abort when recv() returns 0
Zbigniew Jędrzejewski-Szmek [Thu, 12 Sep 2019 12:52:08 +0000 (14:52 +0200)]
resolved: fix abort when recv() returns 0

https://bugzilla.redhat.com/show_bug.cgi?id=1703598
(cherry picked from commit f731fd5be61858b724e0f13b3ff1131c1977654a)

6 years agoman: remove repeated words
Zbigniew Jędrzejewski-Szmek [Sat, 7 Sep 2019 13:16:35 +0000 (15:16 +0200)]
man: remove repeated words

https://github.com/systemd/systemd/commit/b5328434c91b10ad49647e2352e62b1fbdce329d#commitcomment-34989175
(cherry picked from commit ff7cfff0c446ce8ba901f8fc531171fb727a9a5d)

6 years agohwdb: Also mark lis3lv02d sensors in "HP" laptops as being in the base
Bastien Nocera [Thu, 12 Sep 2019 17:02:35 +0000 (19:02 +0200)]
hwdb: Also mark lis3lv02d sensors in "HP" laptops as being in the base

We matched "*Hewlett-Packard*" laptops but not "*HP*" laptops, which
caused a regression for the HP Elite Book 850 G3.

Fixes: 4247938ee13e23eae1afcecbe646de5283b7afc2

Closes: #13543
(cherry picked from commit d7cf4984b0e3255ef9d6872c96a210271b0c949a)

6 years agoudev: also logs file permission
Yu Watanabe [Sun, 8 Sep 2019 16:29:27 +0000 (01:29 +0900)]
udev: also logs file permission

(cherry picked from commit 20eef7c55cfdd83f953c6a332aaad0caba4fb60f)

6 years agoudev: add missing flag for OPTIONS=static_node
Yu Watanabe [Sun, 8 Sep 2019 16:27:56 +0000 (01:27 +0900)]
udev: add missing flag for OPTIONS=static_node

Fixes RHBZ#1740664.

(cherry picked from commit 5abba26e2f9eb9336e701228220f0ef62c95f316)

6 years agonetwork: do not abort execution when a config file cannot be loaded
Yu Watanabe [Wed, 11 Sep 2019 09:24:41 +0000 (18:24 +0900)]
network: do not abort execution when a config file cannot be loaded

Closes #13516.

(cherry picked from commit be7110826eb4d7d0fafee4790562e0dedb9d817b)

6 years agofileio: update warning message
Yu Watanabe [Wed, 11 Sep 2019 09:11:19 +0000 (18:11 +0900)]
fileio: update warning message

(cherry picked from commit 0f93577647cef5f683d83e89cc63f6124885e708)

6 years agopstore: fix use after free
Michael Olbrich [Fri, 6 Sep 2019 13:04:01 +0000 (15:04 +0200)]
pstore: fix use after free

The memory is still needed in the sd_journal_sendv() after the 'if' block.

(cherry picked from commit 1e19f5ac0d680a63eccae7ef1fc6ce225dca0bbf)

6 years agojournal: Make the output of --update-catalog deterministic
Daniel Edgecumbe [Thu, 5 Sep 2019 14:34:52 +0000 (15:34 +0100)]
journal: Make the output of --update-catalog deterministic

The use of an unordered hashmap means that the output of
'journalctl --update-catalog' differs between runs despite there being no
changes in the input files.

By changing all instances of Hashmap to OrderedHashmap we fix this, and now
the catalog is reproducible.

Motivation: https://reproducible-builds.org

Signed-off-by: Daniel Edgecumbe <git@esotericnonsense.com>
(cherry picked from commit a95686bb5d615a73a14d451a25225a566f9af570)

6 years agotravis: protect the systemd organization on Fuzzit from forks v243.1
Evgeny Vereshchagin [Fri, 6 Sep 2019 01:44:52 +0000 (01:44 +0000)]
travis: protect the systemd organization on Fuzzit from forks

Now that v243 is out, the script has been pulled by forks that are
activated on Travis CI. As a result, all those forks have started to send
their fuzzers to Fuzzit inadvertantly consuming our CPUs along the way.
Let's prevent this by bailing out early if the script is run outside of
the systemd repository.

6 years agohwdb: Mark lis3lv02d sensors in HP laptops as being in the base
Hans de Goede [Thu, 5 Sep 2019 12:16:12 +0000 (14:16 +0200)]
hwdb: Mark lis3lv02d sensors in HP laptops as being in the base

The lis3lv02d sensor used in many HP laptops is (almost) always intented
primarily for freefall detection / HDD protection and (almost) always
is located in the base of a classic clamshell laptop

Before we had the ACCEL_LOCATION udev property the issues this caused
with screen-rotation were fixed by applying a mount-matrix which
translates base-coordinates to display-coordinates assuming the display
is at an angle of exact 90 degrees to the base (swap Y and Z axis).

The comment calls this translate "from "can play neverball" to
"matches Windows 8 orientation"" but what it really does is translate
base accel-axis to display accel-axis. Thus allows rotating the screen
if you put the laptop on its side, but no-one normally does that with
a 2Kg clamshell laptop.

The obviously correct thing to do on classic clamshell laptops (not 2-in-1s)
is to disable automatic screen rotation. This commit marks the accelerometer
in these laptops as being part of the base, which will make iio-sensor-proxy
disable automatic screen rotation.

This commit also removes the orientation-matrix since the unmodified coordinates
coming from the sensor are oriented correctly for a sensor in the base.

Also see the "Bad accelerometer values cause incorrect screen rotation"
systemd-devel mail-thread from September 2019.

6 years agopo: update Japanese translation
Yu Watanabe [Wed, 4 Sep 2019 00:16:40 +0000 (09:16 +0900)]
po: update Japanese translation

6 years agodocs: fix push recipe in RELEASE.md
Zbigniew Jędrzejewski-Szmek [Tue, 3 Sep 2019 09:34:09 +0000 (11:34 +0200)]
docs: fix push recipe in RELEASE.md

6 years agoman/systemctl.xml: fix missing "not"
Carlo Teubner [Wed, 4 Sep 2019 17:58:56 +0000 (18:58 +0100)]
man/systemctl.xml: fix missing "not"

6 years agodocs: fix typo in boot loader doc
nikolas [Wed, 4 Sep 2019 16:21:14 +0000 (12:21 -0400)]
docs: fix typo in boot loader doc

6 years agopstore: fix typo in error message - directoy -> directory
nikolas [Wed, 4 Sep 2019 16:07:06 +0000 (12:07 -0400)]
pstore: fix typo in error message - directoy -> directory

6 years agoFix typo in comment: overide -> override
nikolas [Wed, 4 Sep 2019 16:03:56 +0000 (12:03 -0400)]
Fix typo in comment: overide -> override

6 years agopo: update Polish translation
Piotr Drąg [Tue, 3 Sep 2019 17:05:27 +0000 (19:05 +0200)]
po: update Polish translation

6 years agoUpdate NEWS for v243 v243
Zbigniew Jędrzejewski-Szmek [Tue, 3 Sep 2019 09:15:37 +0000 (11:15 +0200)]
Update NEWS for v243

6 years agoNEWS: update contributors list
Zbigniew Jędrzejewski-Szmek [Tue, 3 Sep 2019 08:42:00 +0000 (10:42 +0200)]
NEWS: update contributors list

6 years agoMerge pull request #13457 from keszybz/resolved-issue
Zbigniew Jędrzejewski-Szmek [Tue, 3 Sep 2019 09:27:03 +0000 (11:27 +0200)]
Merge pull request #13457 from keszybz/resolved-issue

6 years agoMerge pull request #13440 from keszybz/failing-condtion-check
Zbigniew Jędrzejewski-Szmek [Tue, 3 Sep 2019 08:04:05 +0000 (10:04 +0200)]
Merge pull request #13440 from keszybz/failing-condtion-check

Revert "core: check start limit on condition checks too"

6 years agologind: fix property emission on Sessions
Your Name [Mon, 2 Sep 2019 15:54:36 +0000 (17:54 +0200)]
logind: fix property emission on Sessions

We would not send the property because we'd call sd_bus_get_current_message()
which would return NULL. If there is no message, we cannot support /self or
/auto, but things are still OK if a path with a session name is given.

Traceback when the issue is triggered:

 #2  we'd call sd_bus_get_current_message() here, which would return NULL, and
     session_object_find() would immediately return 0.
 #3  0x00000000004289b7 in session_object_find (bus=0x9f1110, path=0xa160b0 "/org/freedesktop/login1/session/c2",
     interface=0x9efda0 "org.freedesktop.login1.Session", userdata=0x9852f0, found=0x7ffe3e975fe8, error=0x7ffe3e9760b0)
     at ../src/login/logind-session-dbus.c:620
 #4  0x00007ff74bfdde39 in node_vtable_get_userdata (bus=0x9f1110, path=0xa160b0 "/org/freedesktop/login1/session/c2",
     c=0x9f6d58, userdata=0x7ffe3e976070, error=0x7ffe3e9760b0) at ../src/libsystemd/sd-bus/bus-objects.c:37
 #5  0x00007ff74bfe49af in emit_properties_changed_on_interface (bus=0x9f1110,
     prefix=0xa133a0 "/org/freedesktop/login1/session", path=0xa160b0 "/org/freedesktop/login1/session/c2",
     interface=0x43f9f8 "org.freedesktop.login1.Session", require_fallback=true, found_interface=0x7ffe3e976163,
     names=0x7ffe3e9761b0) at ../src/libsystemd/sd-bus/bus-objects.c:2088
 #6  0x00007ff74bfe56a4 in sd_bus_emit_properties_changed_strv (bus=0x9f1110,
     path=0xa160b0 "/org/freedesktop/login1/session/c2", interface=0x43f9f8 "org.freedesktop.login1.Session",
     names=0x7ffe3e9761b0) at ../src/libsystemd/sd-bus/bus-objects.c:2291
 #7  0x00000000004292ea in session_send_changed (s=0xa16e10, properties=0x43ee27 "Active")
    at ../src/login/logind-session-dbus.c:730
 #8  0x0000000000424cd7 in seat_set_active (s=0x9ee280, session=0xa16e10) at ../src/login/logind-seat.c:249
 #9  0x00000000004251cf in seat_active_vt_changed (s=0x9ee280, vtnr=3) at ../src/login/logind-seat.c:361
 #10 0x000000000042547b in seat_read_active_vt (s=0x9ee280) at ../src/login/logind-seat.c:395
 #11 0x000000000040ab5c in manager_dispatch_console (s=0x9f0320, fd=8, revents=8, userdata=0x9852f0)
     at ../src/login/logind.c:588
 #12 0x00007ff74c042d5f in source_dispatch (s=0x9f0320) at ../src/libsystemd/sd-event/sd-event.c:2828
 #13 0x00007ff74c04469f in sd_event_dispatch (e=0x9ef340) at ../src/libsystemd/sd-event/sd-event.c:3241
 #14 0x00007ff74c044b58 in sd_event_run (e=0x9ef340, timeout=18446744073709551615)
     at ../src/libsystemd/sd-event/sd-event.c:3299
 #15 0x000000000040d7e8 in manager_run (m=0x9852f0) at ../src/login/logind.c:1186
 #16 0x000000000040db58 in run (argc=1, argv=0x7ffe3e976728) at ../src/login/logind.c:1234
 #17 0x000000000040dc30 in main (argc=1, argv=0x7ffe3e976728) at ../src/login/logind.c:1244

Fixes #13437. Bug introduced in 3b92c086a8d5338e2164ffa0ae48b3d03d10cfb5.

6 years agologin: fix use after free
Yu Watanabe [Mon, 2 Sep 2019 16:55:46 +0000 (01:55 +0900)]
login: fix use after free

id is basename(state_file)

6 years agohwdb: Add HP Elitebook 850 G3 laptop accelerometer location quirk
Jan-Michael Brummer [Mon, 2 Sep 2019 15:04:07 +0000 (17:04 +0200)]
hwdb: Add HP Elitebook 850 G3 laptop accelerometer location quirk

6 years agoshell-completion: do not truncate suggestions
Yu Watanabe [Sat, 31 Aug 2019 18:20:41 +0000 (03:20 +0900)]
shell-completion: do not truncate suggestions

6 years agonetwork: adjust log level when DHCPv4 lease lost
Yu Watanabe [Sat, 31 Aug 2019 18:49:17 +0000 (03:49 +0900)]
network: adjust log level when DHCPv4 lease lost

6 years agoGenerate stable machine-id and DHCP client ID on POWER KVM.
Dimitri John Ledkov [Mon, 15 Apr 2019 14:07:52 +0000 (15:07 +0100)]
Generate stable machine-id and DHCP client ID on POWER KVM.

6 years agoMerge pull request #13385 from yuwata/core-remove-private-directories-13355
Zbigniew Jędrzejewski-Szmek [Sat, 31 Aug 2019 07:28:39 +0000 (09:28 +0200)]
Merge pull request #13385 from yuwata/core-remove-private-directories-13355

core: also remove private directories by systemctl clean

6 years agoman: list possible action string and default value
Yu Watanabe [Sat, 31 Aug 2019 04:57:34 +0000 (13:57 +0900)]
man: list possible action string and default value

Closes #13442.

6 years agoAdd HP Elite x2 1013 G3 touchpad as external
RussianNeuroMancer [Fri, 30 Aug 2019 15:23:30 +0000 (23:23 +0800)]
Add HP Elite x2 1013 G3 touchpad as external

HP Elite x2 1013 G3 have external touchpad: http://h10032.www1.hp.com/ctg/Manual/c06077534 (page 12)

Marking it as external resolve this issue: https://gitlab.freedesktop.org/libinput/libinput/issues/351

6 years agoMerge pull request #13436 from systemd/hidden-units-are-good-units
Yu Watanabe [Fri, 30 Aug 2019 17:53:54 +0000 (02:53 +0900)]
Merge pull request #13436 from systemd/hidden-units-are-good-units

Hidden units are good units

6 years agoDrop dbus activation stub service
Michael Biebl [Fri, 23 Aug 2019 21:34:45 +0000 (23:34 +0200)]
Drop dbus activation stub service

This fixes the following problem:

> At the very end of the boot, just after the first user logs in
> (usually using sddm / X) I get the following messages in my logs:
> Nov 18 07:02:33 samd dbus-daemon[2879]: [session uid=1000 pid=2877] Activated service 'org.freedesktop.systemd1' failed: Process org.freedesktop.systemd1 exited with status 1
> Nov 18 07:02:33 samd dbus-daemon[2879]: [session uid=1000 pid=2877] Activated service 'org.freedesktop.systemd1' failed: Process org.freedesktop.systemd1 exited with status 1

These messages are caused by the "stub" service files that systemd
installs. It installed them because early versions of systemd activation
required them to exist.

Since dbus 1.11.0, a dbus-daemon that is run with --systemd-activation
automatically assumes that o.fd.systemd1 is an activatable
service. As a result, with a new enough dbus version,
/usr/share/dbus-1/services/org.freedesktop.systemd1.service and
/usr/share/dbus-1/system-services/org.freedesktop.systemd1.service should
become unnecessary, and they can be removed.

dbus 1.11.0 was released 2015-12-02.

Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=914015

6 years agoRevert "core: check start limit on condition checks too"
Zbigniew Jędrzejewski-Szmek [Fri, 30 Aug 2019 16:21:05 +0000 (18:21 +0200)]
Revert "core: check start limit on condition checks too"

This reverts commit 2de9b9793b91f492141f090dcc89445511e94bd4.

This check causes regressions, in particular our own units fail. Apparently, it
is enough for the unit to be referenced enough times:

$ journalctl -b -u systemd-ask-password-console.path
Aug 30 12:08:14 krowka systemd[1]: Condition check resulted in Dispatch Password Requests to Console Directory Watch being skipped.
Aug 30 12:08:33 krowka systemd[1]: Condition check resulted in Dispatch Password Requests to Console Directory Watch being skipped.
Aug 30 12:08:33 krowka systemd[1]: Condition check resulted in Dispatch Password Requests to Console Directory Watch being skipped.
Aug 30 12:08:33 krowka systemd[1]: Condition check resulted in Dispatch Password Requests to Console Directory Watch being skipped.
Aug 30 12:08:33 krowka systemd[1]: Condition check resulted in Dispatch Password Requests to Console Directory Watch being skipped.
Aug 30 12:08:33 krowka systemd[1]: systemd-ask-password-console.path: Start request repeated too quickly.
Aug 30 12:08:33 krowka systemd[1]: Failed to start Dispatch Password Requests to Console Directory Watch.

$ journalctl -b -u systemd-firstboot.service
-- Logs begin at Sun 2019-04-21 12:39:21 CEST, end at Fri 2019-08-30 12:23:06 CEST. --
Aug 30 12:08:33 krowka systemd[1]: Condition check resulted in First Boot Wizard being skipped.
Aug 30 12:08:33 krowka systemd[1]: Condition check resulted in First Boot Wizard being skipped.
Aug 30 12:08:33 krowka systemd[1]: Condition check resulted in First Boot Wizard being skipped.
Aug 30 12:08:33 krowka systemd[1]: Condition check resulted in First Boot Wizard being skipped.
Aug 30 12:08:33 krowka systemd[1]: systemd-firstboot.service: Start request repeated too quickly.
Aug 30 12:08:33 krowka systemd[1]: Failed to start First Boot Wizard.

And the same for other units.

Fixes #13434.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=935829

6 years agoshared/virt: update link to vmware article
Zbigniew Jędrzejewski-Szmek [Fri, 30 Aug 2019 11:09:23 +0000 (13:09 +0200)]
shared/virt: update link to vmware article

As suggested in https://github.com/systemd/systemd/pull/13430#issuecomment-526551085.

6 years agoshared/unit-files: only put valid unit paths and dropin dirs in the cache
Zbigniew Jędrzejewski-Szmek [Fri, 30 Aug 2019 12:10:42 +0000 (14:10 +0200)]
shared/unit-files: only put valid unit paths and dropin dirs in the cache

6 years agoshared/unit-files: we must not filter out names starting with a dot
Zbigniew Jędrzejewski-Szmek [Fri, 30 Aug 2019 12:10:08 +0000 (14:10 +0200)]
shared/unit-files: we must not filter out names starting with a dot

Fixes #13380.

6 years agodocs: describe valid unit names in systemd.unit(5)
Zbigniew Jędrzejewski-Szmek [Fri, 30 Aug 2019 11:52:33 +0000 (13:52 +0200)]
docs: describe valid unit names in systemd.unit(5)

6 years agoenvironment-d-generator: output logs in debug mode
Zbigniew Jędrzejewski-Szmek [Mon, 26 Aug 2019 20:53:01 +0000 (22:53 +0200)]
environment-d-generator: output logs in debug mode

Those codepaths is only used by that generator, so simply adding a few debug
log lines should be OK.

Fixes #12259.

6 years agoMerge pull request #13384 from yuwata/core-runtime-directory-preserve
Zbigniew Jędrzejewski-Szmek [Fri, 30 Aug 2019 11:00:57 +0000 (13:00 +0200)]
Merge pull request #13384 from yuwata/core-runtime-directory-preserve

core: make RuntimeDirectoryPreserve= works with non-service units

6 years agoAdd System76 touchpad toggle support
Jeremy Soller [Wed, 21 Aug 2019 15:31:35 +0000 (09:31 -0600)]
Add System76 touchpad toggle support

6 years agoMerge pull request #13433 from keszybz/new-security-mailing-list
Zbigniew Jędrzejewski-Szmek [Fri, 30 Aug 2019 10:26:37 +0000 (12:26 +0200)]
Merge pull request #13433 from keszybz/new-security-mailing-list

docs: new systemd-security mailing list

6 years agobasic/virt: Fix current virtualbox detection
Jan Losinski [Thu, 29 Aug 2019 13:45:51 +0000 (15:45 +0200)]
basic/virt: Fix current virtualbox detection

In a current VirtualBox installation the board_vendor is set to "Oracle
Corporation". So we need to add this to the dmi_vendor_table for a
relieable detection.

This fixes #13429

Signed-off-by: Jan Losinski <losinski@wh2.tu-dresden.de>
6 years agodocs: create new SECURITY.md page
Zbigniew Jędrzejewski-Szmek [Fri, 30 Aug 2019 09:45:42 +0000 (11:45 +0200)]
docs: create new SECURITY.md page

github has special support for that name:
https://help.github.com/en/articles/adding-a-security-policy-to-your-repository.

6 years agodocs: new systemd-security mailing list
Zbigniew Jędrzejewski-Szmek [Fri, 30 Aug 2019 07:03:41 +0000 (09:03 +0200)]
docs: new systemd-security mailing list

In the past, we asked people to open a security bug on one of the "big"
distros. This worked OK as far as getting bugs reported and notifying some
upstream developers went. But we always had trouble getting information to
all the appropriate parties, because each time a bug was reported, a big
thread was created, with a growing CC list. People who were not CCed early
enough were missing some information, etc.

To clean this up, we decided to create a private mailing list. The natural
place would be freedesktop.org, but unfortunately the request to create a
mailing list wasn't handled
(https://gitlab.freedesktop.org/freedesktop/freedesktop/issues/134). And even
if it was, at this point, if there was ever another administrative issue, it
seems likely it could take months to resolve. So instead, we asked for a list
to be created on the redhat mailservers.

Please consider the previous security issue reporting mechanisms rescinded, and
send any senstive bugs to systemd-security@redhat.com.

6 years agoman: install runlevel.8 unconditionally
Jan Chren [Wed, 28 Aug 2019 23:30:58 +0000 (23:30 +0000)]
man: install runlevel.8 unconditionally

systemctl supports runlevel invocation name without utmp.
The runlevel symlink is installed unconditionally.
So it's reasonable to install runlevel manpage with it as well.

Signed-off-by: Jan Chren (rindeal) <dev.rindeal@gmail.com>
6 years agomeson: fix incomplete option descriptions
Jan Chren [Wed, 28 Aug 2019 21:50:17 +0000 (21:50 +0000)]
meson: fix incomplete option descriptions

Signed-off-by: Jan Chren (rindeal) <dev.rindeal@gmail.com>
6 years agoMerge pull request #13244 from keszybz/allow-dots-in-usernames
Yu Watanabe [Wed, 28 Aug 2019 15:03:19 +0000 (00:03 +0900)]
Merge pull request #13244 from keszybz/allow-dots-in-usernames

Allow dots in usernames

6 years agocore: move timeout_clean_usec from Service to ExecContext
Yu Watanabe [Sun, 25 Aug 2019 08:47:57 +0000 (17:47 +0900)]
core: move timeout_clean_usec from Service to ExecContext

6 years agotest: add tests for systemctl clean with DynamicUser=yes
Yu Watanabe [Sun, 25 Aug 2019 07:27:33 +0000 (16:27 +0900)]
test: add tests for systemctl clean with DynamicUser=yes

6 years agocore: also remove private directories by systemctl clean
Yu Watanabe [Thu, 22 Aug 2019 16:04:24 +0000 (01:04 +0900)]
core: also remove private directories by systemctl clean

Fixes #13355.

6 years agohwdb: Add HP laptop accelerometer location quirk
Hans de Goede [Wed, 28 Aug 2019 07:28:30 +0000 (09:28 +0200)]
hwdb: Add HP laptop accelerometer location quirk

Add another HP laptop to the list of HP laptops with their
accelerometer in the base.

While at it also fixup the indentation of a neighboring quirk.

6 years agoshared/user-util: emit a warning on names with dots
Zbigniew Jędrzejewski-Szmek [Wed, 28 Aug 2019 10:05:52 +0000 (12:05 +0200)]
shared/user-util: emit a warning on names with dots

6 years agozsh: update journalctl completions
Ronan Pigott [Wed, 28 Aug 2019 05:28:02 +0000 (22:28 -0700)]
zsh: update journalctl completions

6 years agoMerge pull request #13412 from yuwata/network-check-and-warn-more
Yu Watanabe [Wed, 28 Aug 2019 06:23:01 +0000 (15:23 +0900)]
Merge pull request #13412 from yuwata/network-check-and-warn-more

network: check more static IPv6 configurations and add more warnings

6 years agoresolved: query polkit only after parsing the data
Zbigniew Jędrzejewski-Szmek [Tue, 27 Aug 2019 17:28:19 +0000 (19:28 +0200)]
resolved: query polkit only after parsing the data

That's what we do everywhere else because it leads to nicer user experience.