From: Lennart Poettering <lennart@poettering.net>
Date: Mon, 16 Nov 2020 20:04:11 +0000 (+0100)
Subject: resolved: improve debug logging on incoming messages a bit
X-Git-Tag: v248-rc1~56
X-Git-Url: http://git-history.diyao.me/?a=commitdiff_plain;h=f715584018752950c45b79325e4a5a4a9a29db1c;p=systemd%2F.git

resolved: improve debug logging on incoming messages a bit
---

diff --git a/src/resolve/resolved-dns-transaction.c b/src/resolve/resolved-dns-transaction.c
index 260ce76b98..e337012351 100644
--- a/src/resolve/resolved-dns-transaction.c
+++ b/src/resolve/resolved-dns-transaction.c
@@ -1046,7 +1046,8 @@ void dns_transaction_process_reply(DnsTransaction *t, DnsPacket *p, bool encrypt
          * should hence not attempt to access the query or transaction
          * after calling this function. */
 
-        log_debug("Processing incoming packet on transaction %" PRIu16" (rcode=%s).",
+        log_debug("Processing incoming packet of size %zu on transaction %" PRIu16" (rcode=%s).",
+                  p->size,
                   t->id, dns_rcode_to_string(DNS_PACKET_RCODE(p)));
 
         switch (t->scope->protocol) {
@@ -1211,7 +1212,8 @@ void dns_transaction_process_reply(DnsTransaction *t, DnsPacket *p, bool encrypt
                          * servers often do not implement TCP, hence falling back to TCP on fragmentation is
                          * counter-productive there.) */
 
-                        log_debug("Reply fragmented, retrying via TCP.");
+                        log_debug("Reply fragmented, retrying via TCP. (Largest fragment size: %zu; Datagram size: %zu)",
+                                  p->fragsize, p->size);
                         retry_with_tcp = true;
                 }
         }
diff --git a/src/resolve/resolved-manager.c b/src/resolve/resolved-manager.c
index fc5f8c79d3..2ed9f2d47b 100644
--- a/src/resolve/resolved-manager.c
+++ b/src/resolve/resolved-manager.c
@@ -926,8 +926,10 @@ int manager_recv(Manager *m, int fd, DnsProtocol protocol, DnsPacket **ret) {
                         p->ifindex = manager_find_ifindex(m, p->family, &p->destination);
         }
 
-        *ret = TAKE_PTR(p);
+        log_debug("Received %s UDP packet of size %zu, ifindex=%i, ttl=%i, fragsize=%zu",
+                  dns_protocol_to_string(protocol), p->size, p->ifindex, p->ttl, p->fragsize);
 
+        *ret = TAKE_PTR(p);
         return 1;
 }