From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Thu, 20 May 2021 07:14:17 +0000 (+0900)
Subject: network: fix an infinite loop
X-Git-Tag: v248.4~134
X-Git-Url: http://git-history.diyao.me/?a=commitdiff_plain;h=b234ee7859de556c272c36fc691cee4cb08f7230;p=systemd%2F.git

network: fix an infinite loop

Fixes #19467.

(cherry picked from commit e8f99f4e249916e12c09ee5cc9a108cba6a2b5c0)
---

diff --git a/src/network/networkd-link.c b/src/network/networkd-link.c
index 8219d95b0d..c781dd58d7 100644
--- a/src/network/networkd-link.c
+++ b/src/network/networkd-link.c
@@ -157,6 +157,12 @@ static void link_update_master_operstate(Link *link, NetDev *netdev) {
         if (netdev->ifindex <= 0)
                 return;
 
+        /* If an interface is self-mentioned in Bridge= or friends, then it introduces an infinite loop.
+         * FIXME: there still exits a possibility of an infinite loop when two or more interfaces
+         * mention each other in Bridge= or so. We need to detect such a loop. */
+        if (link->ifindex == netdev->ifindex)
+                return;
+
         if (link_get(link->manager, netdev->ifindex, &master) < 0)
                 return;