From: Yu Watanabe <watanabe.yu+github@gmail.com>
Date: Fri, 22 Nov 2024 21:40:22 +0000 (+0900)
Subject: shutdown: propagate one more error from sync_making_progress()
X-Git-Tag: v257-rc3~45
X-Git-Url: http://git-history.diyao.me/?a=commitdiff_plain;h=1e9fb1d4567b37d78941f596040b0548b4982f11;p=systemd%2F.git

shutdown: propagate one more error from sync_making_progress()

No functional change, just refactoring, as anyway all errors will be
ignored by the caller.
---

diff --git a/src/shutdown/shutdown.c b/src/shutdown/shutdown.c
index 57bb9a82d0..e26a8579c5 100644
--- a/src/shutdown/shutdown.c
+++ b/src/shutdown/shutdown.c
@@ -211,10 +211,8 @@ static int sync_making_progress(unsigned long long *prev_dirty) {
                         continue;
 
                 errno = 0;
-                if (sscanf(line, "%*s %llu %*s", &ull) != 1) {
-                        log_warning_errno(errno_or_else(EIO), "Failed to parse /proc/meminfo field, ignoring: %m");
-                        return false;
-                }
+                if (sscanf(line, "%*s %llu %*s", &ull) != 1)
+                        return log_warning_errno(errno_or_else(EIO), "Failed to parse /proc/meminfo field: %m");
 
                 val += ull;
         }