projects
/
linux
/
.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
d3a8573
)
staging: wfx: fix test on return value of gpiod_get_value()
author
Jérôme Pouiller
<jerome.pouiller@silabs.com>
Mon, 19 Oct 2020 16:06:04 +0000
(18:06 +0200)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Tue, 27 Oct 2020 12:23:59 +0000
(13:23 +0100)
The commit
8522d62e6bca
("staging: wfx: gpiod_get_value() can return an
error") has changed the way the driver test the value returned by
gpiod_get_value(). The new code was wrong.
Fixes:
8522d62e6bca
("staging: wfx: gpiod_get_value() can return an error")
Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Link:
https://lore.kernel.org/r/20201019160604.1609180-2-Jerome.Pouiller@silabs.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/wfx/bh.c
patch
|
blob
|
history
diff --git
a/drivers/staging/wfx/bh.c
b/drivers/staging/wfx/bh.c
index 2ffa587aefaa7710f25a67953b6b74d690825b87..ed53d0b455927d7387add3f913c16a4761b48924 100644
(file)
--- a/
drivers/staging/wfx/bh.c
+++ b/
drivers/staging/wfx/bh.c
@@
-21,7
+21,7
@@
static void device_wakeup(struct wfx_dev *wdev)
if (!wdev->pdata.gpio_wakeup)
return;
- if (gpiod_get_value_cansleep(wdev->pdata.gpio_wakeup) >
=
0)
+ if (gpiod_get_value_cansleep(wdev->pdata.gpio_wakeup) > 0)
return;
if (wfx_api_older_than(wdev, 1, 4)) {