veritysetup: print help for --help/-h/help
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Sat, 31 Jul 2021 07:00:11 +0000 (09:00 +0200)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Fri, 6 Aug 2021 14:43:07 +0000 (16:43 +0200)
In general our commands print help on --help, but here this would trigger
the error that two arguments are needed. Let's make this more user-friendly.

(cherry picked from commit 5d5e43cc33637a12f743f17294cfbd3ede08a1b3)
(cherry picked from commit 8d9471cbca46115e6411b78abc5bc67390940cf1)
(cherry picked from commit e5715ab1c75a1b80c1a9a30f7d353b5fd09a93f2a)

src/veritysetup/veritysetup.c

index 558e9510ff0b457ab8a0f0dfb90b2a06b0262889..42baeceb25a6192904c406d2bd0baa68a5be3511 100644 (file)
@@ -47,7 +47,10 @@ static int run(int argc, char *argv[]) {
         _cleanup_(crypt_freep) struct crypt_device *cd = NULL;
         int r;
 
-        if (argc <= 1)
+        if (argc <= 1 ||
+            strv_contains(strv_skip(argv, 1), "--help") ||
+            strv_contains(strv_skip(argv, 1), "-h") ||
+            streq(argv[1], "help"))
                 return help();
 
         if (argc < 3)