journal: fix uninitialized variable use
authorLuca Boccassi <luca.boccassi@microsoft.com>
Thu, 20 May 2021 09:35:36 +0000 (10:35 +0100)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Fri, 9 Jul 2021 16:25:39 +0000 (18:25 +0200)
If the journal file being processed is archivied, seqnum_id will not be
initialized before being passed on, and coverity complains.
Initialize it to zero.

CID #1453235

(cherry picked from commit 06a368e8198a9cbfad86ba17bba6a76a33f15492)

src/libsystemd/sd-journal/journal-vacuum.c

index 0f1c9eb8f73b19dfb5e7f3690bdbcec9f48d4963..e968f3343064f15e5a30124610f5f5bb001ed6cd 100644 (file)
@@ -206,6 +206,9 @@ int journal_directory_vacuum(
                 } else if (endswith(de->d_name, ".journal~")) {
                         unsigned long long tmp;
 
+                        /* seqnum_id won't be initialised before use below, so set to 0 */
+                        seqnum_id = SD_ID128_NULL;
+
                         /* Vacuum corrupted files */
 
                         if (q < 1 + 16 + 1 + 16 + 8 + 1) {