test-process-util: skip several verifications when running in unprivileged container
authorYu Watanabe <watanabe.yu+github@gmail.com>
Thu, 20 Sep 2018 07:08:38 +0000 (16:08 +0900)
committerThe Plumber <50238977+systemd-rhel-bot@users.noreply.github.com>
Tue, 21 Apr 2020 08:45:41 +0000 (10:45 +0200)
(cherry picked from commit 767eab47501b06327a0e6030e5c54860a3fc427f)

Resolves: #1823767

src/test/test-process-util.c

index fd4d17408de612916e321d1189fbcbcce1ade225..26e3247993bd46ac682658d2a51758efdd30f143 100644 (file)
@@ -394,12 +394,17 @@ static void test_rename_process_now(const char *p, int ret) {
         log_info("comm = <%s>", comm);
         assert_se(strneq(comm, p, TASK_COMM_LEN-1));
 
-        assert_se(get_process_cmdline(0, 0, false, &cmdline) >= 0);
+        r = get_process_cmdline(0, 0, false, &cmdline);
+        assert_se(r >= 0);
         /* we cannot expect cmdline to be renamed properly without privileges */
         if (geteuid() == 0) {
-                log_info("cmdline = <%s>", cmdline);
-                assert_se(strneq(p, cmdline, STRLEN("test-process-util")));
-                assert_se(startswith(p, cmdline));
+                if (r == 0 && detect_container() > 0)
+                        log_info("cmdline = <%s> (not verified, Running in unprivileged container?)", cmdline);
+                else {
+                        log_info("cmdline = <%s>", cmdline);
+                        assert_se(strneq(p, cmdline, STRLEN("test-process-util")));
+                        assert_se(startswith(p, cmdline));
+                }
         } else
                 log_info("cmdline = <%s> (not verified)", cmdline);
 }