projects
/
linux
/
.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
dc5bfdf
)
bcachefs: Fix incorrect IS_ERR_OR_NULL usage
author
Kent Overstreet
<kent.overstreet@linux.dev>
Tue, 24 Sep 2024 23:31:22 +0000
(19:31 -0400)
committer
Kent Overstreet
<kent.overstreet@linux.dev>
Sat, 28 Sep 2024 01:46:34 +0000
(21:46 -0400)
Returning a positive integer instead of an error code causes error paths
to become very confused.
Closes: syzbot+
c0360e8367d6d8d04a66
@syzkaller.appspotmail.com
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/btree_node_scan.c
patch
|
blob
|
history
diff --git
a/fs/bcachefs/btree_node_scan.c
b/fs/bcachefs/btree_node_scan.c
index b28c649c68389fb5d261019002ba55175a2afe07..1e694fedc5da049895fa4cb692ca0799ff7f9d5e 100644
(file)
--- a/
fs/bcachefs/btree_node_scan.c
+++ b/
fs/bcachefs/btree_node_scan.c
@@
-275,7
+275,7
@@
static int read_btree_nodes(struct find_btree_nodes *f)
w->ca = ca;
t = kthread_run(read_btree_nodes_worker, w, "read_btree_nodes/%s", ca->name);
- ret =
IS_ERR_OR_NULL
(t);
+ ret =
PTR_ERR_OR_ZERO
(t);
if (ret) {
percpu_ref_put(&ca->io_ref);
closure_put(&cl);