projects
/
linux
/
.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
e541dd7
)
sfc: fix potential memleak in __ef100_hard_start_xmit()
author
Zhang Changzhong
<zhangchangzhong@huawei.com>
Thu, 17 Nov 2022 07:50:09 +0000
(15:50 +0800)
committer
Paolo Abeni
<pabeni@redhat.com>
Tue, 22 Nov 2022 10:28:16 +0000
(11:28 +0100)
The __ef100_hard_start_xmit() returns NETDEV_TX_OK without freeing skb
in error handling case, add dev_kfree_skb_any() to fix it.
Fixes:
51b35a454efd
("sfc: skeleton EF100 PF driver")
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Acked-by: Martin Habets <habetsm.xilinx@gmail.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Link:
https://lore.kernel.org/r/1668671409-10909-1-git-send-email-zhangchangzhong@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/sfc/ef100_netdev.c
patch
|
blob
|
history
diff --git
a/drivers/net/ethernet/sfc/ef100_netdev.c
b/drivers/net/ethernet/sfc/ef100_netdev.c
index 88fa29572e230ec0691a7ca61f30c406b21d72cd..ddcc325ed57018ccd828b58260742faf1d03c106 100644
(file)
--- a/
drivers/net/ethernet/sfc/ef100_netdev.c
+++ b/
drivers/net/ethernet/sfc/ef100_netdev.c
@@
-218,6
+218,7
@@
netdev_tx_t __ef100_hard_start_xmit(struct sk_buff *skb,
skb->len, skb->data_len, channel->channel);
if (!efx->n_channels || !efx->n_tx_channels || !channel) {
netif_stop_queue(net_dev);
+ dev_kfree_skb_any(skb);
goto err;
}