projects
/
linux
/
.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
8775893
)
char/mwave: remove redundant initialization of variable bRC
author
Colin Ian King
<colin.king@canonical.com>
Thu, 11 Jun 2020 15:27:08 +0000
(16:27 +0100)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Fri, 10 Jul 2020 12:50:51 +0000
(14:50 +0200)
The variable bRC is being initialized with a value that is never read
and it is being updated later with a new value. The initialization is
redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link:
https://lore.kernel.org/r/20200611152708.927344-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/mwave/smapi.c
patch
|
blob
|
history
diff --git
a/drivers/char/mwave/smapi.c
b/drivers/char/mwave/smapi.c
index 691f5898bb324610afd6eac05655ee2ed55f0c38..f8d79d393b692e93f0b773437d6af13c7ace2e45 100644
(file)
--- a/
drivers/char/mwave/smapi.c
+++ b/
drivers/char/mwave/smapi.c
@@
-126,7
+126,7
@@
static int smapi_request(unsigned short inBX, unsigned short inCX,
int smapi_query_DSP_cfg(SMAPI_DSP_SETTINGS * pSettings)
{
- int bRC
= -EIO
;
+ int bRC;
unsigned short usAX, usBX, usCX, usDX, usDI, usSI;
static const unsigned short ausDspBases[] = {
0x0030, 0x4E30, 0x8E30, 0xCE30,
@@
-497,7
+497,7
@@
int smapi_set_DSP_cfg(void)
int smapi_set_DSP_power_state(bool bOn)
{
- int bRC
= -EIO
;
+ int bRC;
unsigned short usAX, usBX, usCX, usDX, usDI, usSI;
unsigned short usPowerFunction;