projects / linux / .git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: d04a53b) | patch
mlxsw: spectrum_router: Fix wrong kfree() in error path
authorIdo Schimmel <idosch@nvidia.com>
Tue, 17 Nov 2020 17:46:56 +0000 (19:46 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 18 Nov 2020 19:51:18 +0000 (11:51 -0800)
commitfbf805bf1fcd125461541a171194f9dcdb2732d7
tree7c218e7a65b0a0b20127c06b827690ec571107datree | snapshot
parentd04a53b1c48766665806eb75b73137734abdaa95commit | diff
mlxsw: spectrum_router: Fix wrong kfree() in error path

The function allocates 'nhgi', not 'nh_grp', so it needs to free the
former in its error path.

Fixes: 7f7a417e6a11 ("mlxsw: spectrum_router: Split nexthop group configuration to a different struct")
Addresses-Coverity: ("Memory - corruptions  (USE_AFTER_FREE)")
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c diff | blob | history
https://github.com/torvalds/linux.git