logind: fix emission of PropertiesChanged on seats
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Mon, 21 Oct 2019 13:05:58 +0000 (15:05 +0200)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Mon, 21 Oct 2019 13:05:58 +0000 (15:05 +0200)
commit8cc64c2a3640121745fdfaccc6eae896ac25a911
tree9bf9f0d1ce234aafcd7bee43b13507ce116213fe
parent4b9e5848e31cb2efb606a5292a2d2abb6ba35040
logind: fix emission of PropertiesChanged on seats

The story is the same as in 471cffcfb0e005b7c4044b3b52cc4f25d217efac:
device_attach() → seat_send_changed() → sd_bus_emit_properties_changed_strv()
→ emit_properties_changed_on_interface() → node_vtable_get_userdata()
→ seat_object_find(), which returns 0 because message == NULL.
But when we are emitting a signal, message is always NULL. Removing the
overeager check and assert in the called function allow the signal to be
emitted.

Fixes #13769.
src/login/logind-dbus.c
src/login/logind-seat-dbus.c