projects / linux / .git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: af87f72) | patch
netlink: Don't shift with UB on nlk->ngroups
authorDmitry Safonov <dima@arista.com>
Mon, 30 Jul 2018 17:32:36 +0000 (18:32 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 30 Jul 2018 19:42:22 +0000 (12:42 -0700)
commit61f4b23769f0cc72ae62c9a81cf08f0397d40da8
tree14625a2389a9357a44870604c3bff5f80ee3edcdtree | snapshot
parentaf87f72e757a656d63c8410b1b0598b67d6a9ce3commit | diff
netlink: Don't shift with UB on nlk->ngroups

On i386 nlk->ngroups might be 32 or 0. Which leads to UB, resulting in
hang during boot.
Check for 0 ngroups and use (unsigned long long) as a type to shift.

Fixes: 7acf9d4237c4 ("netlink: Do not subscribe to non-existent groups").
Reported-by: kernel test robot <rong.a.chen@intel.com>
Signed-off-by: Dmitry Safonov <dima@arista.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/netlink/af_netlink.c diff | blob | history
https://github.com/torvalds/linux.git