scsi: lpfc: Fix a possible null pointer dereference
authorHuai-Yuan Liu <qq810974084@gmail.com>
Fri, 21 Jun 2024 08:25:45 +0000 (16:25 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 27 Jun 2024 02:45:04 +0000 (22:45 -0400)
commit5e0bf3e8aec2cbc51123f84b29aaacbd91fc56fa
tree9b802eecbb79f36892f0b7004c4060d8e311698c
parent14d38356ec335b97a04c00719d7b6e73b136d291
scsi: lpfc: Fix a possible null pointer dereference

In function lpfc_xcvr_data_show, the memory allocation with kmalloc might
fail, thereby making rdp_context a null pointer. In the following context
and functions that use this pointer, there are dereferencing operations,
leading to null pointer dereference.

To fix this issue, a null pointer check should be added. If it is null,
use scnprintf to notify the user and return len.

Fixes: 479b0917e447 ("scsi: lpfc: Create a sysfs entry called lpfc_xcvr_data for transceiver info")
Signed-off-by: Huai-Yuan Liu <qq810974084@gmail.com>
Link: https://lore.kernel.org/r/20240621082545.449170-1-qq810974084@gmail.com
Reviewed-by: Justin Tee <justin.tee@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_attr.c