core/manager: do not re-init Manager.lookup_paths when manager_reload()
authorMike Yuan <me@yhndnzj.com>
Wed, 24 Jul 2024 19:24:13 +0000 (21:24 +0200)
committerMike Yuan <me@yhndnzj.com>
Sat, 7 Sep 2024 12:52:50 +0000 (14:52 +0200)
commit30b55e98d1d01d790946d4f8bb197f3f0a9e8e60
tree4299a9f74987f7544be15426c552abfc3047bae1
parente634df9f16c86f5fe78092e071dee23175825254
core/manager: do not re-init Manager.lookup_paths when manager_reload()

Follow-up for 99aad9a2b9e2c06023a2043976fd9395332ff097

The commit changed lookup_paths_init_or_warn() call to
be fatal to manager_reload(), but invoke_main_loop()
assumes that manager_reload() would only return
recoverable error, and put the manager back to
MANAGER_OK in that case, which is spurious.

Looking at it more, it appears to be utterly unnecessary
to reinitialize LookupPaths here, given that nothing during
the reload process would change the search dirs. Let's drop
the path altogether hence.
src/core/manager.c