resolved-dns-query: remove dns_query_candidate_is_routable
authorFlorian Klink <flokli@flokli.de>
Sat, 23 Nov 2019 10:45:34 +0000 (11:45 +0100)
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Sun, 31 May 2020 05:05:13 +0000 (07:05 +0200)
commit2bca2d77d37d93bcad48e104fec499f5e5c3332a
tree626c7ce00abdb4c2670540ca3e6076f41f1d8c8b
parenta3f60204325a820705cd00e87c27d429bd22b252
resolved-dns-query: remove dns_query_candidate_is_routable

Resolved can't reliably determine on whether "it makes sense" to query
AAAA records when not explicitly specifying it in the request, so we
shouldn't remove them.

After having done the resolving, applications can use RFC6724 to
determine whether that address is reachable.

We can't know whether an address is reachable before having resolved it
and inspecting the routing table, and not resolving AAAA just because
there's no IPv6 default route on the main interface link them breaks
various setups, including IPv6-providing wireguard tunnels on a
non-dualstacked environment.

Fixes #5782
Fixes #5915
Fixes #8017

(cherry picked from commit 90bdc8be66765df09bbc355783cee7204a5ebb31)
src/resolve/resolved-dns-query.c